Compiz-core fails to compile with gcc-4.7 - 'cc1plus: all warnings being treated as errors'
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Compiz |
Fix Released
|
Medium
|
Daniel van Vugt | |||
| Compiz Core | Status tracked in 0.9.7 | |||||
| 0.9.7 |
Fix Released
|
Medium
|
Daniel van Vugt | |||
| Arch Linux |
New
|
Undecided
|
Unassigned | |||
| compiz (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
| Precise |
Fix Released
|
Undecided
|
Unassigned | |||
Bug Description
[Impact]
compiz-core source code fails to build with gcc-4.7. This presently does not affect ubuntu systems, which all use gcc <= 4.6.
[Development Fix]
Revision 3091 of lp:compiz-core (same for both 0.9.7 and 0.9.8 series). Removed unnecessary typecast causing comparison between signed and unsigned integers.
[Stable Fix]
As above.
[Test Case]
Compile the compiz-core source code. Make sure it doesn't fail.
[Regression Potential]
Low. It was an obvious type mismatch and has worked perfectly for all developers since being fixed.
ORIGINAL DESCRIPTION:
this morning after upgrading to GCC-4.7 (Archlinux), i then decided to update compiz, but compiz-core failed to build. It would seem GCC-4.7 is stricter and is treating some warnings as errors (that gcc 4.6.3 didn't);
(tail) output from build failure;
Linking CXX static library libcompiz_
[ 28%] Built target compiz_
Scanning dependencies of target compiz_timer
[ 28%] Building CXX object src/timer/
/home/ninez/
/home/ninez/
cc1plus: all warnings being treated as errors
make[2]: *** [src/timer/
make[1]: *** [src/timer/
make: *** [all] Error 2
[ninez@ninez compiz-core]$
However, fixing the problem (locally) was trivial. I added '-Wno-error=
cheerz
Related branches
- Compiz Maintainers: Pending requested
-
Diff: 11 lines (+1/-1)1 file modifiedsrc/timer/src/timeouthandler.cpp (+1/-1)
| triplesqaurednine (triplesquarednine) wrote | #1 |
| rufflove (nat-hulse) wrote | #2 |
| Changed in compiz-core: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → 0.9.7.8 |
| Changed in compiz-core: | |
| assignee: | nobody → Daniel van Vugt (vanvugt) |
| status: | Triaged → In Progress |
| Daniel van Vugt (vanvugt) wrote | #3 |
| Changed in compiz-core: | |
| status: | In Progress → Fix Committed |
| rufflove (nat-hulse) wrote | #4 |
| Daniel van Vugt (vanvugt) wrote | #5 |
| description: | updated |
| Martin Pitt (pitti) wrote Please test proposed package | #6 |
| Changed in compiz (Ubuntu Precise): | |
| status: | New → Fix Committed |
| tags: | added: verification-needed |
| Launchpad Janitor (janitor) wrote | #7 |
| Changed in compiz (Ubuntu): | |
| status: | New → Fix Released |
| Changed in compiz (Ubuntu Precise): | |
| status: | Fix Committed → Fix Released |
| Changed in compiz: | |
| milestone: | none → 0.9.8.0 |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
| assignee: | nobody → Daniel van Vugt (vanvugt) |
| no longer affects: | compiz-core/0.9.8 |
| Changed in compiz-core: | |
| milestone: | 0.9.8.0 → none |
| status: | Fix Committed → Fix Released |
| Changed in compiz: | |
| status: | Fix Committed → Fix Released |
Hey, I know this isn't 'top priority' for you guys, but it does affect people using GCC-4.7, which several distros are already using. The Archlinux (AUR) packagers, fixed this in their packaging, but found the fix through this bug report.
it'd be great if this could be commited upstream, being as compiz won't build without it.
cheerz.
PS: loving 0.9.7+ ... there may be the odd issue, but compiz is definitely improving in a few areas ;)