Crash when accepting a grabbed touch from an indirect device

Bug #877825 reported by Chase Douglas
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xorg-server (Ubuntu)
Won't Fix
Undecided
Unassigned
Oneiric
Fix Released
Medium
Chase Douglas

Bug Description

SRU Justification:
==================
[Impact]
There are no known users of touch grabs in the Oneiric archives. However, development of the new uTouch architecture depends on touch grabs. This bug needs to be fixed as an SRU so further development can take place on Oneiric.

[Development Fix]
This issue will not be fixed in precise because the multitouch code will be different there.

[Stable Fix]
See attached patch. Note that the 'if' statement clause that is just above the patch is "if (first)". The fix is pretty obvious.

[Test Case]
There is not an obvious test case because nothing in the archive tests this functionality. Adventurous testers can checkout the following branches:

lp:~chasedouglas/utouch-frame/v2
lp:~chasedouglas/utouch-grail/rework

Build them sequentially, then run "tools/grail-test-propagation <root window ID>" from the utouch-grail branch. Perform any two touch gesture from a multitouch trackpad (currently limited to Apple trackpads). The server will crash immediately.

[Regression Potential]
Minimal. The fix is an obvious code path issue that can be trivially "proven". It also will not affect anyone on non-multitouch hardware.

Revision history for this message
Chase Douglas (chasedouglas) wrote :
description: updated
Changed in xorg-server (Ubuntu):
status: New → Won't Fix
Changed in xorg-server (Ubuntu Oneiric):
assignee: nobody → Chase Douglas (chasedouglas)
importance: Undecided → Medium
milestone: none → oneiric-updates
status: New → In Progress
Changed in xorg-server (Ubuntu Oneiric):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Chase, or anyone else affected,

Accepted xorg-server into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Chase Douglas (chasedouglas) wrote :

I have installed the xserver-xorg-core package from oneiric-proposed. The updated package has resolved the issue. I no longer get a crash when performing the test case.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:1.10.4-1ubuntu4.2

---------------
xorg-server (2:1.10.4-1ubuntu4.2) oneiric-proposed; urgency=low

  * Fix crash on accepting a touch grab from an indirect device (LP: #877825)
    - Added 510_fix_touchpad_touch_event_removal.patch
 -- Chase Douglas <email address hidden> Tue, 18 Oct 2011 17:33:31 -0700

Changed in xorg-server (Ubuntu Oneiric):
status: Fix Committed → Fix Released
Revision history for this message
Alexander (abonec) wrote :

May be with this update I have this trouble: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/927177

Revision history for this message
Diomas (dmitriy-skopa) wrote :

This patch crash my desktop when I move my mouse... I have to downgrade xorg-server to 2:1.10.4-1ubuntu4. Please, fix it or rollback these changes.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.