fwts: cmosdump: register 0x0b dump annotation is broken

Bug #837969 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
Medium
Colin Ian King

Bug Description

Dumping of RTC register 0x0b in cmosdump annotations have a few errors:

1. 12/24 hour flag is inverted
2. Missing Data Mode (bit 2)
3. Square wave should be dumping bit 3.
4. Update ended IRQ should be dumping bit 4.

Related branches

Revision history for this message
Colin Ian King (colin-king) wrote :

Fixed committed, commit 01b8345dc25c45152ed102b4c17697c289da3e72

Changed in fwts (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Colin King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

And CMOS dump floppy disk info fixed, commit 70b8c77065d33439fcf37f18d4171bebe9c46fe4

Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :
Download full text (5.3 KiB)

A newer version 0.23.23 of fwts is available which fixes this bug and has a load of minor fixes the Oneiric release.

It can be found in my PPA:

https://launchpad.net/~colin-king/+archive/ppa/+packages

Can this be uploaded this to Oneiric universe? I anticipate this is the last major bugfix upload for fwts for this cycle.

This has been soaked tested against hundreds of firmware and kernel log snapshots to check for any regressions.

This new version includes the following major bug fixes since V0.23.13:

    cmos: cmosdump: fix register 0x0b dump (LP: #837969)
    cpu: msr: drop TSC_AUX and SMBASE tests (LP: #834591)
    acpi: acpitables: remove false positive warnings (LP: #833644)
    acpi: method: don't run mobile platform tests on servers (LP: #834554)
    bios: mpcheck: check uniqueness of CPU APIC IDs (LP: #834504)
    hpet: hpet_check: get HPET base on newer kernel logs (LP: #832273)
    apci: fan: use newer thermal interface, test fans on loaded CPU (LP: #831905)
    lib: acpica: ensure table pointers are NULL when table input is corrupt (LP: #826774)
    acpi: lid: fix failure format string (LP: #826676)
    dmi: dmi_decode: fix failure format string (LP: #826418)
    bios: os2gap: fix failure format string (LP: #825945)
    lib: fwts_acpi_tables: read in data correctly (LP: #818042)

 The complete set of changes between V0.23.13 and V0.23.23 is as follows:

    cmos: cmosdump: fix floppy disk info
    cmos: cmosdump: fix register 0x0b dump (LP: #837969)
    bios: multiproc: make mpdump_get_apic_id static
    bios: multiproc: remove redundant mpcheck_get_apic_id()
    cpu: virt: make cpu_has_vmx static
    acpi: lid: make lid_*() static
    acpi: ac_adapter: make ac_adapter_check_field static
    acpi: powerbutton: make power_button_check_field static
    acpi: brightness: make *_setting static
    cpu: virt: make cpu_has_svm, vt_locked_by_bios static
    lib: framework: make init funcs static
    acpi: wmi: make wmi_wdg_flags_to_text() static
    bios: mtrr: rename fwts_virt_cpuinfo to fwts_cpuinfo
    acpi: acpidump: make table_vec static
    cpu: msr: make cpuinfo static
    acpi: ac_adapter: make ac_adapterdir static
    acpi: lid: make liddir static
    acpi: powerbutton: make power_buttondir static
    bios: mtrr: remove redundant mtrr_resource
    acpi: acpidump: fix typo 'Sealed Case'
    cpu: msr: drop TSC_AUX and SMBASE tests (LP: #834591)
    acpi: acpitables: remove false positive warnings (LP: #833644)
    acpi: method: don't run mobile platform tests on servers (LP: #834554)
    bios: mpcheck: check uniqueness of CPU APIC IDs (LP: #834504)
    acpi: cstates: drop experimental status of the test.
    hpet: hpet_check: get HPET base on newer kernel logs (LP: #832273)
    apci: fan: use newer thermal interface, test fans on loaded CPU (LP: #831905)
    lib: acpica: ensure table pointers are NULL when table input is corrupt (LP: #826774)
    acpi: acpitables: tidy up source.
    acpi: wmi: tidy up source.
    acpi: wakealarm: tidy up source.
    acpi: syntaxcheck: tidy up source.
    acpi: s4: tidy up source.
    acpi: s3power: tidy up source.
    acpi: mcfg: fix typo introduced in previous edit.
    acpi: s3: tidy up s...

Read more...

Revision history for this message
Colin Ian King (colin-king) wrote :

Attached: diff between V0.23.13 and V0.23.23

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 0.23.23

---------------
fwts (0.23.23) oneiric; urgency=low

  * cmos: cmosdump: fix floppy disk info
  * cmos: cmosdump: fix register 0x0b dump (LP: #837969)
 -- Colin King <email address hidden> Wed, 31 Aug 2011 17:07:34 +0100

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.