Remove "Share..." link in the details view as this capability is now part of Ratings and Reviews

Bug #743765 reported by Greg A
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Medium
Kiwinote

Bug Description

Binary package hint: software-center

Seeing as the Edit->Copy Web Link menu item uses apt.ubuntu.com, I think that for consistency the microblogging "Share..." link should do the same.

Also according to https://wiki.ubuntu.com/AptUrlRedirector then twitter does not linkify apt urls.

Be aware that apt.ubuntu.com is going to be drastically improved in the near future, a preview is available at apt.marcoceppi.com

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: software-center 3.1.24.2
ProcVersionSignature: Ubuntu 2.6.38-7.39-generic 2.6.38
Uname: Linux 2.6.38-7-generic x86_64
Architecture: amd64
Date: Sun Mar 27 18:30:23 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha amd64 (20110127)
ProcEnviron:
 LANGUAGE=en_GB:en
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: software-center
UpgradeStatus: Upgraded to natty on 2011-03-09 (18 days ago)

Revision history for this message
Greg A (etulfetulf) wrote :
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

The "Share..." links should not be present at all, because ratings and reviews should have replaced them. <https://wiki.ubuntu.com/SoftwareCenter/RatingsAndReviews#reviews-tweeting>

Revision history for this message
Kiwinote (kiwinote) wrote :

It seems quite reasonable to no longer have a share button in the details view, now that we have full microblogging integration via the reviews dialog. I have pushed a commit for this to my branch.

Changed in software-center (Ubuntu):
assignee: nobody → Kiwinote (kiwinote)
importance: Undecided → Low
status: New → Fix Committed
Changed in software-center (Ubuntu):
status: Fix Committed → In Progress
importance: Low → Medium
assignee: Kiwinote (kiwinote) → Gary Lasker (gary-lasker)
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Dang, I worked from a cached copy of this bug is seems and so I didn't see that kiwinote already grabbed this one! Sorry about that, I'll unlink my branch and reassign back.

Thanks for the fix, kiwinote!

NOTE: We will require a UI freeze exception for this one.

Changed in software-center (Ubuntu):
assignee: Gary Lasker (gary-lasker) → Kiwinote (kiwinote)
summary: - "Share..." should use apt.ubuntu.com/p/package rather than apt://package
+ Remove "Share..." link in the details view as this functionality has
+ been replaced with equivalent functionality now included in Ratings and
+ Reviews
summary: - Remove "Share..." link in the details view as this functionality has
- been replaced with equivalent functionality now included in Ratings and
- Reviews
+ Remove "Share..." link in the details view as this capability is now
+ part of Ratings and Reviews
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.7 KiB)

This bug was fixed in the package software-center - 3.1.25

---------------
software-center (3.1.25) natty; urgency=low

  [ Kiwinote ]
  * data/ui/SoftwareCenter.ui:
    - mark the back/forward actions as translatable (LP: #742129)
  * softwarecenter/db/database.py,
    softwarecenter/models/appstore.py,
    softwarecenter/view/availablepane.py,
    others:
    - make custom lists work (LP: #712903)
  * softwarecenter/app.py,
    softwarecenter/distro/Ubuntu.py,
    softwarecenter/view/widgets/pathbar_gtk_atk.py:
    - when the supported filter is set to supported_only, navigate up if:
      - we are in a details view of an app which is not supported (LP: #480827)
      - we are in a list view which becomes empty
  * softwarecenter/app.py,
    softwarecenter/view/catview_gtk.py:
    - correctly count the nr of apps displayed in the recommended category and
      update it when needed (LP: #735634)
    - only display subcategories if they are non-empty (LP: #419270)
  * softwarecenter/backend/weblive.py:
    - don't crash if we try to delete a non-existent file (LP: #743511)
  * softwarecenter/db/reviews.py,
    softwarecenter/distro/Ubuntu.py:
    - fallback to ReviewLoaderJsonAsync when we can't use multiprocessing
      (LP: #741069)
    - fixes to make ReviewLoaderJsonAsync 'work' (ie most common cases)
  * softwarecenter/db/update.py:
    - don't import softwarecenter.log
  * softwarecenter/view/appdetailsview_gtk.py:
    - don't draw random boxes when we have an error layout (LP: #739269)
    - retire share button as we now have full microblogging support in the
      review dialog (LP: #592619, LP: #743765)
  * softwarecenter/view/appview.py:
    - correctly refresh listview when supported filters are changed
  * softwarecenter/view/catview.py:
    - if a category has subcategories, then category.query should include all
      items included in the subcategories, not a subset of these
  * softwarecenter/view/widgets/pathbar_gtk_atk.py:
    - avoid having a half-height pathbar (LP: #743614)
  * refresh .pot file

  [ Gary Lasker ]
  * softwarecenter/view/widgets/reviews.py:
    - fix crash if app_version is not defined when
      calling upstream_version_compare (LP: #746120)
  * softwarecenter/view/purchaseview.py:
    - disconnect webkit signal handlers when the webkit view
      is not showing (LP: #696861)
    - support 'user_cancelled' from the software-center-agent
      (LP: #641321)
  * softwarecenter/view/softwarepane.py,
    softwarecenter/view/widgets/actionbar.py:
    - animate the action bar show/hide
  * softwarecenter/view/appview.py:
    - in the AppViewFilter, also consider apps in the for-purchase
      channel as available; this allows them to show up in
      e.g. What's New (LP: #746679)

  [ Michael Vogt ]
  * softwarecenter/db/update.py:
    - ensure the iconname that comes from the software-center-agent
      does not contain a ".", the icon cache gets confused otherwise
  * merged lp:~evfool/software-center/sfix672229, many thanks to
    Robert Roth (LP: #672229)
  * merged lp:~alexeftimie/software-center/fix-704719-briefly-wrong-display,
    many thanks to Alex Eftimie (LP: #704719)
  * softwarecenter/view/purc...

Read more...

Changed in software-center (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.