eclipse does not work with appmenu

Ted, is that worth investigating?

On Fri, 2010-08-20 at 17:21 +0000, Sebastien Bacher wrote:
> Ted, is that worth investigating?

I don't know, it's probably worth leaving on the list. Since menus are
only default in UNE, and I doubt there are a huge number of Eclipse
users on their netbooks, it seems like Low priority is appropriate.

>Since menus are only default in UNE
True about default, but bigger-laptop users would like to use global menu too. Please investigate on this.

I agree with Nikita. Vertical space is just as precious a commodity for programmers with big laptops as it is for lay-users with tiny netbooks, especially for these, now ubiquitous, 16:9 screens.

I am a desktop user and i would like this to be resolved.. Until that I will switch to the gnome-global-menu, but if I can help I would gladly do it, just let me know...

I am also a desktop user. And this bug is the main reason I finally removed the appmenu after a try. Please fix this bug. Thank you.

I'm a desktop user (running kubuntu desktop) and I also would like this bug to be fixed.

Until it gets fixed, I've found a workaround: the application runs with its own menubar when it runs it with the UBUNTU_MENUPROXY environment variable set to 0. You can run eclipse with the following command:

env UBUNTU_MENUPROXY=0 eclipse

I am using Eclipse on a netbook and would like to use the indicator appmenu so save screen real estate. When running Lucid, it was possible to get menus to display by pressing Alt-F for file, etc. Once displayed, the menu items would remain until Eclipse was restarted. Under Maverick, it isn't possible to get any menus to display.

http://askubuntu.com/questions/10481/does-will-unity-support-disabling-the-global-menu
after that I think this bug importance should be raised :)

This needs to be fixed :(
Eclipse is working great under gnome-globalmenu, maybe the code can be reused!

I opened an appmenu-gtk task for this. This is basically a dup of bug 613119, but since that is the bug that implemented the workaround of disabling the global menu for eclipse, this one can be about fixing the root cause.

There is an upstream bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=330563

From my investigation, I believe it is at least partly caused by the fact that SWT doesn't emit the "realize" signal that appmenu-gtk watches for to start populating the menu.

Here is a test case I've been using. It's a modified AccessibleNameExample from org.eclipse.swt.examples.accessibility.

Marking invalid for appmenu-gtk and appindicator as this is a dbusmenu issue now that the parser is there.

OK, more info and some success. I've managed to get SWT apps that eclipse launches to show in the appmenu [1]. But this fix doesn't affect eclipse itself. So I'm looking into that before I propose a merge.

[1] There's a bug in appmenu-gtk's app_menu_bridge_insert that causes it to ignore already-realized toplevels passed to it.

Here's the fix I mentioned about SWT apps: https://code.launchpad.net/~mterry/appmenu-gtk/rebuild-if-realized/+merge/48827

Eclipse is doing some really funky stuff with their menus. It seems that each menu pops up its own toplevel window that is only created when the menu entry is clicked? I'm putting that aside for the moment. At least other SWT apps can work now.

Will Matlab be benefited from this fix as well?

On Mon, 2011-03-07 at 15:16 +0000, Salva wrote:
> Will Matlab be benefited from this fix as well?

Don't know. Last I used Matlab (about 10 years ago) they were based on
the Motif toolkit -- and that would be a no. Someone with Matlab will
have to check.

Just to confirm, is there still any hope for Eclipse working with the Natty appmenu?

There's hope, but it's slightly dim for natty's release. It's technically possible, just has to be figured out.

bug #725331 is a similar issue about "zend studio" which is an eclipse customized version it seems

Good news, I got most of the items to appear. The appmenu indicator has this trick it does where it fakes an activation on toplevel menu items because some apps lazily calculate menus based on activation signals. But Eclipse actually lazily calculates menus on *show* signals. So faking a show gets the menus to appear.

But now I'm seeing issues with toplevel entries not swapping in and out correctly as you focus different parts of the IDE as well as some menu item labels not updating correctly. Looking into it.

OK. Here's a brain dump. There are several issues with eclipse:
1) Menu items (including toplevel entries) don't appear
2) Some menu items (especially the first in a menu) have the text "Label Empty" instead of real text
3) Accelerators (keyboard shortcuts) are not shown
4) When eclipse wants to change its toplevel entries, that isn't reflected in the appmenu

#1 and #2 can be mostly fixed by showing the menu items as they come in, like I mention in the previous comment.

#2 can be partly fixed by handling how SWT apps handle accelerators (they use deprecated direct access to label structs to set the visible shortcut, then go and separately set the accelerator for the menu item directly). I have a fix for this [1]. But most of eclipse's menu items also don't even pass the accelerator to gtk. They directly set the visible string, but don't set the accelerator on the gtk menu item at all, handling them itself. This needs either a patch to eclipse or a plugin or something. I haven't quite figured where this patch needs to be, but I believe it might be in eclipse/plugins/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java.

#3 I haven't been able to track down. It is passing the items to indicator-appmenu correctly, but the items are never "realized". This is very similar to what I was seeing with #1, so I'm probably just not 'showing/hiding' in the right place.

In summation, I don't believe this is a good use of time for natty. Best for oneiric.

[1] https://code.launchpad.net/~mterry/dbusmenu/check-gmi-for-accel-closures/+merge/54230

Just as add. info:
I have installed natty beta2 (everything up-to-date 2011-04-21), installed eclipse 3.6 (not from software center, I have downloaded zip file).
Eclipse's menu is show 'in-window' (old-style) but when i launch my own rcp app from eclipse the rcp application itself doesn't have any menu, appmenu nor in-window. This is a problem. Any workarounds?

starting eclipse with
  UBUNTU_MENUPROXY=0 && eclipse
did the trick.

The "UBUNTU_MENUPROXY=0" workaround did not work for me. I am also running eclipse from eclipse website and not from the repository.

I think Elvis D. meant to write "UBUNTU_MENUPROXY=0 eclipse" (without the &&).

I've opened a new bug (bug 770263) to deal with the RCP issue. It may be slightly separate from Eclipse itself (which is already worked around anyway).

@Stefan: i have created a start.sh file with following content:
#!/bin/sh
UBUNTU_MENUPROXY=0
cd /opt/helios
./eclipse

i start eclipse using the above file. HTH

With https://code.launchpad.net/~mterry/dbusmenu/eclipse-rcp/+merge/59277 merged, the only remaining issue will be the shortcut labels.

@Elvis D.
Thanks for your help but it still is not working right. Hopefully the new merge will fix it.

I have a freshly installed Natty, with Eclipse 3.6 from eclipse.org and the UBUNTU_MENUPROXY=0 workaround doesn't work for me. Is there any updates on the fix for this?

I encountered this issue with Aptana Studio 3 which is based on Eclipse. Elvis Dominguez's workaround seems to be working for me. https://bugs.launchpad.net/ubuntu/+source/libdbusmenu/+bug/618587/comments/28

This bug was fixed in the package libdbusmenu - 0.4.90-0ubuntu1

---------------
libdbusmenu (0.4.90-0ubuntu1) oneiric; urgency=low

  [ Ted Gould ]
  * debian/control, debian/*: Renaming packages for library version
    bump from 3 to 4.
  * New upstream release.
    * Fixing visibility for Eclipse (LP: #770263 and LP: #618587)
    * Unseting a GValue properly (LP: #785828)
    * Memory leaks for GVariant usage (LP: #784890)
    * Making GTK 3 default build
    * Removing the SerializableMenuitem object
  * debian/rules: Making GTK2 the special build

  [ Ken VanDine ]
  * +debian/libdbusmenu-jsonloader4.symbols
  * debian/*.symbols
    - Fixed sonames and removed all the duplicate symbols
  * debian/*.install, debian/rules
    - Use cdbs to do the dual builds for gtk2/gtk3
  * debian/control
    - Updated standards version to 3.9.2
    - Set version on the json-glib build depends to >= 0.13.4
    - Make gir1.2-dbusmenu-glib-0.4 break gir1.2-unity-3.0 and
      gir1.2-indicate-0.5 built against older versions of dbusmenu to
      prevent breakage in python apps that use gir loading multiple versions
      of dbusmenu-glib
 -- Ken VanDine <email address hidden> Fri, 24 Jun 2011 14:55:59 -0400

> This bug was fixed in the package libdbusmenu - 0.4.90-0ubuntu1

will that be released with the update manager or do I have to install it by my way? i am on ubuntu 11.04

How can I use fixed package on my Ubuntu 11.04?

The fix will be available in Oneiric. For Natty and earlier versions you
will have to wait until the fix is backported (and if it is going to be
backported).

I have uploaded libdbusmenu to my ppa[1] with the fix to this bug for Natty users, Launchpad it seems is quite busy these days and will take quite a few hours to complete the build for libdbusmenu, please test and report back if that fixes the issue and I am working on the SRU as well.

[1] https://launchpad.net/~om26er/+archive/test

Omer Akram, thank you! But which parameter should I pass to Eclipse for using Unity appmenu instead Eclipse inner menu-bar?

Eclipse has been blacklisted. You have to modify package appmenu-gtk and rebuild it to remove it from the blacklist.

thanks Mingming I have now uploaded appmenu-gtk that un blacklists
eclipse to my ppa.

On Sat, Aug 20, 2011 at 8:15 PM, Mingming Ren <email address hidden> wrote:
> Eclipse has been blacklisted. You have to modify package appmenu-gtk and
> rebuild it to remove it from the blacklist.
>
> --
> You received this bug notification because you are a member of DBus Menu
> Team, which is subscribed to libdbusmenu in Ubuntu.
> https://bugs.launchpad.net/bugs/618587
>
> Title:
>  eclipse does not work with appmenu
>
> Status in Application menu module for GTK+:
>  Invalid
> Status in Audacity:
>  Invalid
> Status in DBus Menu:
>  Fix Released
> Status in Eclipse:
>  Unknown
> Status in The Application Menu:
>  Invalid
> Status in Unity Foundations:
>  Fix Released
> Status in “libdbusmenu” package in Ubuntu:
>  Fix Released
>
> Bug description:
>  Binary package hint: indicator-appmenu
>
>  eclipse do not work
>
>  ProblemType: Bug
>  DistroRelease: Ubuntu 10.10
>  Package: indicator-appmenu 0.0.9-0ubuntu1
>  ProcVersionSignature: Ubuntu 2.6.35-15.21-generic 2.6.35.1
>  Uname: Linux 2.6.35-15-generic x86_64
>  NonfreeKernelModules: nvidia
>  Architecture: amd64
>  Date: Mon Aug 16 13:06:20 2010
>  InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha amd64 (20100803.1)
>  ProcEnviron:
>   PATH=(custom, user)
>   LANG=ru_UA.UTF-8
>   SHELL=/bin/bash
>  SourcePackage: indicator-appmenu
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/appmenu-gtk/+bug/618587/+subscriptions
>

with the hack of #46, I get the global menu of Eclipse back in Ubuntu 12.04.
But I don't understand why Ubuntu do this blacklist.

Reading the above, I get the impression that the blacklisting does not get undone because the menu still doesn't work perfectly.

I hacked my library as described in #46 above, then tried out Indigo. The menu seems to integrate into the global menu bar and into the HUD menu.

* Shortcut keys don't work

I did a brief experiment ; alt+<key> seems to open the top level menu, and then a shortcut key without alt will select the relevant menu item. This also works for nested menu items. This appears to behave no differently to the normal SWT shell menu.

So I'm not sure what the issue is here..

* Arrow keys don't work properly

Navigating into submenus with arrow keys doesn't seem to work properly. The first keypress is consumed and the highlight remains in the parent menu. The second keypress seems to work.

This fault is not mentioned above, this is just something that I have noticed today while experimenting. This is of a lesser concern to me because I rarely navigate menus with arrow keys any more - especially the gargantuan menus that Eclipse has.

* Dynamically constructed menus don't work properly

The comments above seem to indicate that this is fixed.

----

It seems what really needs to happen is for someone in the Eclipse packaging team, or someone trusted by the Eclipse packaging team, to perform the hack above, test the menu (to their satisfaction). Since I was able to find one (apparently previously undiscovered) bug in the menu after about 2 minutes of testing, this would seem to require work to fix. Although the problem I found doesn't affect me because of my menu use, I know that it will inevitably annoy someone.

I can see why libappmenu doesn't read it's blacklist from a config file - because previously blacklisted apps might remain blacklisted, even after problems were fixed and removed from the list, because config files could remain. Instead, how about a whitelist as a config file ; those of us who want to accept the minor problems that using the global menu produces can override the blacklist, and should the problems be fixed and the internal blacklist entry be removed, we will be unaffected (apart from things working better), while everyone else gains another app that works with global menus.

After some testing with Eclipse removed from the appmenu blacklist, I can add that currently (in latest versions on Precise) the dynamically constructed menu can re-order the top menu bar ; e.g

Sometimes the menu changes to

  Refactor Navigate File Edit Source Search Project Run Window Help

Instead of

  File Edit Source Refactor Navigate Search Project Run Window Help

A workaround appears to be to put focus in another window and return to Eclipse, which rebuilds the menu in the correct order.

I tried the hack from post #46, it doesn't work for me unfortunately :(
However oddly enough, if I run eclipse with the -clean parameter it does work... I'm not sure why this, any insights?
FYI I'm running Ubuntu 12.04 on a eeePC 1000HE (Eclipse 4.2)

Hm actually I did some further testing, by editing the .desktop file and removing UBUNTU_MENUPROXY=0 from Exec fix the problem with the hack in #46. Please ignore any issue with -clean. Thanks

The most recent version breaks the workaround in #46 - the library file (on a 64-bit system) has moved to

 /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/menuproxies/libappmenu.so

I can confirm that #91 works, Ubuntu 12.10 (64-bit system) with Eclipse Juno.

Please note that no hack is required with the Eclipse version distributed with Android SDK (http://developer.android.com/sdk/index.html), which is probably Eclipse 3.7.2. It works out of the box.

In about 50% cases Eclipse Juno doesn't display icons in the toolbar correctly right after start. (Only the uppert parts of the icons are displayed), so I have to refresh the view manually.

http://stackoverflow.com/questions/14130624/eclipse-and-pdt-i-can-not-type-f-letter-anymore
something related to #72 and other comments. Key binding in main menu changed and editor do not work, in fact context menu report the right binding. I had to revert with

cd /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/menuproxies
sudo sed -i 's/Xclipse/Eclipse/' libappmenu.so

Here ubuntu 12.10, and eclipse 3.8 (ubuntu default repository), 64bit.

To be fair this does not look as as solution, at least not if you are using PDT, or it is a pdt-incompatible solution, for now

I can do tests and post configuration, just ask

I can not confirm that #91 works.
System: Ubuntu 12.10 (64-bit system) with Eclipse Juno (4.2.2)

Is there any hope left that this bug gets fixed in this year? It is really annoying when I have to work with a laptop.

Just to add, when finding and replacing all instances of Eclipse to Xclipse in /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/menuproxie/libappmenu.so, the app menu appears to be fixed, but every time f is pressed, Eclipse formats code instead of typing in an f.

I created package eclipse-globalmenu for patching libappmenu.so (see #46).
Package contains dpkg triggers so patch will be automatically applied to libappmenu.so on every appmenu-gtk update.

Supported appmenu-gtk from precise-updates and above (uses new file place - see #91). Tested on Raring i386 and x86_64.

https://launchpad.net/~mystic-mirage/+archive/eclipse-globalmenu

@Mystic-Mirage: I'm not a package-expert, but sounds cool. One of the biggest problems was that on every appmenu gtk everything was lost.

On the new eclipse version (Kepler), this patch doesn't seem to work for me :-(
Has anybody else yet changed to Kepler?

I have tested Kepler today. The patch is working for me.

Thank you :-)

I somehow managed to remove the complete global menu bar. In case somebody else experienced this, you need those packages:
appmenu-gtk indicator-applet-appmenu indicator-appmenu

@Mystic-Mirage: Sorry for the inconvenience and your package is great!

So the patch is working, and it makes Eclipse behave like applications are supposed to in Ubuntu. Great work, thanks. Then why hasn't the patch been included in the Ubuntu repository, and the Eclipse package made depend on it? Or the patch implemented somehow else? The fix itself has been around for years!

Why do Ubuntu+Eclipse users *still* have to search the web, find this report, and install unofficial repos and unofficial packages or hack a buggy blacklist to get things working?

PLEASE FIX THIS BUG.

eclipse is missing menu items in ubuntu 13.10, workaround is UBUNTU_MENUPROXY= /path/to/eclipse/eclipse

I'm using Aptana, Titanium IDE (which build on Eclipse). I also have same problem. Only "Window" partially works.
screenshot:
http://i.stack.imgur.com/EFyu2.jpg
http://i.stack.imgur.com/qThTi.jpg

I have the same problem as in #108. I am using Springsource Tool Suite (built on eclipse rcp).
Workaroud is to run "export UBUNTU_MENUPROXY= 0 && ./STS" it is nasty (as it moves menu out from top bar) but at least menu is useable.

Same problem as in #108, using a standard Eclipse (http://www.eclipse.org/downloads/download.php?file=/technology/epp/downloads/release/kepler/SR1/eclipse-cpp-kepler-SR1-linux-gtk-x86_64.tar.gz)
Version: Kepler Service Release 1
Build id: 20130919-0819
The problem appeared after switching to Ubuntu 13.10. Fix is in #109 but it's very ugly...

I have run a debugging session from the Eclipse side. When you click the global menu it is producing event that gets handed down to the main SWT loop, there Eclipse takes the event and gives it back to GTK calling gtk_main_do_event for precise targeting of the affected component. Without the global menu the event would popout back from GTK inside the Menu widget triggering something like menuIsAboutToShow callback. With global menu however the event is swallowed and never comes back.

The Java code in Eclipse has no role here nor the super-thin SWT native code. It an apparent regression in the behavior of the GTK library. In other words it is Ubuntu global menu back not being compatible with standard GTK behavior.