Ubuntu
cdbs package

X-Ubuntu-Gettext-Domain line above [Desktop Entry] invalidates .desktop files

Bug #542503 reported by Luke Symes on 2010-03-20

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	cdbs (Ubuntu)	Fix Released	High	Martin Pitt

Bug Description

Binary package hint: cdbs

With cdbs 0.4.62+nmu1ubuntu5, *.desktop files get their X-Ubuntu-Gettext-Domain line at the top of the file, making them invalid and unable to load. Please review the attached branch where I have attempted to fix the relevant sed command.

Related branches

lp:~allsymes/cdbs/fix-translation-domain-adder

Merged into lp:~ubuntu-core-dev/cdbs/ubuntu

Ubuntu Core Development Team: Pending requested 2010-03-20

lp:~ubuntu-core-dev/cdbs/ubuntu

lp:ubuntu/oneiric/cdbs

Revision history for this message

Luke Symes (allsymes) wrote on 2010-03-20:

usr-share-applications.tar.bz2 Edit (1.2 KiB, application/x-tar)

Attached are the actual (and faulty) .desktop files from this nautilus build:
http://launchpadlibrarian.net/41340945/buildlog_ubuntu-lucid-ia64.nautilus_1:2.29.92.1-0ubuntu2_FULLYBUILT.txt.gz

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-03-20:

Thanks for the bug report. This particular bug has already been reported, but feel free to report any other bugs you find.

Changed in cdbs (Ubuntu):
importance:	Undecided → High
status:	New → Fix Released

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-03-20:

the issue is bug #542343 but let this one open for review since it has a patch for the change which has been dropped for now

Changed in cdbs (Ubuntu):
status:	Fix Released → New

Martin Pitt (pitti) on 2010-03-20

Changed in cdbs (Ubuntu):
status:	New → In Progress
assignee:	nobody → Martin Pitt (pitti)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-03-22:

This bug was fixed in the package cdbs - 0.4.62+nmu1ubuntu8

---------------
cdbs (0.4.62+nmu1ubuntu8) lucid; urgency=low

  * Add test/i18n: New test package for testing i18n. For now, ship a couple
    of .desktop files in different variants (simple, with translations, with
    initial empty line, with multiple sections).
  * Add test/langpack-1.mk: Verify that langpack.mk's translation stripping
    and domain addition works in all four cases above.
  * 1/rules/langpack.mk.in: Reintroduce .desktop section fix from
    0.4.62+nmu1ubuntu6, but ensure that we do not match the [Desktop Entry]
    section itself. Thanks to Luke Symes for the patch!
    (LP: #535650, #542503)
-- Martin Pitt <email address hidden> Mon, 22 Mar 2010 09:10:27 +0100