incorrectly disables gnome-screensaver
Bug #53947 reported by
William Jon McCann
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| mplayer (Ubuntu) |
Fix Released
|
Medium
|
Nafallo Bjälevik | ||
Bug Description
I just noticed that you patch mplayer to disable gnome-screensaver by changing the value of the gconf key:
/apps/gnome-
This is not the right way to do it. There are many reasons:
* mplayer may exit, for whatever reason, before it can reenable the screensaver
* more than once instance of mplayer will cause race and contention issues accessing the gconf key
* the gconf key may not be writable if a mandatory policy is in effect
The way it is done now in the patch is potentially a security problem.
You should use either (best to worst):
1. The org.gnome.
2. (g-s 2.15) The "gnome-
3. The "gnome-screensaver --poke" command
Related branches
Revision history for this message
| William Jon McCann (mccann) wrote | #1 |
Revision history for this message
| Ori Avtalion (salty-horse) wrote | #2 |
| Changed in mplayer: | |
| importance: | Undecided → Low |
| status: | Unconfirmed → Confirmed |
| Changed in mplayer: | |
| importance: | Low → Medium |
| Changed in mplayer: | |
| assignee: | nobody → nafallo |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Nafallo Bjälevik (nafallo) wrote | #3 |
| Changed in mplayer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Oh, another reason why this is bad is that even if the screensaver doesn't activate while the movie is playing it will mark the session as idle and gnome-power-manager may power down the screen or computer.