Ubuntu
pkgbinarymangler package

Failure during -dbgsym generation

Bug #520767 reported by Jonathan Thomas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
debhelper (Ubuntu)
Invalid
Critical
Unassigned
pkg-create-dbgsym (Ubuntu)
Fix Released
High
Michael Bienia
pkgbinarymangler (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

Binary package hint: pkgbinarymangler

Tonight two of my uploads, Konversation[1] and Kaffeine[2] have both failed with similar errors during the -dbgsym package generation invoked by pkgbinarymangler. The build system for at least Konversation has not changed at all; the previous upload has an identical debian/rules and built fine. Perhaps the new debhelper is causing issues?

[1] http://launchpadlibrarian.net/39082166/buildlog_ubuntu-lucid-i386.konversation_1.2.2-0ubuntu1_FAILEDTOBUILD.txt.gz
[2] https://edge.launchpad.net/ubuntu/+source/kaffeine/1.0~pre3-1ubuntu1/+build/1504396/+files/buildlog_ubuntu-lucid-amd64.kaffeine_1.0~pre3-1ubuntu1_FAILEDTOBUILD.txt.gz

Related branches

lp:~geser/pkg-create-dbgsym/fix-520767
Ubuntu Core Development Team: Pending requested
Diff: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
dh_strip (+1/-1)
lp:pkg-create-dbgsym
lp:ubuntu/lucid/pkg-create-dbgsym
Jonathan Thomas (echidnaman)
Changed in debhelper (Ubuntu):
importance: Undecided → High
Changed in pkgbinarymangler (Ubuntu):
importance: Undecided → High
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

Also affects konq-plugins...

Changed in debhelper (Ubuntu):
importance: High → Critical
Changed in pkgbinarymangler (Ubuntu):
importance: High → Critical
Changed in debhelper (Ubuntu):
milestone: none → lucid-alpha-3
Changed in pkgbinarymangler (Ubuntu):
milestone: none → lucid-alpha-3
milestone: lucid-alpha-3 → none
Revision history for this message
Martin Pitt (pitti) wrote :

This is a documented debhelper option, so we should just cope with it in pkg-create-dbgsym.

Changed in pkgbinarymangler (Ubuntu):
status: New → Invalid
Changed in debhelper (Ubuntu):
milestone: lucid-alpha-3 → none
status: New → Invalid
Revision history for this message
Martin Pitt (pitti) wrote :

Oh, this issue might indeed affect pkgbinarymangler as well, let's keep it open to check.

Changed in pkgbinarymangler (Ubuntu):
status: Invalid → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkg-create-dbgsym - 0.39

---------------
pkg-create-dbgsym (0.39) lucid; urgency=low

  * Strip -O from options passed from dh (LP: #520767).
 -- Michael Bienia <email address hidden> Mon, 15 Feb 2010 12:22:05 +0100

Changed in pkg-create-dbgsym (Ubuntu):
status: New → Fix Released
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

That fixed both kaffeine and konversation, thanks. konq-plugins seems to be a different, unrelated issue. (I didn't look closely at the buildlog)

Changed in pkgbinarymangler (Ubuntu):
importance: Critical → Undecided
Revision history for this message
Anders Kaseorg (andersk) wrote :

This needs a further fix in dh_strip. Currently barnowl FTBFS without this fix (see bug 557346).

--- dh_strip.old 2010-02-15 06:15:04.000000000 -0500
+++ dh_strip 2010-04-07 18:35:12.230331510 -0400
@ -150,7 +150,7 @
             next_arg_is_xopt=1
             ;;
         -X*)
- xopts="$xopts $p"
+ xopts="$xopts ${p#-O}"
             ;;
     esac

Changed in pkg-create-dbgsym (Ubuntu):
status: Fix Released → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Anders, $xopts is the argument of -X, which handles file names, not options. I don't understand your change, I'm afraid. Perhaps you can write a test case for it in your branch before I merge it?

Michael's fix looks fine, I'll merge that.

Revision history for this message
Martin Pitt (pitti) wrote :

I merged Michael's fix, thanks! Uploaded to UNAPPROVED.

Changed in pkgbinarymangler (Ubuntu):
status: New → Invalid
Changed in pkg-create-dbgsym (Ubuntu):
assignee: nobody → Michael Bienia (geser)
importance: Undecided → High
status: In Progress → Fix Committed
Revision history for this message
Anders Kaseorg (andersk) wrote :

Michael’s fix also fixes my bug, so that’s fine with me.

(But to answer your question, the problem was that ‘dh -Xfilename’ called ‘dh_strip -O-Xfilename’, which triggered
    case "${p#-O}" in
        …
        -X*)
            xopts="$xopts $p"
            ;;
and added -O-Xfilename to $xopts rather than -Xfilename, confusing pkg_create_dbgsym. My fix stripped the -O while assigning to xopts, and Michael’s fix strips the -O in place before the case statement. The latter is probably better because it would also work for -O-p, -O-N, -O-P.)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkg-create-dbgsym - 0.40

---------------
pkg-create-dbgsym (0.40) lucid; urgency=low

  * Strip -O from options passed from dh not only for comparison but also for
    processing them. (LP: #520767)
 -- Michael Bienia <email address hidden> Thu, 08 Apr 2010 10:35:01 +0200

Changed in pkg-create-dbgsym (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.