where do in-progress mps go to?

On Fri, 27 Nov 2009 16:33:26 Martin Pool wrote:
> Public bug reported:
>
> If I change an mp status to 'in progress' it seems to disappear from
> +activereviews. It's probably not something that reviewers can do
> anything about anymore, so it's reasonable that it at least be severely
> deprioritized. But it now does not seem to be reachable in the web ui
> at all?
>
> ** Affects: launchpad-code
> Importance: Undecided
> Status: New

  status invalid

It is accessible through the web UI from the source branch.

>vila: let me get the code
> vila: argh, marked wip I presume, it went out of the active review page :-/

I think we need to reconsider this. wip merge proposals represent a particular kind of inventory and it's not so obvious to find them from the branch page, afaics.

> It is accessible through the web UI from the source branch.

That's fine for the submitter but how can the reviewer know to go there ?

You can argue that since it's wip the reviewer doesn't need to be involved but the case at hand is that there can still be discussion between the submitter and the reviewer while the work is in progress...

I also explicitly don't want the mp back in the +activereviews page ! :D

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>> It is accessible through the web UI from the source branch.
>
> That's fine for the submitter but how can the reviewer know to go there
> ?
>
> You can argue that since it's wip the reviewer doesn't need to be
> involved but the case at hand is that there can still be discussion
> between the submitter and the reviewer while the work is in progress...

You can also get to it from the +merges page, e.g.
https://code.edge.launchpad.net/bzr/+merges?field.status=WORK_IN_PROGRESS&field.status-empty-marker=1

The merges page can be hard to find. I'd love it if activereviews also
provided a way to get to +merges.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkseYpgACgkQ0F+nu1YWqI0J0gCfXAuJmZOJ1rqQ5TVnXgdsO59O
zcUAn0ins0LwZaADnFgJP2uz+P8Pd9WQ
=0HMD
-----END PGP SIGNATURE-----

2009/12/9 Aaron Bentley <email address hidden>:
> You can also get to it from the +merges page, e.g.
> https://code.edge.launchpad.net/bzr/+merges?field.status=WORK_IN_PROGRESS&field.status-empty-marker=1

Wow, that's quite cool.

> The merges page can be hard to find.  I'd love it if activereviews also
> provided a way to get to +merges.

+1

--
Martin <http://launchpad.net/~mbp/>

Probably quite strongly related to bug 263920

I think my fix lp:~thumper/launchpad/branch-active-reviews for bug 263920 and bug 490139 will fix this.