Launchpad itself

'X branches proposed for merging' goes +merges not +activereviews on branch page

Bug #490139 reported by Robert Collins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Tim Penhey
Launchpad itself 10.01

Bug Description

e.g on https://code.edge.launchpad.net/~testtools-dev/testtools/trunk

"5 branches proposed for merging into this one." links to a page
containing > 20 branches.

-Rob

 affects launchpad-code

Tags: lp-code

Related branches

lp:~thumper/launchpad/branch-active-reviews
Michael Nelson (community): Approve (ui)
Paul Hummer (community): Approve (code ui*)
Diff: 159 lines (+42/-21)
6 files modified
lib/lp/code/browser/branchmergeproposallisting.py (+12/-6)
lib/lp/code/browser/configure.zcml (+7/-0)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+0/-14)
lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt (+16/-0)
lib/lp/code/templates/active-reviews.pt (+6/-0)
lib/lp/code/templates/branch-pending-merges.pt (+1/-1)
Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 490139] [NEW] 'X branches proposed for merging' goes +merges not +activereviews on branch page

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Public bug reported:
> "5 branches proposed for merging into this one." links to a page
> containing > 20 branches.

Now it's "2 branches proposed...", and of the > 20 branches, one is
"Needs review" and one is "Approved".

I would like to see the +activereviews style used as the default
everywhere, with the +merges page linked as a way for people to see
inactive reviews.

Aaron

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAksT3hIACgkQ0F+nu1YWqI055gCY43fmW5bJYIkDTckpp426DdjZ
kgCeOUWVVw5INarzRwVQVW43ZwUUd2g=
=rrcS
-----END PGP SIGNATURE-----

Tim Penhey (thumper)
Changed in launchpad-code:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Tim Penhey (thumper)
milestone: none → 10.01
Tim Penhey (thumper)
Changed in launchpad-code:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.