Launchpad itself

No way to see merged/inactive code reviews for a project

Bug #263920 reported by James Henstridge
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Tim Penhey
Launchpad itself 10.01

Bug Description

While showing a new developer the ropes of our code review process, I wanted to show a few completed code reviews as examples.

I couldn't see an obvious way display this from either the project code page or the development focus branch page. A quick browse of the source code didn't show anything either.

It'd be nice to have a view like $project/+activereviews but for old merge proposals.

Related branches

lp:~thumper/launchpad/branch-active-reviews
Michael Nelson (community): Approve (ui)
Paul Hummer (community): Approve (code ui*)
Diff: 159 lines (+42/-21)
6 files modified
lib/lp/code/browser/branchmergeproposallisting.py (+12/-6)
lib/lp/code/browser/configure.zcml (+7/-0)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+0/-14)
lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt (+16/-0)
lib/lp/code/templates/active-reviews.pt (+6/-0)
lib/lp/code/templates/branch-pending-merges.pt (+1/-1)
Revision history for this message
Jonathan Lange (jml) wrote :

Good point.

Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
James Westby (james-w) wrote :

I just hit something which I think may be the same bug, though perhaps not.

I wanted to see the discussion on a patch that had just been merged, so I went to

  https://code.edge.launchpad.net/~ubuntu-core-dev/gnome-control-center/ubuntu

which is the branch that merged the change. I clicked on "merge proposals" from the top bar,
and was shown

  https://code.edge.launchpad.net/~ubuntu-core-dev/gnome-control-center/ubuntu/+merges

which currently contains diddly-squat. If there are no active merge requests then showing nothing
is fine, but I would have expected a search/filter form to choose merge requests by status and
search for keywords.

I did eventually find the request by guessing which branch it came from, and clicking on "Merged in to ..."

Thanks,

James

Revision history for this message
Martin Pool (mbp) wrote :

This would also be useful on people. In that case, as a manager, I'd like to see a timeline-like view of all the reviews someone's proposed or participated in, including both open and finished reviews.

summary: - No way to see inactive code reviews for a project
+ No way to see merged/inactive code reviews for a project
Revision history for this message
Aaron Bentley (abentley) wrote :

You can actually see them with +merges?field.status=MERGED instead of +activereviews. I don't know how you'd navigate there, though.

Revision history for this message
Jonathan Lange (jml) wrote :

Probably quite strongly related to bug 489036

Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → In Progress
assignee: nobody → Tim Penhey (thumper)
milestone: none → 10.01
Tim Penhey (thumper)
Changed in launchpad-code:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.