nm applet doesn't close notification when it is obsolete

Bug #460144 reported by Maxim Levitsky
94
This bug affects 13 people
Affects Status Importance Assigned to Milestone
Network Manager Applet
Unknown
Medium
One Hundred Papercuts
Fix Released
Medium
Tony Espy
network-manager-applet (Ubuntu)
Fix Released
Low
Unassigned
notify-osd (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

What happens is that each time, new notification is shown it stays on screen, even if already obsolete.
For example if you rapidly connect and disconnect to ap say 5 times, you will see for many minutes the notifications about 'connected' 'disconnected'

affects: ubuntu → network-manager-applet (Ubuntu)
Revision history for this message
Vish (vish) wrote :

This is a problem because , network manager use asynchronous notifications, which are under notify-osd's queue control, hence the difference in notification reception and notification display.

Whereas the volume/brightness/eject notifications are synchronous (or feedback) notifications... they get displayed immediately (replacing and previous sync. notification if displayed)

This is not an upstream issue but rather an Ubuntu specific issue.

Changed in network-manager-applet (Ubuntu):
status: New → Confirmed
Revision history for this message
Vish (vish) wrote :

I'v earlier asked Mirco regarding this issue , and if network manager can send the notifications as sync notifications.
He mentioned that the network-manager is _not_ supposed to send sync notifications as they are specifically reserved for direct "hardware-feedback" type of notifications.
And that there might be a need for some conceptual change in network-manager or notify-osd. [Something which has to be yet specked]

Changed in notify-osd (Ubuntu):
status: New → Confirmed
Brian Curtis (bcurtiswx)
Changed in notify-osd (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Low
Changed in network-manager-applet (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Low
Revision history for this message
Ryan Fugger (rfugger) wrote :

As detailed in bug #460964, network manager can merge asynchronous notifications when a new one should supercede an old one by giving them the same title. This is in keeping with then notify-osd guidelines:

https://wiki.ubuntu.com/NotifyOSD#Merging%20notifications

Assuming notify-osd is implemented according to the spec, it should be a relatively easy fix. Doesn't really affect notify-osd.

Revision history for this message
Vish (vish) wrote :

@rfugger :
Merging is text a + text b .
But here we cant do that.
The text a needs to be _replaced_ with text b ...

Revision history for this message
Mirco Müller (macslow) wrote :

Here is a stand-alone example in ANSI C of how to correctly update/replace the content of a notification/bubble. The simulated use-case is that of NetworkManager disconnecting and reconnecting after a resume from suspend. Be sure to check the top of the source-file about how to compile and run it.

Revision history for this message
Vish (vish) wrote :

Adding papercut task and assign Tony from duplicate

Changed in hundredpapercuts:
assignee: nobody → Tony Espy (awe)
importance: Undecided → Medium
milestone: none → lucid-round-8
status: New → Triaged
Revision history for this message
Mirco Müller (macslow) wrote :

almost done... here are the fixes (nm-applet, notify-osd) at work -> http://macslow.net/clips/nm-applet-correctly-updates.ogv

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package notify-osd - 0.9.27-0ubuntu1

---------------
notify-osd (0.9.27-0ubuntu1) lucid; urgency=low

  * New upstream version:
    - Small maintainance release to fix LP: #525546, so appending works
      correctly. This release is also a prerequisite for fixing nm-applet bug
      LP: #460144 (or papercut LP: #530041).
    - updates to the title- and body-tiles (surface/blur-cache) were
      not always done correctly (lp: #525546)
 -- Sebastien Bacher <email address hidden> Tue, 09 Mar 2010 16:12:46 +0100

Changed in notify-osd (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager-applet - 0.8-0ubuntu3

---------------
network-manager-applet (0.8-0ubuntu3) lucid; urgency=low

  [ Mirco Müller (MacSlow) <email address hidden> ]
  * Make nm-applet correctly update a notification, if the connection-status
    has changed. This avoids displaying obsolete notifications to the user,
    which no longer reflect the correct connection-status. Fixes LP: #460144
    - add debian/patches/lp460144_correctly_update_notification.patch
    - update debian/patches/series

  [ Chris Coulson <<email address hidden> ]
  * Update bgo609134_lazy_icons.patch with the change actually committed
    to GIT
 -- Alexander Sack <email address hidden> Tue, 30 Mar 2010 10:39:18 +0200

Changed in network-manager-applet (Ubuntu):
status: Triaged → Fix Released
Vish (vish)
Changed in hundredpapercuts:
status: Triaged → Fix Released
Changed in network-manager-applet:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.