Main Inclusion Report for facter.
Bug #408402 reported by
Chuck Short
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| facter (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Lucid |
Fix Released
|
Undecided
|
Unassigned | ||
| ruby-pkg-tools (Ubuntu) |
Invalid
|
High
|
Chuck Short | ||
| Lucid |
Invalid
|
High
|
Chuck Short | ||
Bug Description
Binary package hint: facter
Facter is a build dependency for puppet.
https:/
If you have any questions please let me know.
Regards
chuck
Related branches
lp:~gandelman-a/ubuntu/precise/facter/lp877621
- Dave Walker (community): Approve
- Ubuntu branches: Pending requested
-
Diff: 5755 lines (+2480/-1339)126 files modifiedCHANGELOG (+92/-0)
CONTRIBUTING.md (+299/-0)
COPYING (+0/-339)
LICENSE (+15/-17)
README (+0/-8)
README.md (+24/-0)
README.rst (+0/-26)
Rakefile (+3/-3)
TODO (+0/-4)
accecptance/tests/ticket_7039_facter_multiple_facts_one_file.rb (+0/-31)
autotest/discover.rb (+0/-9)
autotest/facter_rspec.rb (+0/-45)
autotest/rspec.rb (+0/-74)
bin/facter (+2/-2)
conf/redhat/facter.spec (+6/-3)
conf/solaris/pkginfo (+1/-1)
debian/changelog (+27/-0)
debian/compat (+1/-1)
debian/control (+5/-3)
debian/copyright (+69/-61)
debian/docs (+1/-2)
debian/facter.8 (+26/-27)
debian/facter.install (+0/-2)
documentation/custom.page (+0/-22)
documentation/index.page (+0/-19)
ext/facter-diff (+0/-74)
install.rb (+26/-11)
lib/facter.rb (+31/-19)
lib/facter/Cfkey.rb (+11/-11)
lib/facter/application.rb (+3/-4)
lib/facter/architecture.rb (+13/-0)
lib/facter/arp.rb (+1/-1)
lib/facter/augeasversion.rb (+29/-0)
lib/facter/domain.rb (+31/-12)
lib/facter/facterversion.rb (+9/-0)
lib/facter/fqdn.rb (+11/-0)
lib/facter/hardwareisa.rb (+14/-2)
lib/facter/hardwaremodel.rb (+13/-0)
lib/facter/hostname.rb (+17/-9)
lib/facter/id.rb (+13/-0)
lib/facter/interfaces.rb (+9/-0)
lib/facter/ipaddress.rb (+24/-0)
lib/facter/ipaddress6.rb (+48/-44)
lib/facter/iphostnumber.rb (+11/-0)
lib/facter/kernel.rb (+14/-3)
lib/facter/kernelmajversion.rb (+10/-0)
lib/facter/kernelrelease.rb (+15/-4)
lib/facter/kernelversion.rb (+12/-0)
lib/facter/lsb.rb (+13/-12)
lib/facter/lsbmajdistrelease.rb (+13/-1)
lib/facter/macaddress.rb (+31/-30)
lib/facter/macosx.rb (+13/-11)
lib/facter/manufacturer.rb (+18/-0)
lib/facter/memory.rb (+67/-22)
lib/facter/netmask.rb (+9/-0)
lib/facter/network.rb (+12/-0)
lib/facter/operatingsystem.rb (+19/-0)
lib/facter/operatingsystemrelease.rb (+28/-2)
lib/facter/path.rb (+9/-0)
lib/facter/physicalprocessorcount.rb (+62/-5)
lib/facter/processor.rb (+52/-1)
lib/facter/ps.rb (+17/-0)
lib/facter/puppetversion.rb (+10/-0)
lib/facter/rubysitedir.rb (+10/-0)
lib/facter/rubyversion.rb (+9/-0)
lib/facter/selinux.rb (+72/-48)
lib/facter/ssh.rb (+9/-11)
lib/facter/timezone.rb (+9/-0)
lib/facter/uniqueid.rb (+2/-2)
lib/facter/uptime.rb (+11/-0)
lib/facter/uptime_days.rb (+9/-0)
lib/facter/uptime_hours.rb (+9/-0)
lib/facter/uptime_seconds.rb (+14/-0)
lib/facter/util/collection.rb (+5/-1)
lib/facter/util/config.rb (+9/-0)
lib/facter/util/fact.rb (+1/-3)
lib/facter/util/ip.rb (+26/-3)
lib/facter/util/loader.rb (+12/-0)
lib/facter/util/macaddress.rb (+20/-0)
lib/facter/util/macosx.rb (+0/-11)
lib/facter/util/manufacturer.rb (+10/-5)
lib/facter/util/memory.rb (+1/-13)
lib/facter/util/resolution.rb (+30/-12)
lib/facter/util/uptime.rb (+6/-5)
lib/facter/util/virtual.rb (+1/-1)
lib/facter/util/wmi.rb (+16/-0)
lib/facter/virtual.rb (+61/-8)
lib/facter/vlans.rb (+10/-0)
lib/facter/xendomains.rb (+11/-0)
man/man8/facter.8 (+0/-54)
spec/fixtures/netsh/windows_netsh_addresses_with_multiple_interfaces (+35/-0)
spec/fixtures/unit/util/loader/nosuchfact.rb (+1/-0)
spec/spec.opts (+0/-5)
spec/spec_helper.rb (+2/-0)
spec/unit/data/windows_netsh_all_interfaces (+12/-0)
spec/unit/data/windows_netsh_single_interface (+7/-0)
spec/unit/data/windows_netsh_single_interface6 (+18/-0)
spec/unit/domain_spec.rb (+91/-0)
spec/unit/facter_spec.rb (+21/-0)
spec/unit/hostname_spec.rb (+38/-0)
spec/unit/id_spec.rb (+6/-5)
spec/unit/interfaces_spec.rb (+9/-5)
spec/unit/ipaddress6_spec.rb (+19/-0)
spec/unit/macaddress_spec.rb (+38/-0)
spec/unit/memory_spec.rb (+29/-1)
spec/unit/operatingsystem_spec.rb (+30/-0)
spec/unit/operatingsystemrelease_spec.rb (+19/-8)
spec/unit/physicalprocessorcount_spec.rb (+51/-0)
spec/unit/processor_spec.rb (+66/-0)
spec/unit/selinux_spec.rb (+1/-0)
spec/unit/util/fact_spec.rb (+11/-11)
spec/unit/util/ip_spec.rb (+83/-21)
spec/unit/util/loader_spec.rb (+12/-0)
spec/unit/util/macaddress_spec.rb (+28/-1)
spec/unit/util/manufacturer_spec.rb (+21/-0)
spec/unit/util/resolution_spec.rb (+46/-16)
spec/unit/util/uptime_spec.rb (+13/-2)
spec/unit/util/virtual_spec.rb (+1/-0)
spec/unit/util/wmi_spec.rb (+20/-0)
spec/unit/virtual_spec.rb (+70/-4)
tasks/rake/changlog.rake (+0/-15)
tasks/rake/ci.rake (+0/-16)
tasks/rake/dailybuild.rake (+0/-9)
tasks/rake/mail_patches.rake (+0/-46)
tasks/rake/metrics.rake (+0/-6)
tasks/rake/sign.rake (+0/-14)
lp:~gandelman-a/ubuntu/precise/facter/lp888671
- Dave Walker (community): Approve
- Ubuntu branches: Pending requested
-
Diff: 10595 lines (+6067/-3319)94 files modified.pc/.version (+1/-0)
.pc/applied-patches (+1/-0)
.pc/no-require-rubygems/lib/facter/application.rb (+123/-0)
CHANGELOG (+31/-0)
Rakefile (+41/-36)
conf/redhat/facter.spec (+11/-4)
conf/solaris/pkginfo (+1/-1)
debian/changelog (+27/-6)
debian/control (+2/-2)
debian/patches/no-require-rubygems (+15/-0)
debian/patches/series (+1/-0)
debian/rules (+5/-2)
install.rb (+314/-314)
lib/facter.rb (+229/-229)
lib/facter/Cfkey.rb (+24/-24)
lib/facter/architecture.rb (+22/-30)
lib/facter/domain.rb (+39/-39)
lib/facter/facterversion.rb (+1/-1)
lib/facter/fqdn.rb (+8/-8)
lib/facter/hardwareisa.rb (+2/-2)
lib/facter/hardwaremodel.rb (+19/-19)
lib/facter/hostname.rb (+14/-14)
lib/facter/id.rb (+3/-3)
lib/facter/interfaces.rb (+13/-13)
lib/facter/ipaddress.rb (+123/-123)
lib/facter/iphostnumber.rb (+14/-14)
lib/facter/kernel.rb (+7/-7)
lib/facter/kernelmajversion.rb (+3/-3)
lib/facter/kernelrelease.rb (+18/-18)
lib/facter/kernelversion.rb (+5/-5)
lib/facter/lsb.rb (+14/-14)
lib/facter/lsbmajdistrelease.rb (+8/-8)
lib/facter/macaddress.rb (+63/-63)
lib/facter/macosx.rb (+26/-26)
lib/facter/manufacturer.rb (+28/-28)
lib/facter/memory.rb (+173/-145)
lib/facter/netmask.rb (+4/-4)
lib/facter/network.rb (+4/-4)
lib/facter/operatingsystem.rb (+83/-79)
lib/facter/operatingsystemrelease.rb (+113/-107)
lib/facter/osfamily.rb (+31/-0)
lib/facter/path.rb (+3/-3)
lib/facter/physicalprocessorcount.rb (+8/-0)
lib/facter/processor.rb (+103/-84)
lib/facter/ps.rb (+3/-3)
lib/facter/puppetversion.rb (+7/-7)
lib/facter/rubysitedir.rb (+5/-5)
lib/facter/rubyversion.rb (+1/-1)
lib/facter/ssh.rb (+16/-16)
lib/facter/timezone.rb (+3/-3)
lib/facter/uniqueid.rb (+2/-2)
lib/facter/util/collection.rb (+122/-122)
lib/facter/util/confine.rb (+34/-34)
lib/facter/util/fact.rb (+115/-115)
lib/facter/util/ip.rb (+197/-197)
lib/facter/util/loader.rb (+106/-106)
lib/facter/util/macosx.rb (+52/-52)
lib/facter/util/manufacturer.rb (+97/-97)
lib/facter/util/memory.rb (+79/-79)
lib/facter/util/netmask.rb (+38/-38)
lib/facter/util/plist.rb (+1/-1)
lib/facter/util/plist/generator.rb (+209/-209)
lib/facter/util/plist/parser.rb (+204/-204)
lib/facter/util/processor.rb (+88/-0)
lib/facter/util/resolution.rb (+175/-175)
lib/facter/util/uptime.rb (+59/-59)
lib/facter/util/values.rb (+9/-9)
lib/facter/util/virtual.rb (+81/-71)
lib/facter/util/vlans.rb (+17/-17)
lib/facter/virtual.rb (+126/-131)
lib/facter/vlans.rb (+6/-6)
spec/fixtures/cpuinfo/amd64dual (+57/-0)
spec/fixtures/cpuinfo/amd64quad (+79/-0)
spec/fixtures/cpuinfo/amd64solo (+23/-0)
spec/fixtures/cpuinfo/amd64tri (+86/-0)
spec/fixtures/cpuinfo/bbg3-armel (+12/-0)
spec/fixtures/cpuinfo/beaglexm-armel (+12/-0)
spec/fixtures/cpuinfo/panda-armel (+17/-0)
spec/fixtures/cpuinfo/ppc64 (+19/-0)
spec/fixtures/cpuinfo/sparc (+10/-0)
spec/fixtures/processorcount/solaris-sparc-kstat-cpu-info (+1216/-0)
spec/fixtures/processorcount/solaris-x86_64-kstat-cpu-info (+225/-0)
spec/integration/facter_spec.rb (+21/-21)
spec/spec_helper.rb (+10/-1)
spec/unit/architecture_spec.rb (+54/-0)
spec/unit/domain_spec.rb (+23/-0)
spec/unit/memory_spec.rb (+78/-1)
spec/unit/physicalprocessorcount_spec.rb (+47/-41)
spec/unit/processor_spec.rb (+184/-3)
spec/unit/util/processor_spec.rb (+62/-0)
spec/unit/util/uptime_spec.rb (+4/-4)
spec/unit/util/virtual_spec.rb (+26/-5)
spec/unit/virtual_spec.rb (+47/-2)
spec/watchr.rb (+125/-0)
lp:~gandelman-a/ubuntu/precise/facter/merge922788
- Ubuntu branches: Pending requested
-
Diff: 6642 lines (+3054/-2736)64 files modifiedCHANGELOG (+18/-0)
LICENSE (+1/-1)
conf/osx/createpackage.sh (+1/-1)
conf/redhat/facter.spec (+13/-6)
conf/solaris/pkginfo (+1/-1)
debian/changelog (+35/-0)
debian/control (+1/-1)
debian/facter.dirs (+0/-1)
install.rb (+14/-17)
lib/facter.rb (+2/-2)
lib/facter/architecture.rb (+1/-2)
lib/facter/augeasversion.rb (+1/-2)
lib/facter/domain.rb (+3/-3)
lib/facter/hardwareisa.rb (+1/-1)
lib/facter/ipaddress.rb (+2/-2)
lib/facter/lsbmajdistrelease.rb (+1/-1)
lib/facter/macaddress.rb (+2/-2)
lib/facter/manufacturer.rb (+6/-1)
lib/facter/netmask.rb (+0/-3)
lib/facter/network.rb (+2/-3)
lib/facter/operatingsystem.rb (+5/-2)
lib/facter/operatingsystemrelease.rb (+3/-3)
lib/facter/osfamily.rb (+1/-1)
lib/facter/processor.rb (+2/-2)
lib/facter/selinux.rb (+3/-3)
lib/facter/uniqueid.rb (+1/-1)
lib/facter/uptime_days.rb (+0/-1)
lib/facter/uptime_hours.rb (+0/-1)
lib/facter/util/macaddress.rb (+1/-0)
lib/facter/util/manufacturer.rb (+2/-3)
lib/facter/util/processor.rb (+3/-3)
lib/facter/util/resolution.rb (+3/-3)
lib/facter/util/values.rb (+1/-1)
lib/facter/virtual.rb (+2/-2)
lib/facter/vlans.rb (+1/-2)
lib/facter/xendomains.rb (+0/-1)
spec/fixtures/ifconfig/linux_ifconfig_no_mac (+8/-0)
spec/fixtures/ifconfig/linux_ifconfig_venet (+24/-0)
spec/fixtures/unit/util/manufacturer/solaris_sunfire_v120_prtdiag (+33/-0)
spec/fixtures/unit/util/manufacturer/solaris_t5220_prtdiag (+136/-0)
spec/spec_helper.rb (+5/-0)
spec/unit/architecture_spec.rb (+44/-44)
spec/unit/facter_spec.rb (+266/-264)
spec/unit/id_spec.rb (+21/-21)
spec/unit/interfaces_spec.rb (+6/-6)
spec/unit/macaddress_spec.rb (+36/-12)
spec/unit/memory_spec.rb (+137/-137)
spec/unit/operatingsystem_spec.rb (+82/-73)
spec/unit/operatingsystemrelease_spec.rb (+50/-49)
spec/unit/processor_spec.rb (+2/-2)
spec/unit/selinux_spec.rb (+80/-80)
spec/unit/util/collection_spec.rb (+247/-247)
spec/unit/util/confine_spec.rb (+129/-129)
spec/unit/util/fact_spec.rb (+121/-121)
spec/unit/util/ip_spec.rb (+290/-290)
spec/unit/util/loader_spec.rb (+265/-265)
spec/unit/util/macaddress_spec.rb (+6/-1)
spec/unit/util/macosx_spec.rb (+73/-73)
spec/unit/util/manufacturer_spec.rb (+123/-106)
spec/unit/util/resolution_spec.rb (+291/-291)
spec/unit/util/virtual_spec.rb (+168/-168)
spec/unit/util/vlans_spec.rb (+6/-6)
spec/unit/virtual_spec.rb (+271/-271)
spec/watchr.rb (+1/-1)
| Changed in facter (Ubuntu): | |
| assignee: | nobody → Kees Cook (kees) |
Revision history for this message
| Kees Cook (kees) wrote | #1 |
| Changed in facter (Ubuntu): | |
| status: | New → In Progress |
| Changed in facter (Ubuntu): | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Martin Pitt (pitti) wrote | #2 |
| Changed in facter (Ubuntu): | |
| assignee: | Kees Cook (kees) → nobody |
| status: | Fix Committed → Won't Fix |
| status: | Won't Fix → Fix Released |
Revision history for this message
| Steve Langasek (vorlon) wrote | #3 |
| Changed in ruby-pkg-tools (Ubuntu): | |
| importance: | Undecided → High |
| assignee: | nobody → Chuck Short (zulcss) |
Revision history for this message
| Steve Langasek (vorlon) wrote | #4 |
| Changed in ruby-pkg-tools (Ubuntu Lucid): | |
| status: | New → Incomplete |
| Changed in ruby-pkg-tools (Ubuntu Lucid): | |
| milestone: | none → ubuntu-10.04-beta-2 |
Revision history for this message
| Thierry Carrez (ttx) wrote | #5 |
| Changed in ruby-pkg-tools (Ubuntu Lucid): | |
| status: | Incomplete → Invalid |
To post a comment you must log in.
I don't like the lack of array-based exec (it uses %x{cmd arg arg}, which is `cmd arg arg`, which could lead to shell escapes) but it seems self-contained (i.e. "arg" only ever comes from system output). I think the tool looks very fragile as it depends strongly on the output format of various system tools, so it may become a pain for backporting if that ever happens. Since it's mostly just a puppet dep, I think this will be okay. +1