gpsd_config.h not packaged in libgps-dev / gpsd.h uses undefined macro UNUSED

Bug #396256 reported by Dennis Nienhüser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gpsd (Ubuntu)
Fix Released
Undecided
Bernd Zeimetz

Bug Description

Binary package hint: libgps-dev

In /usr/include/gpsd.h a function

extern gps_mask_t processMKT3301(int c UNUSED, char *field[], struct gps_device_t *session);

is defined. The UNUSED macro is not defined in gpsd.h. It seems to be defined in gpsd_config.h, which isn't packaged or merged into gpsd.h however. See also the bug report at berlios [1] and some possibly related Debian bugs [2] and [3].

My system is Kubuntu 9.04.
$ apt-cache policy libgps-dev
libgps-dev:
  Installed: 2.38-1ubuntu3
  Candidate: 2.38-1ubuntu3
  Version table:
 *** 2.38-1ubuntu3 0
        500 http://de.archive.ubuntu.com jaunty/universe Packages
        100 /var/lib/dpkg/status

[1] http://developer.berlios.de/bugs/?func=detailbug&bug_id=15589&group_id=2116
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=448837
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=447653

Related branches

Revision history for this message
Bernd Zeimetz (bzed) wrote :

Not a bug in the packaging, but in upstream\s code. Working with upstream on a fix right now.

Changed in gpsd (Ubuntu):
status: New → Confirmed
Revision history for this message
Bernd Zeimetz (bzed) wrote :

As workaround add

#if defined(__GNUC__)
# define UNUSED __attribute__((unused)) /* Flag variable as unused */
#else /* not __GNUC__ */
# define UNUSED
#endif

before including gpsd.h

Changed in gpsd (Ubuntu):
assignee: nobody → Bernd Zeimetz (bzed)
Revision history for this message
Bernd Zeimetz (bzed) wrote :

Fixed by upstream in r5718 + r5719

Revision history for this message
Dennis Nienhüser (earthwings) wrote :

Bernd, thanks for tracking it down, appreciated :-)

Revision history for this message
Bernd Zeimetz (bzed) wrote :

Fixed in gpsd >= 2.39-4. Needs to be synced from Debian.

Revision history for this message
Bernd Zeimetz (bzed) wrote :

Depends on #410277

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.5 KiB)

This bug was fixed in the package gpsd - 2.39-5

---------------
gpsd (2.39-5) unstable; urgency=low

  [ Thomas Mueller ]
  * [c884a6d0] Updating debconf translation: de.po (Closes: #538900)

  [ Bernd Zeimetz ]
  * [26d4a13e] gpsd.init: Move bluetooth to Should-Start - thanks to
    Carsten Einig
  * [7113becd] Add missing macro UNUSED to gpsd.h. (LP: #396256) -
    thanks to Dennis Nienhüser

gpsd (2.39-4) unstable; urgency=low

  * [51e8dea3] Updating git-dch settings in git-bp config.
  * [35f17def] Updating debconf translation: cs.po (Closes: #534958) -
    thanks to Miroslav Kure
  * [c1917386] Updating debconf translation: eu.po (Closes: #535038) -
    thanks to Piarres Beobide
  * [4b6719c3] Updating debconf translation: ja.po (Closes: #535067) -
    thanks to Kenshi Muto
  * [b188ed05] Updating debconf translation: fi.po (Closes: #535112) -
    thanks to Esko Arajärvi
  * [ae2b44fe] Updating debconf translation: ro.po (Closes: #535121) -
    thanks to Eddy Petrișor
  * [0d989720] Updating debconf translation: sv.po (Closes: #535149) -
    thanks to Martin Bagge / brother
  * [413b36ab] Updating debconf translation: sk.po (Closes: #535157) -
    thanks to <email address hidden>
  * [ca978d4f] Updating debconf translation: es.po (Closes: #536239) -
    thanks to Francisco Javier Cuadrado
  * [9efd437a] Updating debconf translation: pt.po (Closes: #536276) -
    thanks to "Traduz - Portuguese Translation Team"
  * [6e18a392] Updating debconf translation: ru.po (Closes: #536563) -
    thanks to Yuri Kozlov
  * [2c970b41] Updating debconf translation: it.po (Closes: #536596) -
    thanks to Luca Monducci
  * [d998da9f] Updating debconf translation: gl.po (Closes: #537427) -
    thanks to marce
  * [64375707] Fixing debconf prio for "brokenconfig" state. (Closes:
    #536010) - thanks to Alban Browaeys <email address hidden>
  * [9d7960e6] Updating debconf-updatepo reformatted .po files.

gpsd (2.39-3) experimental; urgency=low

  * [98418e2f] Set priority of all debconf questions to low.
  * [c5d8d1f4] Set control socket option if not in DAEMON_OPTS. (Closes:
    #515085) - thanks to Sascha Silbe
  * [9bed6ecc] Update gpsd.templates to explain options better.
  * [fc356713] Support building for Python2.6.
  * [ee363122] Enable parallel build for python modules.
  * [568c3961] Rise python-all-dev build-dep for --install-layout.
  * [751c5138] Bump python-support build-dep to >= 0.7.1
  * [1545b437] Remove workarounds for broken --disable-python.
  * [59f41451] Using python in build target names.
  * [dcb57ba6] Build gpsd-dbg containing the debug symbols.
  * [52ac81d1] Update templates as suggested during the review. - thanks
    to Justin B Rye
  * [5b099fbe] Updating control file after review. - thanks to Justin B
    Rye
  * [03147ac2] Ensure a valid configuration in debconf. (Closes:
    #515085) - thanks to Sascha Silbe
  * [13db408f] Add error message to gpsd templates.
  * [549e673e] Update error message in template after review.
  * [73b14c74] Adding fuzzy po files after template update.
  * [e1bbde15] Bail out after too many errors during config.
  * [a280e182] Fix description: there is more than NMEA only.
  * [6d9b16f3] Remove extra sp...

Read more...

Changed in gpsd (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.