nm-applet notifications should have more information for disconnected states

i think you want to do two things here:

 1. add device class information to disconnect notifications
 2. notify about special events like "wireless disabled/enabled" or "wireless hardware disabled/enabled"

for 1.:

The notification you see in applet.c that displays a generic icon for disconnect is done when the client state changes to disconnect.

That state refers to the "overall" connectivity state which is why there is no info which type of device you disconnected.

One idea is to track device changes and use the most recently disconnected device to guess the type of notification we want to display.

However, this would make us depend on the order of the notification events, which are on its own not connected - and no guarantees are given about the order (e.g. one time we could get a "wireless device disconnected" event followed by "nm client disconnected", next time it could be in different order).

stacking notifications and modifying them after they appeared might be a solution for that.

... to be continued

i think this is fixed by lpXXX_device_sensitive_disconnect_notify.patch as in 0.7.1~rc3-0ubuntu4 ... i will rename the patch to this bug.

bzr commit -m '* rename patch for disconnect states to match the bug it fixed (LP: #341684)
  - rename patches/lpXXX_device_sensitive_disconnect_notify.patch =>
    lp341684_device_sensitive_disconnect_notify.patch
  - update patche/series' --fixes 'lp:341684'
Committing to: bzr+ssh://bazaar.launchpad.net/~network-manager/network-manager-applet/ubuntu.0.7.1/
modified changelog
renamed patches/lpXXX_device_sensitive_disconnect_notify.patch => patches/lp341684_device_sensitive_disconnect_notify.patch
modified patches/series
Committed revision 31.

This patch does not honor gconf settings:
/apps/nm-applet/disable-connected-notifications
/apps/nm-applet/disable-disconnected-notifications

It should use applet_do_notify_with_pref in combination with PREF_DISABLE_DISCONNECTED_NOTIFICATIONS instead of applet_do_notify.

Example:
applet_do_notify_with_pref (applet, _("Disconnected"),
                              _("The network connection has been disconnected."),
                              "nm-no-connection",
                              PREF_DISABLE_DISCONNECTED_NOTIFICATIONS);

Agreed, this is broken.
If I don't want my bubbles popping, I DON'T WANT THEM POPPING.
https://bugzilla.gnome.org/show_bug.cgi?id=592605#c10

Hi,

In Ubuntu 20.04, this patch relies on msgids which are no longer present in nm-applet:

"Don't show this message again"
"Disconnected - you are now offline"
"Wireless network"
"Ethernet network"
"Modem network"

As a result, the notification you get when disconnecting the network is not localized.