Small libgpod3 -> libgpod4 transition

Tripod FTBFS when building with libgpod4:

/usr/include/kde/kfilemetainfo.h: At global scope:
/usr/include/kde/kfilemetainfo.h:1237: warning: type qualifiers ignored on function return type
/tmp/buildd/tripod-0.7.0/./tripod/src/ipodexportdialog.cpp: In member function 'void IpodExport::UploadDialog::ipodItemSelected(QListViewItem*)':
/tmp/buildd/tripod-0.7.0/./tripod/src/ipodexportdialog.cpp:375: error: 'ITDB_THUMB_PHOTO_SMALL' was not declared in this scope
/tmp/buildd/tripod-0.7.0/./tripod/src/ipodexportdialog.cpp:375: error: 'itdb_artwork_get_thumb_by_type' was not declared in this scope
make[4]: *** [ipodexportdialog.o] Error 1
make[4]: Leaving directory `/tmp/buildd/tripod-0.7.0/obj-i486-linux-gnu/tripod/src'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/buildd/tripod-0.7.0/obj-i486-linux-gnu/tripod'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/tripod-0.7.0/obj-i486-linux-gnu'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/tripod-0.7.0/obj-i486-linux-gnu'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2

As does Lastfm, which also FTBFS.

../build/ui_playcontrols.h:34: error: ISO C++ forbids declaration of 'VolumeSlider' with no type
../build/ui_playcontrols.h:34: error: expected ';' before '*' token
../build/ui_playcontrols.h: In member function 'void Ui_PlayControls::setupUi(QWidget*)':
../build/ui_playcontrols.h:62: error: 'volume' was not declared in this scope
../build/ui_playcontrols.h:62: error: expected type-specifier before 'VolumeSlider'
../build/ui_playcontrols.h:62: error: expected `;' before 'VolumeSlider'
container.cpp: In member function 'void Container::setupConnections()':
container.cpp:432: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp: In member function 'void Container::restoreState()':
container.cpp:484: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp: In destructor 'virtual Container::~Container()':
container.cpp:552: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp: In member function 'void Container::volumeUp()':
container.cpp:1201: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1203: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1204: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1206: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1206: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp: In member function 'void Container::volumeDown()':
container.cpp:1214: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1216: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1217: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1219: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1219: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp: In member function 'void Container::mute()':
container.cpp:1227: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1229: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1230: error: 'class Ui::PlayControls' has no member named 'volume'
container.cpp:1233: error: 'class Ui::PlayControls' has no member named 'volume'
make[2]: *** [../build/last.fm/release/container.o] Error 1
make[2]: Leaving directory `/tmp/buildd/lastfm-1.5.1.31879.dfsg/src'
make[1]: *** [sub-src-make_default-ordered] Error 2
make[1]: Leaving directory `/tmp/buildd/lastfm-1.5.1.31879.dfsg'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2

Steve Stalcup is working on a new Amarok upstream bugfix release. We already have patches for libgpod 0.7 so all that should be needed for the transition is a rebuild, I think. (Which will happen as part of the new upstream release)

This bug was fixed in the package amarok - 2:2.0.2mysql5.1.30-0ubuntu1

---------------
amarok (2:2.0.2mysql5.1.30-0ubuntu1) jaunty; urgency=low

  [ Steve Stalcup ]
  * New upstream release
  * Removed KUBUNTU-DEBIAN-DIFFERENCES
  * Rebuild with new libgpod (LP: #337862)

  [ Harald Sitter ]
  * Use lzma for amarok and mysql tarball to reduce orig tarball size
  * Add lzma as build dependency
  * Change tarball name expressions in rules accordingly

 -- Harald Sitter <email address hidden> Thu, 05 Mar 2009 18:52:07 +0100

This should be fixed for jaunty, libgpod3 is NBS and will go away before release.

Tripod fix - builds in jaunty pbuilder

Can this be done as a standalone patch kept in the debian directory?

The tripod patch is inline as no current patch systems exists in the package.

I can put one in if you would like, but the package should will probably be sync'd from debian next time, and we have no other changes, and they are also going through the same transition.

debdiff with the patch that fixes the FTBFS. I'll send it also to debian.

Tripod also needed the maintainer change, but I added that. Testing now ....

This bug was fixed in the package tripod - 0.7.0-2ubuntu1

---------------
tripod (0.7.0-2ubuntu1) jaunty; urgency=low

  * tripod/src/ipodexportdialog.cpp:
    - Inline patch of ipodexportdialog.cpp to fix FTBFS
      when building against libgpod 0.7. (LP: #337862)

 -- Stefan Lesicnik <email address hidden> Mon, 30 Mar 2009 13:45:05 +0200

This bug was fixed in the package lastfm - 1:1.5.1.31879.dfsg-1ubuntu4

---------------
lastfm (1:1.5.1.31879.dfsg-1ubuntu4) jaunty; urgency=low

  * debian/patches/qt45.diff: fix the volumeslider header name to avoid qt45
    to generate phonon/Phonon::VolumeSlider as header name (LP: #337862)

 -- Fabrice Coutadeur <email address hidden> Wed, 15 Apr 2009 05:32:35 +0000