Ubuntu
gajim package

gajim show popup with html entities escaped too many times

Bug #205973 reported by wodny
8
Affects Status Importance Assigned to Milestone
gajim (Ubuntu)
Fix Released
Low
Unassigned
Hardy
Fix Released
Low
Laurent Bigonville

Bug Description

Binary package hint: gajim

When gajim is unable to connect to one of my accounts it shows a popup informing me about that fact - but, server name is encapsulated in something, that should have been quotes. It shows literally " instead. It suggests escaping html entities too many times.

Gajim 0.11.4 on Ubuntu hardy (development branch) 8.04

ProblemType: Bug
Architecture: i386
Date: Mon Mar 24 13:11:53 2008
DistroRelease: Ubuntu 8.04
Package: gajim 0.11.4-0ubuntu1
PackageArchitecture: i386
ProcEnviron:
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: gajim
Uname: Linux 2.6.24-12-generic i686

Revision history for this message
wodny (wodny) wrote :
Revision history for this message
wodny (wodny) wrote :

OK, I will comment myself :-)

as:
http://www.galago-project.org/specs/notification/0.9/x81.html
says:
"The body may contain simple markup as specified in Markup. It must be encoded using UTF-8."

But there is no annotation about markups in summary field. So my conclusion is that summary and body should be treated differently.
In file:
notify.py line 283-284
both are escaped - inside body, entities like " are understood, while for summary (title) it's not true

So my first and the simplest way of fixing, would be NOT escaping title.

Revision history for this message
wodny (wodny) wrote :

Hmm, gajim developers have already noticed it

http://trac.gajim.org/changeset/9333

Kjell Braden (afflux)
Changed in gajim:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Michael Kaliszka (desmont) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gajim - 0.11.4-0ubuntu2

---------------
gajim (0.11.4-0ubuntu2) intrepid; urgency=low

  * Fix the html entities to be escaped too many times in notification popup
    (taken from upstream) (LP: #205973)

 -- Laurent Bigonville <email address hidden> Sat, 12 Jul 2008 13:39:48 +0200

Changed in gajim:
status: Triaged → Fix Released
Revision history for this message
Laurent Bigonville (bigon) wrote :

It's maybe a good idea to backport this tiny change to hardy

Changed in gajim:
assignee: nobody → bigon
importance: Undecided → Low
Revision history for this message
Luke Yelavich (themuso) wrote : Re: [Bug 205973] [NEW] gajim show popup with html entities escaped too many times

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Laurent, could you please follow the SRu procedure outlined at https://wiki.ubuntu.com/StableReleaseUpdates?At minimum, a debdiff for the change and a test case in the bug description would be nice.

 affects ubuntu/hardy/gajim
 status incomplete
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIe3r6jVefwtBjIM4RAuIgAJ9YI7DDRw4B8+QiWW80pFEBL3kZcACg01em
lGtJ+OG1A/JJqchLSzaHHGk=
=xpYH
-----END PGP SIGNATURE-----

Changed in gajim:
status: New → Incomplete
Revision history for this message
Laurent Bigonville (bigon) wrote :

here a debdiff against hardy

This happening when displaying notification bubble

Revision history for this message
Martin Pitt (pitti) wrote :

needs motu-sru ack

Revision history for this message
Luke Yelavich (themuso) wrote : Re: [Bug 205973] Re: gajim show popup with html entities escaped too many times

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ACK.

 affects ubuntu/hardy/gajim
 status confirmed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIiXTajVefwtBjIM4RAm/vAJ4pchXAeVkAwDn0aeBc1Y3HdANUdgCgiuY5
q8i7+C6Hc90tgqqaG7HIIr4=
=sfrj
-----END PGP SIGNATURE-----

Changed in gajim:
status: Incomplete → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in gajim:
status: Confirmed → Fix Committed
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

I can confirm version in hardy-proposed no longer shows "&quot;" in notification popup.

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in gajim:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.