[MIR] libfile-sharedir-perl (as a libmail-dmarc-perl dependency)
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| libfile-sharedir-perl (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Package: libfile-
[Availability]
The package libfile-
The package libfile-
It currently builds and works for architectures: amd64 (all)
Link to package https:/
[Rationale]
The package libfile-
The package libfile-
our user base, but is important/helpful still because it is required as runtime dependency by libmail-dmarc-perl
( libmail-dmarc-perl is in the MIR process here: https:/
The package libfile-
[Security]
No CVEs/security issues in this software in the past:
- (0) https:/
- (0) https:/
- (0) https:/
No `suid` or `sgid` binaries.
No executables in `/sbin` and `/usr/sbin`.
Package does not install services, timers or recurring jobs.
Package does not open privileged ports (ports < 1024).
Package does not expose any external endpoints.
Package does not contain extensions to security-sensitive software (filters, scanners, plugins, UI skins, ...);
It's a module to locate non-code (only-read) files during run-time: The intent of File::ShareDir is to provide a companion to Class::Inspector and File::HomeDir, modules that take a process that is well-known by advanced Perl developers but gets a little tricky, and make it more available to the larger
Perl community.
[Quality assurance - function/usage]
The package works well right after install
[Quality assurance - maintenance]
The package is maintained well in Debian/Ubuntu and does
not have too many, long-term & critical, open bugs:
- Ubuntu (0) https:/
- Debian (0) https:/
However, in upstream there are not a lot of activity.
- Upstream's bug tracker (6) https:/
+ Upstream's repo last activity: https:/
- last commit: in master, Oct 21, 2020
- Last answered issue: Sep 22, 2020
- Issues without answer: 2
- last fixed/closed issue: Oct 21, 2020
- last merged PR: Jun 24, 2018
The package hasn't important/old open bugs on upstream.
The package does not deal with exotic hardware we cannot support
[Quality assurance - testing]
The package runs a test suite on build time, if it fails
it makes the build fail: https:/
dh_auto_test
make -j4 test TEST_VERBOSE=1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
Skip blib/lib/
Skip blib/lib/
Skip blib/lib/
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils:
The package runs an autopkgtest (via autodep8 using 'Testsuite: autopkgtest-
that runs essentialy the above build-time test suite. It is currently passing on
this list of architectures (amd64, arm64, armhf, ppc64el, riscv64, s390x), except on i386: https:/
The package does have failing autopkgtests tests right now, but since
they always failed they are handled as "ignored failure", this is
because the test depends on pkg-perl-
build for i386 since focal.
[Quality assurance - packaging]
debian/watch is present and works.
debian/control defines a correct Maintainer field : Debian Perl Group <email address hidden> ( https:/
This package does not yield massive lintian Warnings, Errors
- recent build log of the package https:/
- full output from `lintian --pedantic` :
#source
❯ lintian -EvIL +pedantic --show-overrides
W: libfile-
W: libfile-
I: libfile-
I: libfile-
I: libfile-
P: libfile-
#binary
❯ lintian -EvIL +pedantic --show-overrides ../libfile-
X: libfile-
X: libfile-
This package does not rely on obsolete or about to be demoted packages.
This package has no python2 or GTK2 dependencies.
The package will not be installed by default.
Packaging and build is easy, link to debian/rules: https:/
[UI standards]
Application is not end-user facing (does not need translation).
[Dependencies]
There are further dependencies that are not yet in main:
- libclass-
[Standards compliance]
This package correctly follows FHS and Debian Policy (4.5.0)
[Maintenance/Owner]
Owning Team will be Ubuntu Server Team.
Team is not yet, but will subscribe to the package before promotion.
This does not use static builds.
This does not use vendored code.
This package is not rust based.
The package successfully built during the most recent test rebuild : https:/
[Background information]
The Package description explains the package well.
Upstream Name is File-ShareDir .
Link to upstream project https:/
This has been in the archive since at least 2008 (Intrepid, 0.05-1.1).
This existed in main in 2013 (Trusty), but was demoted after that.
It had a bug filed against it in Launchpad, for syncing the Debian package: https:/
It had several bugs filed in Debian https:/
On 2020 the last version of the package was released on upstream, with fixes for previous version released 2 years before that.
Related branches
- Lucas Kanashiro: Approve
- Canonical Server Reporter: Pending requested
-
Diff: 54 lines (+10/-0)1 file modifiedsubscriptions.yaml (+10/-0)
| description: | updated |
| description: | updated |
| Changed in libfile-sharedir-perl (Ubuntu): | |
| assignee: | nobody → Lukas Märdian (slyon) |
| Lukas Märdian (slyon) wrote | #1 |
| Changed in libfile-sharedir-perl (Ubuntu): | |
| status: | New → In Progress |
| assignee: | Lukas Märdian (slyon) → nobody |
| Miriam España Acebal (mirespace) wrote | #2 |
| Christian Ehrhardt (paelzer) wrote | #3 |
| Changed in libfile-sharedir-perl (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Christian Ehrhardt (paelzer) wrote | #4 |
| Changed in libfile-sharedir-perl (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Review for Source Package: libfile-
[Summary]
A relatively small Perl module providing access to read-only data in common file system directories, such as /usr/share for distro data or corresponding Perl module/CPAN directories. There isn't a lot of upstream activity and maintenance is sporadic (but not a lot of activity expected for this kind of module).
MIR team ACK
With some recommended TODOs below
This does not need a security review
List of specific binary packages to be promoted to main:
- libfile-
Specific binary packages built, but NOT to be promoted to main:
- None
Notes:
#0 Upstream activity and package maintenance is sporadic. The owning team might need to help out in urgent situations.
Required TODOs:
#1 libfile-
Recommended TODOs:
#2 The package should get a team bug subscriber before being promoted
#3 Investigate the dh_auto_test (&autopkgtest) non-failures (but error messages). Should those "missing" recommends fail the test and be skipped instead?
- Error: Can't locate List/MoreUtils.pm
- Error: Can't locate Params/Util.pm
[Rationale, Duplication and Ownership]
OK:
- There is no other package in main providing the same functionality.
- A team is committed to own long term maintenance of this package.
=> ubuntu-server
- The rationale given in the report seems valid and useful for Ubuntu
=> runtime dependency of libmail-dmarc-perl
[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems:
- other Dependencies to MIR due to this:
libfile-
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This doe...