Merge ~mirespace/+git/team-subscriptions:mir_libmail-dmarc-perl_lp2023971 into ~canonical-server/+git/team-subscriptions:main

Proposed by Miriam España Acebal
Status: Merged
Merged at revision: b27924f729397206420ddb3877e7a3eb96498bbb
Proposed branch: ~mirespace/+git/team-subscriptions:mir_libmail-dmarc-perl_lp2023971
Merge into: ~canonical-server/+git/team-subscriptions:main
Diff against target: 54 lines (+10/-0)
1 file modified
subscriptions.yaml (+10/-0)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+456236@code.launchpad.net

Description of the change

Hi team,

adding here all the requested packages to subscribe to as part of the libmail-dmarc-perl MIR process (bug 2023971).

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the MP Miriam! Maybe is it a good idea to mention in your git commit message that we are subscribing to all those packages because of spamassassin. In a first glance, one cannot see the relation of those perl libraries with the packages we maintain.

And I went through the bugs and some of them are requiring some action from you, this is just a heads-up, you are likely aware of that.

review: Needs Fixing
Revision history for this message
Miriam España Acebal (mirespace) wrote :

Hi Lucas and thanks for the review :).

I updated the commit message accordingly, thanks for noting that ("Miriam, why are you working with perl modules?").

Yes, I have this:

* libemail-mime-perl: 2030880 -> ACK with 3 requires TODOs, subscribe team plus security review (sc wip)
   - libemail-messageid-perl: 2030956 -> ACK -> subscribe team
   - libemail-mime-contenttype-perl: 2030962 -> ACK
       + libtext-unidecode-perl: 2031109 -> ACK
   - libemail-mime-encodings-perl: 2031487 -> ACK (fix commited) Done.
   - libemail-simple-perl: 2031491 -> ACK, team subscribe plus security review (sc review)

* libfile-sharedir-perl: 2039566 -> ACK, subscribe, 1 recommend
   + libclass-inspector-perl: 2039569 -> ACK

* libnet-idn-encode-perl: 2038929 -> change by libnet-libidn-perl

* libnet-ip-perl: 2039456 -> ACK: The package does not seem to require a security review at the moment, however requesting team should reach an agreement with security team on how this package will be dealt in terms of security.

* libregexp-common-perl: 2039563 -> ACK, subscribe

I started subscribing them all as a first action (because some of them only need that), but I can wait until after I resolve the issues for you to approve this PM. Then, I'll ping you again if you prefer this.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Miriam. I believe there will be no way back from this, so I think we can already subscribe the team to those packages. Let me know if you want this merged now.

review: Approve
Revision history for this message
Miriam España Acebal (mirespace) wrote :

 Hi Lucas. Yes, please, merge it. Thanks!

Revision history for this message
Christian Ehrhardt (paelzer) wrote :

ack and merged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/subscriptions.yaml b/subscriptions.yaml
2index d5ab21c..0f90191 100644
3--- a/subscriptions.yaml
4+++ b/subscriptions.yaml
5@@ -93,25 +93,33 @@ ubuntu-server: !!set
6 ? libapache2-reload-perl
7 ? libbackuppc-xs-perl
8 ? libcacard
9+ ? libclass-inspector-perl
10 ? libconfig-general-perl
11 ? libdbi
12 ? libdbi-drivers
13 ? libdumbnet
14 ? libecap
15+ ? libemail-messageid-perl
16+ ? libemail-mime-perl
17+ ? libemail-mime-contenttype-perl
18 ? libemail-mime-encodings-perl
19+ ? libemail-simple-perl
20 ? libesmtp
21 ? libfcgi
22 ? libfcgi-perl
23+ ? libfile-sharedir-perl
24 ? libhx
25 ? libiscsi
26 ? liblinear
27 ? liblockfile
28+ ? libmail-dmarc-perl
29 ? libmaxminddb
30 ? libmemcached
31 ? libmime-tools-perl
32 ? libmnl
33 ? libmspack
34 ? libnet
35+ ? libnet-ip-perl
36 ? libnetfilter-conntrack
37 ? libnginx-mod-http-geoip2
38 ? libnl3
39@@ -123,6 +131,7 @@ ubuntu-server: !!set
40 ? libpcap
41 ? libqb
42 ? librabbitmq
43+ ? libregexp-common-perl
44 ? librtas
45 ? libsdl1.2
46 ? libsdl2
47@@ -130,6 +139,7 @@ ubuntu-server: !!set
48 ? libslirp
49 ? libsodium
50 ? libstatgrab
51+ ? libtext-unidecode-perl
52 ? libtime-parsedate-perl
53 ? libtirpc
54 ? libtommath

Subscribers

People subscribed via source and target branches