debhelper 13.11.4ubuntu1 broke dh-translations

Bug #2002845 reported by Jeremy Bícha
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
debhelper (Debian)
Fix Released
Unknown
debhelper (Ubuntu)
Fix Released
Critical
Unassigned
gnome-control-center (Ubuntu)
Invalid
Undecided
Unassigned
gnome-text-editor (Ubuntu)
Invalid
Undecided
Unassigned
pkgbinarymangler (Ubuntu)
Fix Released
Undecided
Gunnar Hjalmarsson

Bug Description

Today's debhelper 13.11.4ubuntu1 merge broke dh-translations.

https://launchpad.net/ubuntu/+source/gnome-text-editor/43.2-1ubuntu1

gnome-text-editor build log excerpt
-----------------------------------
dh_translations
Can't exec "meson introspect '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu' --targets |
 jq -r -M '.[].name | select(endswith("-pot")) | sub("-pot"; "")'":
 No such file or directory at /usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 518.
dh_translations: error: exec (for cmd: "meson introspect '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
 --targets | jq -r -M '.[].name | select(endswith(\"-pot\")) |
 sub(\"-pot\"; \"\")'") failed: No such file or directory
dh_translations: error: "meson introspect '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
 --targets | jq -r -M '.[].name | select(endswith(\"-pot\")) |
 sub(\"-pot\"; \"\")'" returned exit code 25

Other Info
----------
Gunnar identified the bad commit as
https://salsa.debian.org/debian/debhelper/-/commit/62a8608

https://launchpad.net/~gunnarhj/+archive/ubuntu/debhelper/+packages
https://pastebin.ubuntu.com/p/P8qM2sHn9C/

Tags: ftbfs lunar
Jeremy Bícha (jbicha)
Changed in gnome-control-center (Ubuntu):
status: New → Triaged
Changed in gnome-text-editor (Ubuntu):
status: New → Triaged
Changed in pkgbinarymangler (Ubuntu):
status: New → Triaged
tags: added: ftbfs
description: updated
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Reversal of a specific debhelper commit fixes it:

https://launchpad.net/~gunnarhj/+archive/ubuntu/debhelper/+packages

This is the applied patch:

https://pastebin.ubuntu.com/p/P8qM2sHn9C/

And the reversed commit was made in response to a wishlist bug so it shouldn't be so important.

https://bugs.debian.org/1016354

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Another and less intrusive idea to solve the problem for now:

I simply picked the qx_cmd() function in Dh_Lib.pm as it looked like before the interruptive commit mentioned above, and pasted it into the dh_translations file (and renamed it to qx_meson_cmd). See attached diff.

Tested successfully with a couple of packages, including gnome-control-center.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I uploaded pkgbinarymangler with that change in dh_translations.

Changed in pkgbinarymangler (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
status: Triaged → Fix Committed
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

The packages mentioned in this bug (gnome-control-center and gnome-text-editor) build fine now, and so does nautilus-share which I had uploaded. I have removed the block-proposed tag.

There is just a tiny problem: While I uploaded pkgbinarymangler, Gianfranco picked the debhelper reverse idea from my PPA and uploaded debhelper almost concurrently. So the issue has been fixed twice. :/

I suppose it's better to keep the pkgbinarymangler change, and drop this extra delta in debhelper compared to Debian. But we can decide that later, since there is no longer any urgency.

Btw, it cannot be ruled out that the debhelper commit became problematic to dh_translations by mistake. But I think it's rather related to the pipes in the failing dh_translations commands.

tags: removed: block-proposed
Changed in debhelper (Ubuntu):
status: Triaged → Fix Committed
Changed in gnome-control-center (Ubuntu):
status: Triaged → Invalid
Changed in gnome-text-editor (Ubuntu):
status: Triaged → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 150

---------------
pkgbinarymangler (150) lunar; urgency=medium

  * dh_translations:
    - After the latest debhelper change, the qx_cmd() function from
      Dh_Lib.pm does not work in the context in which it's used in
      dh_translations. So the previous qx_cmd() function has been
      copied into dh_translations under the name qx_meson_cmd()
      (LP: #2002845).
  * Failing tests disabled in test/run:
    - test_debian_changelog_truncation
    - test_native_changelog_truncation
    - test_ppa_debian_changelog

 -- Gunnar Hjalmarsson <email address hidden> Sat, 14 Jan 2023 10:59:26 +0100

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I deleted my debhelper PPA. The changes are available here:

https://launchpad.net/ubuntu/+source/debhelper/13.11.4ubuntu2

but OTOH they are about to be reverted via debhelper 13.11.4ubuntu3.

Changed in debhelper (Debian):
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package debhelper - 13.11.4ubuntu3

---------------
debhelper (13.11.4ubuntu3) lunar; urgency=medium

  * Revert upload 13.11.4ubuntu2, a patch in pkgbinarymangler/50
    is now uploaded (see LP: #2002845)

 -- Gianfranco Costamagna <email address hidden> Sat, 14 Jan 2023 12:25:36 +0100

Changed in debhelper (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.