Ubuntu
ubuntu-release-upgrader package

DistUpgradeViewNonInteractive is now interactive

Bug #1944475 reported by Brian Murray on 2021-09-21

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
ubuntu-release-upgrader (Ubuntu)	Fix Released	High	Brian Murray	Ubuntu ubuntu-21.10
Hirsute	Fix Released	High	William Wilson
Impish	Fix Released	High	Brian Murray	Ubuntu ubuntu-21.10

Bug Description

[Impact]
  * The non-interactive release upgrades ask a question and wait for
    an interaction from the user. This makes the "NonInteractive"
    process interactive, and therefore breaks automatic upgrades.

[Test Case]
  * On a hirsute VM, make sure all packages are up to date
    by running `sudo apt update && sudo apt upgrade -y`
  * `sudo do-release-upgrade -d --frontend=DistUpgradeViewNonInteractive`
  * Observe that the the upgrader displays the release notes followed
    by a question in the form of "Continue [yN]"
  * Type N and press enter to cancel the upgrade
  * Install ubuntu-release-upgrader from hirsute-proposed
  * `sudo do-release-upgrade -d --frontend=DistUpgradeViewNonInteractive`
  * Observe that the release upgrade completes successfully without
    any interaction from the user.

[Regression Potential]
  * If the check for the specific frontend is not
    properly written it may be possible that
    the other frontends no longer display the release
    notes and ask the user if they want to continue.
  * This can be tested by running "do-release-upgrade"
    with --frontend=DistUpgradeViewGtk3 and
    --frontend=DistUpgradeViewText and verifying that
    the question is asked.

[Original Description]
With the change to show the release notes when using the "Text" view of the release upgrader (LP: #1925529) a yes / no question regarding upgrading is also displayed when using the NonInteractive view. This ends up making the upgrade process interactive and breaks automatic upgrade testing as seen in this log file:

== More Information ==

You can find out more about Ubuntu on the Ubuntu website and Ubuntu
wiki.

http://www.ubuntu.com/
http://wiki.ubuntu.com/

To sign up for Ubuntu development announcements, please
subscribe to Ubuntu's development announcement list at:

http://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-announce

Continue [yN] auto-upgrade [13:48:19]: Rebooting the system.
bash: line 1: 889 Killed /tmp/autopkgtest.u4eodP/build.JbM/real-tree/debian/tests/upgrade 2> >(tee -a /tmp/autopkgtest.u4eodP/upgrade-stderr >&2) > >(tee -a /tmp/autopkgtest.u4eodP/upgrade-stdout)
autopkgtest: DBG: testbed command exited with code 137

See original description

Tags:

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-09-21:

One way to fix it is in DistUpgradeFetcherCore.py by modifying showReleaseNotes with an if statement at the beginning.

if '--frontend=DistUpgradeViewNonInteractive' in self.run_options:
return True

tags:

added: hirsute impish

Revision history for this message

Ubuntu QA Website (ubuntuqa) wrote on 2021-09-21:

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1944475

tags:

added: iso-testing

Brian Murray (brian-murray) on 2021-09-22

tags:	added: rls-ii-incoming
Changed in ubuntu-release-upgrader (Ubuntu):
milestone:	none → ubuntu-21.10

Brian Murray (brian-murray) on 2021-09-22

Changed in ubuntu-release-upgrader (Ubuntu):
assignee:	nobody → Brian Murray (brian-murray)
importance:	Undecided → High
status:	New → In Progress

Matthieu Clemenceau (mclemenceau) on 2021-09-23

tags:

added: fr-1741

Brian Murray (brian-murray) on 2021-09-23

tags:

removed: rls-ii-incoming

William Wilson (jawn-smith) on 2021-09-23

Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
assignee:	nobody → William Wilson (jawn-smith)
status:	New → In Progress

William Wilson (jawn-smith) on 2021-09-23

description:	updated
description:	updated

Revision history for this message

William Wilson (jawn-smith) wrote on 2021-09-23:

Hirsute Patch Edit (743.8 KiB, text/plain)

tags:

added: verification-needed-hirsute

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2021-09-24:

The attachment "Hirsute Patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags:

added: patch

Mathew Hodson (mhodson) on 2021-09-24

Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
importance:	Undecided → High

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-09-24:

This bug was fixed in the package ubuntu-release-upgrader - 1:21.10.8

---------------
ubuntu-release-upgrader (1:21.10.8) impish; urgency=medium

  [ Olivier Tilloy ]
  * DistUpgrade/deb2snap.json: seed the snaps for firefox (which replaces the
    deb package) and gnome-3-38-2004. (LP: #1943840)

  [ Brian Murray ]
  * DistUpgrade/DistUpgradeFetcherCore.py: when running in non-interactive
    mode do not show the release notes. (LP: #1944475)
  * Run pre-build.sh: updating mirrors, demotions, and translations.

-- Brian Murray <email address hidden> Wed, 22 Sep 2021 11:22:12 -0700

Changed in ubuntu-release-upgrader (Ubuntu Impish):
status:	In Progress → Fix Released

Revision history for this message

Bryce Harrington (bryce) wrote on 2021-09-24 (last edit on 2021-09-24):

Thanks, the hirsute changes LGTM, I've sponsored the upload for SRU.

The changes appear to already be uploaded for impish in version 1:21.10.8, and has transitioned into -release so I gather the impish bug task can be marked fixed.

I also verified the test case in the SRU template on a hirsute LXC container, and worked exactly as written. Rest of the SRU text also looks good.

Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
status:	In Progress → Fix Committed

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-09-24: Please test proposed package

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:21.04.17 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags:

added: verification-needed

Mathew Hodson (mhodson) on 2021-09-25

tags:

added: regression-update
removed: verification-needed

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-09-27:

I tested the version of ubuntu-release-upgrader in the -proposed pocket for Hirsute and was able to start a distribution upgrade without interaction. Additionally, I ran 'sudo do-release-upgrade -d --frontend=DistUpgradeViewText' and '--frontend=DistUpgradeViewGtk3' and saw the release notes with the version from -proposed. I'm subsequently setting the bug to verification-done.

tags:

added: verification-done verification-done-hirsute
removed: verification-needed-hirsute

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-09-27:

This bug was fixed in the package ubuntu-release-upgrader - 1:21.04.17

---------------
ubuntu-release-upgrader (1:21.04.17) hirsute; urgency=medium

  * DistUpgrade/DistUpgradeFetcherCore.py: when running in non-interactive
    mode do not show the release notes. (LP: #1944475)
  * Run pre-build.sh: updating mirrors, demotions, and translations.

-- William 'jawn-smith' Wilson <email address hidden> Thu, 23 Sep 2021 13:52:27 -0500

Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
status:	Fix Committed → Fix Released

Revision history for this message

Steve Langasek (vorlon) wrote on 2021-09-27: Update Released

#10

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.