"ReleaseNotesViewer" does not display anything with the text view

Bug #1925529 reported by Brian Murray
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Brian Murray
Groovy
Won't Fix
Undecided
Unassigned
Hirsute
Fix Released
Medium
Brian Murray
Impish
Fix Released
High
Brian Murray

Bug Description

When upgrading with do-release-upgrade the ReleaseAnnouncement, e.g. http://archive.ubuntu.com/ubuntu/dists/hirsute/main/dist-upgrader-all/current/ReleaseAnnouncement, should be displayed. This works with DistUpgradeViewGtk3 but not DistUpgradeViewText.

[Test Case]
1) run 'do-release-upgrade -d -f DistUpgradeViewText' in a terminal on an Ubuntu 21.04 or Ubuntu 20.10 system
2) you will see a sudo password prompt after the release upgrader tarball is downloaded (i.e. after the message "extracting '$nextrelease.tar.gz'")

After installing ubuntu-release-upgrader from -proposed you'll see the text of the ReleaseAnnouncement before the download of the release upgrader tarball and a "Continue [yN]" prompt.

Additional test:
1) run 'do-release-upgrade -d -f DistUpgradeViewGtk3' in a terminal with the -proposed version of ubuntu-release-upgrader
2) confirm that you don't see the ReleaseAnnouncement in the terminal

[Where Problems Could Occur]
This is new code in DistUpgradeFetcherCore.py for the showReleaseNotes() function. This function also exists in DistUpgradeFetcher.py so the additional code should not affect it but as a regression test "do-release-upgrade -d -f DistUpgradeViewGtk3" should also be run in a terminal to ensure that the ReleaseAnnouncement file is not shown in the terminal and in a GUI dialog.

tags: added: rls-ii-incoming
Changed in ubuntu-release-upgrader (Ubuntu):
importance: Undecided → High
status: New → Confirmed
tags: added: fr-1321
tags: removed: rls-ii-incoming
description: updated
Changed in ubuntu-release-upgrader (Ubuntu Impish):
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:21.10.2

---------------
ubuntu-release-upgrader (1:21.10.2) impish; urgency=medium

  * DistUpgradeFetcherCore.py: when upgrading with the text view display the
    release announcement in the terminal. (LP: #1925529)
  * tests/test_dist_upgrade_fetcher_core.py: do not display the release
    announcement during the test.
  * Run pre-build.sh: updating mirrors, demotions, and translations.

 -- Brian Murray <email address hidden> Fri, 21 May 2021 15:43:16 -0700

Changed in ubuntu-release-upgrader (Ubuntu Impish):
status: Confirmed → Fix Released
Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
importance: Undecided → Medium
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:21.04.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-hirsute
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (ubuntu-release-upgrader/1:21.04.12)

All autopkgtests for the newly accepted ubuntu-release-upgrader (1:21.04.12) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:21.04.12 (armhf, s390x, arm64, ppc64el)
update-manager/1:21.04.10 (armhf, s390x, amd64, arm64, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#ubuntu-release-upgrader

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Brian Murray (brian-murray) wrote :

Because Impish doesn't appear in meta-release-development yet I had to get a little creative by editing the URI for the meta-release file e.g.:

 $ head /etc/update-manager/meta-release
# default location for the meta-release file

[METARELEASE]
#URI = https://changelogs.ubuntu.com/meta-release
URI = https://bazaar.launchpad.net/~ubuntu-core-dev/meta-release/ubuntu/download/269/meta-release
URI_LTS = https://changelogs.ubuntu.com/meta-release-lts
URI_UNSTABLE_POSTFIX = -development
URI_PROPOSED_POSTFIX = -proposed

Revision 269 had impish in m-r-d. After doing that I was able to verify that the ReleaseAnnouncement is displayed with the version of ubuntu-release-upgrader from -proposed. See the attached screenshot for evidence!

tags: added: verification-done verification-done-hirsute
removed: verification-needed verification-needed-hirsute
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:21.04.12

---------------
ubuntu-release-upgrader (1:21.04.12) hirsute; urgency=medium

  * DistUpgrade/DevelReleaseAnnouncement: remove warning regarding upgrading
    to hirsute.
  * DistUpgradeQuirks.py: add in a method for reading the system vendor out of
    DMI information which then can be used to block upgrades. (LP: #1929449)
  * DistUpgradeQuirks.py: If the system vendor is Apple do not allow release
    upgrades to 21.04 for the time being. (LP: #1929449)
  * DistUpgradeFetcherCore.py: when upgrading with the text view display the
    release announcement in the terminal. (LP: #1925529)
  * tests/test_dist_upgrade_fetcher_core.py: do not display the release
    announcement during the test.
  * tests/test_sources_list.py: switch from precise to focal and precise was
    removed from the archive.
  * Run pre-build.sh: updating mirrors, demotions, and translations.

 -- Brian Murray <email address hidden> Tue, 11 May 2021 15:03:04 -0700

Changed in ubuntu-release-upgrader (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in ubuntu-release-upgrader (Ubuntu Groovy):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.