Latest fixes for corosync in Groovy

Bug #1895366 reported by Rafael David Tinoco
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
corosync (Ubuntu)
Fix Released
Critical
Unassigned

Bug Description

We've missed corosync 3.0.4 release this cycle, nevertheless I can bring some good fixes for stabilization:

7f64a1dc cmapctl: return error on no result of print prefix
ec889e89 cmapctl: check NULL for key type and value for -p
9105d94a cmapctl: return EXIT_FAILURE on failure
0d0febbc cfgtool: Fix error code as described in MP
8ce65bf9 votequorum: Reflect runtime change of 2Node to WFA
89b0d62f stats: Check return code of stats_map_get
56ee8503 quorumtool: Assert copied string length
1fb095b0 notifyd: Check cmap_track_add result
8ff7760c cmapctl: Free bin_value on error
21e1c711 cfgtool: Remove unused callbacks
ee38d93c cpghum: Remove unused time variables and functions
35c312f8 votequorum: Assert copied strings length
29109683 totemknet: Assert strcpy length
0c118d8f totemknet: Check result of fcntl O_NONBLOCK call
a24cbad5 totemconfig: Initialize warnings variable
74eed54a sync: Assert sync_callbacks.name length
380b744e totemknet: Don't mix corosync and knet error codes
624b6a47 stats: Assert value_len when value is needed
f31a31f9 cmap: Assert copied string length
09f6d34a logconfig: Remove double free of value
cddd62f9 votequorum: Ignore the icmap_get_* return value
efe48120 totemconfig: Free leaks found by coverity

and that shall make our corosync 3.0.3 a good package (without FFe need).

Related branches

Changed in corosync (Ubuntu):
status: New → Confirmed
importance: Undecided → Critical
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I had previously done:

  * debian/corosync-notifyd.init: fix for 2 PIDFILEs declared (LP: #1437359)
  * Post v3.0.3 release fixes backported to Ubuntu (LP: #1869622)
    debian/patches/ubuntu-v3.0.3-fixes/:
    - lp1869622-09f6d34a-logconfig-Remove-double-free-of-value.patch
    - lp1869622-0c118d8f-totemknet-Check-result-of-fcntl-O_NONBLOCK-call.patch
    - lp1869622-0c16442f-votequorum-Change-check-of-expected_votes.patch
    - lp1869622-1fb095b0-notifyd-Check-cmap_track_add-result.patch
    - lp1869622-29109683-totemknet-Assert-strcpy-length.patch
    - lp1869622-35c312f8-votequorum-Assert-copied-strings-length.patch
    - lp1869622-380b744e-totemknet-Don-t-mix-corosync-and-knet-error-codes.patch
    - lp1869622-56ee8503-quorumtool-Assert-copied-string-length.patch
    - lp1869622-5f543465-quorumtool-exit-on-invalid-expected-votes.patch
    - lp1869622-624b6a47-stats-Assert-value_len-when-value-is-needed.patch
    - lp1869622-74eed54a-sync-Assert-sync_callbacks.name-length.patch
    - lp1869622-89b0d62f-stats-Check-return-code-of-stats_map_get.patch
    - lp1869622-8ce65bf9-votequorum-Reflect-runtime-change-of-2Node-to-WFA.patch
    - lp1869622-8ff7760c-cmapctl-Free-bin_value-on-error.patch
    - lp1869622-a24cbad5-totemconfig-Initialize-warnings-variable.patch
    - lp1869622-c631951e-icmap-icmap_init_r-leaks-if-trie_create-fails.patch
    - lp1869622-ca320bea-votequorum-set-wfa-status-only-on-startup.patch
    - lp1869622-efe48120-totemconfig-Free-leaks-found-by-coverity.patch

so we are missing:

7f64a1dc cmapctl: return error on no result of print prefix
ec889e89 cmapctl: check NULL for key type and value for -p
9105d94a cmapctl: return EXIT_FAILURE on failure
0d0febbc cfgtool: Fix error code as described in MP
21e1c711 cfgtool: Remove unused callbacks
ee38d93c cpghum: Remove unused time variables and functions
380b744e totemknet: Don't mix corosync and knet error codes
f31a31f9 cmap: Assert copied string length
09f6d34a logconfig: Remove double free of value
cddd62f9 votequorum: Ignore the icmap_get_* return value

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Final list is:

# v3.0.3 post-release ubuntu fixes (LP: #1895366)
ubuntu-v3.0.3-fixes/lp1895366-7f64a1dc-cmapctl-return-error-on-no-result-of-print-prefix.patch
ubuntu-v3.0.3-fixes/lp1895366-ec889e89-cmapctl-check-NULL-for-key-type-and-value-for-p.patch
ubuntu-v3.0.3-fixes/lp1895366-9105d94a-cmapctl-return-EXIT_FAILURE-on-failure.patch
ubuntu-v3.0.3-fixes/lp1895366-21e1c711-cfgtool-Remove-unused-callbacks.patch
ubuntu-v3.0.3-fixes/lp1895366-ee38d93c-cpghum-Remove-unused-time-variables-and-functions.patch
ubuntu-v3.0.3-fixes/lp1895366-f31a31f9-cmap-Assert-copied-string-length.patch

and

# ubuntu-v3.0.3-fixes/lp1895366-0d0febbc-cfgtool-Fix-error-code-as-described-in-MP.patch

required:

commit 15c25a28
Author: Jan Friesse <email address hidden>
Date: Tue Mar 3 11:07:55 2020

    cfgtool: Simplify output a bit for link status

and I don't think it was worth adding, nor:

ubuntu-v3.0.3-fixes/lp1895366-cddd62f9-votequorum-Ignore-the-icmap_get_-return-value.patch

which didn't apply cleanly seems like a trivial change.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package corosync - 3.0.3-2ubuntu3

---------------
corosync (3.0.3-2ubuntu3) groovy; urgency=medium

  * Post v3.0.3 release fixes backported to Ubuntu (LP: #1895366)
    debian/patches/ubuntu-v3.0.3-fixes/:
    - lp1895366-7f64a1dc-cmapctl-return-error-on-no-result-of-print-prefix.patch
    - lp1895366-ec889e89-cmapctl-check-NULL-for-key-type-and-value-for-p.patch
    - lp1895366-9105d94a-cmapctl-return-EXIT_FAILURE-on-failure.patch
    - lp1895366-21e1c711-cfgtool-Remove-unused-callbacks.patch
    - lp1895366-ee38d93c-cpghum-Remove-unused-time-variables-and-functions.patch
    - lp1895366-f31a31f9-cmap-Assert-copied-string-length.patch

 -- Rafael David Tinoco <email address hidden> Sat, 12 Sep 2020 04:27:43 +0000

Changed in corosync (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.