Latest fixes for corosync in Groovy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
corosync (Ubuntu) |
Fix Released
|
Critical
|
Unassigned |
Bug Description
We've missed corosync 3.0.4 release this cycle, nevertheless I can bring some good fixes for stabilization:
7f64a1dc cmapctl: return error on no result of print prefix
ec889e89 cmapctl: check NULL for key type and value for -p
9105d94a cmapctl: return EXIT_FAILURE on failure
0d0febbc cfgtool: Fix error code as described in MP
8ce65bf9 votequorum: Reflect runtime change of 2Node to WFA
89b0d62f stats: Check return code of stats_map_get
56ee8503 quorumtool: Assert copied string length
1fb095b0 notifyd: Check cmap_track_add result
8ff7760c cmapctl: Free bin_value on error
21e1c711 cfgtool: Remove unused callbacks
ee38d93c cpghum: Remove unused time variables and functions
35c312f8 votequorum: Assert copied strings length
29109683 totemknet: Assert strcpy length
0c118d8f totemknet: Check result of fcntl O_NONBLOCK call
a24cbad5 totemconfig: Initialize warnings variable
74eed54a sync: Assert sync_callbacks.name length
380b744e totemknet: Don't mix corosync and knet error codes
624b6a47 stats: Assert value_len when value is needed
f31a31f9 cmap: Assert copied string length
09f6d34a logconfig: Remove double free of value
cddd62f9 votequorum: Ignore the icmap_get_* return value
efe48120 totemconfig: Free leaks found by coverity
and that shall make our corosync 3.0.3 a good package (without FFe need).
Related branches
- Rafael David Tinoco (community): Approve
- Christian Ehrhardt (community): Needs Fixing
- Canonical Server: Pending requested
- Canonical Server Core Reviewers: Pending requested
-
Diff: 357 lines (+305/-0)8 files modifieddebian/changelog (+13/-0)
debian/patches/series (+7/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1895366-21e1c711-cfgtool-Remove-unused-callbacks.patch (+37/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1895366-7f64a1dc-cmapctl-return-error-on-no-result-of-print-prefix.patch (+81/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1895366-9105d94a-cmapctl-return-EXIT_FAILURE-on-failure.patch (+42/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1895366-ec889e89-cmapctl-check-NULL-for-key-type-and-value-for-p.patch (+36/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1895366-ee38d93c-cpghum-Remove-unused-time-variables-and-functions.patch (+39/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1895366-f31a31f9-cmap-Assert-copied-string-length.patch (+50/-0)
Changed in corosync (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → Critical |
I had previously done:
* debian/ corosync- notifyd. init: fix for 2 PIDFILEs declared (LP: #1437359) patches/ ubuntu- v3.0.3- fixes/: 09f6d34a- logconfig- Remove- double- free-of- value.patch 0c118d8f- totemknet- Check-result- of-fcntl- O_NONBLOCK- call.patch 0c16442f- votequorum- Change- check-of- expected_ votes.patch 1fb095b0- notifyd- Check-cmap_ track_add- result. patch 29109683- totemknet- Assert- strcpy- length. patch 35c312f8- votequorum- Assert- copied- strings- length. patch 380b744e- totemknet- Don-t-mix- corosync- and-knet- error-codes. patch 56ee8503- quorumtool- Assert- copied- string- length. patch 5f543465- quorumtool- exit-on- invalid- expected- votes.patch 624b6a47- stats-Assert- value_len- when-value- is-needed. patch 74eed54a- sync-Assert- sync_callbacks. name-length. patch 89b0d62f- stats-Check- return- code-of- stats_map_ get.patch 8ce65bf9- votequorum- Reflect- runtime- change- of-2Node- to-WFA. patch 8ff7760c- cmapctl- Free-bin_ value-on- error.patch a24cbad5- totemconfig- Initialize- warnings- variable. patch c631951e- icmap-icmap_ init_r- leaks-if- trie_create- fails.patch ca320bea- votequorum- set-wfa- status- only-on- startup. patch efe48120- totemconfig- Free-leaks- found-by- coverity. patch
* Post v3.0.3 release fixes backported to Ubuntu (LP: #1869622)
debian/
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
- lp1869622-
so we are missing:
7f64a1dc cmapctl: return error on no result of print prefix
ec889e89 cmapctl: check NULL for key type and value for -p
9105d94a cmapctl: return EXIT_FAILURE on failure
0d0febbc cfgtool: Fix error code as described in MP
21e1c711 cfgtool: Remove unused callbacks
ee38d93c cpghum: Remove unused time variables and functions
380b744e totemknet: Don't mix corosync and knet error codes
f31a31f9 cmap: Assert copied string length
09f6d34a logconfig: Remove double free of value
cddd62f9 votequorum: Ignore the icmap_get_* return value