Ubuntu
corosync package

[focal] corosync v3.0.3 last upstream fixes

Bug #1869622 reported by Rafael David Tinoco
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
corosync (Ubuntu)
Fix Released
High
Rafael David Tinoco

Bug Description

Together with fixes for:

https://bugs.launchpad.net/ubuntu/+source/corosync/+bug/1437359
https://bugs.launchpad.net/ubuntu/+source/corosync/+bug/1677684

This bug will also backport/cherrypick the following post release fixes:

-> c631951e icmap: icmap_init_r() leaks if trie_create() fails = fix
-> ca320bea votequorum: set wfa status only on startup = fix
-> 5f543465 quorumtool: exit on invalid expected votes = fix
-> 0c16442f votequorum: Change check of expected_votes = fix
-> 8ce65bf9 votequorum: Reflect runtime change of 2Node to WFA = fix
-> 89b0d62f stats: Check return code of stats_map_get = fix
-> 56ee8503 quorumtool: Assert copied string length = assert
-> 1fb095b0 notifyd: Check cmap_track_add result = assert
-> 8ff7760c cmapctl: Free bin_value on error = fix
-> 35c312f8 votequorum: Assert copied strings length = assert
-> 29109683 totemknet: Assert strcpy length assert = assert
-> 0c118d8f totemknet: Check result of fcntl O_NONBLOCK call = assert
-> a24cbad5 totemconfig: Initialize warnings variable = build fix
-> 74eed54a sync: Assert sync_callbacks.name length = assert
-> 380b744e totemknet: Don't mix corosync and knet error codes = fix
-> 624b6a47 stats: Assert value_len when value is needed = assert
-> 09f6d34a logconfig: Remove double free of value = fix
-> efe48120 totemconfig: Free leaks found by coverity = fix

See original description

Related branches

~rafaeldtinoco/ubuntu/+source/corosync:lp1869622-focal
Christian Ehrhardt  (community): Approve
Canonical Server Core Reviewers: Pending requested
Canonical Server: Pending requested
Diff: 971 lines (+823/-2)
22 files modified
debian/changelog (+30/-0)
debian/control (+3/-1)
debian/corosync-notifyd.init (+0/-1)
debian/patches/series (+19/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-09f6d34a-logconfig-Remove-double-free-of-value.patch (+25/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-0c118d8f-totemknet-Check-result-of-fcntl-O_NONBLOCK-call.patch (+32/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-0c16442f-votequorum-Change-check-of-expected_votes.patch (+51/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-1fb095b0-notifyd-Check-cmap_track_add-result.patch (+50/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-29109683-totemknet-Assert-strcpy-length.patch (+44/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-35c312f8-votequorum-Assert-copied-strings-length.patch (+38/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-380b744e-totemknet-Don-t-mix-corosync-and-knet-error-codes.patch (+52/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-56ee8503-quorumtool-Assert-copied-string-length.patch (+25/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-5f543465-quorumtool-exit-on-invalid-expected-votes.patch (+33/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-624b6a47-stats-Assert-value_len-when-value-is-needed.patch (+26/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-74eed54a-sync-Assert-sync_callbacks.name-length.patch (+27/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-89b0d62f-stats-Check-return-code-of-stats_map_get.patch (+26/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-8ce65bf9-votequorum-Reflect-runtime-change-of-2Node-to-WFA.patch (+80/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-8ff7760c-cmapctl-Free-bin_value-on-error.patch (+30/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-a24cbad5-totemconfig-Initialize-warnings-variable.patch (+26/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-c631951e-icmap-icmap_init_r-leaks-if-trie_create-fails.patch (+32/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-ca320bea-votequorum-set-wfa-status-only-on-startup.patch (+67/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-efe48120-totemconfig-Free-leaks-found-by-coverity.patch (+107/-0)
Rafael David Tinoco (rafaeldtinoco)
Changed in corosync (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Rafael David Tinoco (rafaeldtinoco)
Rafael David Tinoco (rafaeldtinoco)
description: updated
Rafael David Tinoco (rafaeldtinoco)
description: updated
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

For the 2 fixes:

LP: #1437359
LP: #1677684

I have submitted to upstream the following merge request:

https://salsa.debian.org/ha-team/corosync/-/merge_requests/2

Rafael David Tinoco (rafaeldtinoco)
Changed in corosync (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package corosync - 3.0.3-2ubuntu2

---------------
corosync (3.0.3-2ubuntu2) focal; urgency=medium

  [Jorge Niedbalski]
  * d/control: corosync binary depends on libqb-dev (LP: #1677684)

  [Rafael David Tinoco]
  * debian/corosync-notifyd.init: fix for 2 PIDFILEs declared (LP: #1437359)
  * Post v3.0.3 release fixes backported to Ubuntu (LP: #1869622)
    debian/patches/ubuntu-v3.0.3-fixes/:
    - lp1869622-09f6d34a-logconfig-Remove-double-free-of-value.patch
    - lp1869622-0c118d8f-totemknet-Check-result-of-fcntl-O_NONBLOCK-call.patch
    - lp1869622-0c16442f-votequorum-Change-check-of-expected_votes.patch
    - lp1869622-1fb095b0-notifyd-Check-cmap_track_add-result.patch
    - lp1869622-29109683-totemknet-Assert-strcpy-length.patch
    - lp1869622-35c312f8-votequorum-Assert-copied-strings-length.patch
    - lp1869622-380b744e-totemknet-Don-t-mix-corosync-and-knet-error-codes.patch
    - lp1869622-56ee8503-quorumtool-Assert-copied-string-length.patch
    - lp1869622-5f543465-quorumtool-exit-on-invalid-expected-votes.patch
    - lp1869622-624b6a47-stats-Assert-value_len-when-value-is-needed.patch
    - lp1869622-74eed54a-sync-Assert-sync_callbacks.name-length.patch
    - lp1869622-89b0d62f-stats-Check-return-code-of-stats_map_get.patch
    - lp1869622-8ce65bf9-votequorum-Reflect-runtime-change-of-2Node-to-WFA.patch
    - lp1869622-8ff7760c-cmapctl-Free-bin_value-on-error.patch
    - lp1869622-a24cbad5-totemconfig-Initialize-warnings-variable.patch
    - lp1869622-c631951e-icmap-icmap_init_r-leaks-if-trie_create-fails.patch
    - lp1869622-ca320bea-votequorum-set-wfa-status-only-on-startup.patch
    - lp1869622-efe48120-totemconfig-Free-leaks-found-by-coverity.patch

 -- Rafael David Tinoco <email address hidden> Sun, 29 Mar 2020 21:50:35 +0000

Changed in corosync (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.