Installation in OEM mode broken on bionic

Bug #1789920 reported by Dariusz Gadomski
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Undecided
Michael Hudson-Doyle
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[impact]
Users booting a device for customization in OEM mode have to switch to another vt to log in (and it's not very obvious at all that you can do this)

[test case]
I took the following steps:
1. Booted from the ISO (using BIOS, haven't tested EFI).
2. F4 -> set the OEM mode.
3. Proceed through the initial setup.
4. Agree to reboot for the OEM setup.
5. Observe systemd boot messages.

Expected result:
User is offered a login prompt to login as oem user on tty1.

Actual result:
Boot is stuck without any error/explanation.

[regression potential]
The patch is very small, only affects OEM mode, and even if the new commands fail would have little chance for regression beyond not fixing this bug.

Related branches

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

As advised by xnox I have retried the installation with adding apt-setup/proposed=true.

The result was identical - after rebooting to perform the oem configuration the boot process stucks.

Attaching installer logs.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :
tags: added: id-5b983173152c177344571ee6
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

So this is strange, I can reproduce the bug, but an oem install in UEFI mode works, and a normal install in BIOS mode works, only an oem install in BIOS mode doesn't work. Which doesn't make any sense at all on the face of it.

Changed in ubiquity (Ubuntu):
assignee: nobody → Michael Hudson-Doyle (mwhudson)
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oh wait no it does boot, it just takes a very very long time. Dariusz, how long did you wait for it to boot?

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Michael, I've just tried again today. I have up waiting after 60 minutes. How long does it take in your case?

FWIW I used a vm (kvm) for testing.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oh, I misread the bug report, I thought that the system wasn't booting at all :(

The good news is that I can reproduce your issue now I understand what it actually is! The bad news is that I don't really know what to do about it. <email address hidden> is being prevented from running by ubiquity.service via systemd's Conflicts= mechanism. I don't really know why though, perhaps it can simply be removed -- I also don't understand terribly well how all of this stuff is supposed to work.

There is an easy workaround though, just switch to tty2 after booting.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

So I think this patch (to ubiquity):

(master)mwhudson@ringil:/opt/opensource/ubiquity$ git diff
diff --git a/finish-install.d/01oem-config-udeb b/finish-install.d/01oem-config-udeb
index afb94f4b3..16940ff2b 100755
--- a/finish-install.d/01oem-config-udeb
+++ b/finish-install.d/01oem-config-udeb
@@ -28,3 +28,6 @@ chroot /target debconf-set-selections <<EOF || true
 oem-config debian-installer/locale select $LOCALE
 oem-config debian-installer/framebuffer boolean $FRAMEBUFFER
 EOF
+# Disable ubiquity.service in the installed system as it conflicts with
+# <email address hidden> which we want to run.
+chroot /target systemctl mask ubiquity.service

will fix the issue, it's a bit gross though.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 18.10.10

---------------
ubiquity (18.10.10) cosmic; urgency=medium

  [ Michael Hudson-Doyle ]
  * Mask ubiquity.service in a system installed with oem-config/enabled=true,
    as this prevents <email address hidden> from running. (LP: #1789920)

  [ Łukasz 'sil2100' Zemczak ]
  * Update translations from Launchpad.
  * Automatic update of included source packages: partman-partitioning
    120ubuntu2, shim-signed 1.38.

  [ Iain Lane ]
  * gtk, kde: Start installing after ubi-timezone. (LP: #1797579)

 -- Łukasz 'sil2100' Zemczak <email address hidden> Mon, 15 Oct 2018 14:28:09 +0100

Changed in ubiquity (Ubuntu):
status: New → Fix Released
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted ubiquity into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/18.04.14.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubiquity (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Robie Basak (racb) wrote :

"If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic."

What was the result of your testing please, how did you test it, and what was the version that you tested?

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I verified the fix using the ISO with .disk/info "Ubuntu-Server 18.04.1 LTS "Bionic Beaver" - Release amd64 (20181030)".

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

(forgot to hit the "post comment" button)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 18.04.14.9

---------------
ubiquity (18.04.14.9) bionic; urgency=medium

  * Mask ubiquity.service in a system installed with oem-config/enabled=true,
    as this prevents <email address hidden> from running. (LP: #1789920)

 -- Michael Hudson-Doyle <email address hidden> Mon, 01 Oct 2018 12:38:20 +1300

Changed in ubiquity (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for ubiquity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.