Merge ~mwhudson/ubiquity:lp-1789920 into ubiquity:master

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 747818ebb4e8ad93eda56d00b4fad0cfc857b503
Proposed branch: ~mwhudson/ubiquity:lp-1789920
Merge into: ubiquity:master
Diff against target: 43 lines (+15/-1)
3 files modified
bin/oem-config-remove (+5/-1)
debian/changelog (+7/-0)
finish-install.d/01oem-config-udeb (+3/-0)
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+355896@code.launchpad.net

Description of the change

I'm fairly sure this will fix the bug, not sure how to test though. It's also pretty horrible.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I've pushed an update to remove the masking symlink.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/oem-config-remove b/bin/oem-config-remove
2index 6fe9729..88f1caf 100755
3--- a/bin/oem-config-remove
4+++ b/bin/oem-config-remove
5@@ -27,7 +27,11 @@ case $1 in
6 apt-get -y purge 'oem-config-slideshow-*' || true
7
8 debconf-apt-progress --stop
9- ;;
10+ # finish-install.d/01oem-config-udeb masks
11+ # ubiquity.service so that getty@tty1.service runs as
12+ # normal. Remove the clutter from that now.
13+ rm -f /etc/systemd/system/ubiquity.service
14+ ;;
15 esac
16
17 exit 0
18diff --git a/debian/changelog b/debian/changelog
19index bff1ce2..3291d72 100644
20--- a/debian/changelog
21+++ b/debian/changelog
22@@ -1,3 +1,10 @@
23+ubiquity (18.10.10) UNRELEASED; urgency=medium
24+
25+ * Mask ubiquity.service in a system installed with oem-config/enabled=true,
26+ as this prevents getty@tty1.service from running. (LP: #1789920)
27+
28+ -- Michael Hudson-Doyle <michael.hudson@ubuntu.com> Mon, 01 Oct 2018 12:38:20 +1300
29+
30 ubiquity (18.10.9) cosmic; urgency=medium
31
32 * Fix ubiquity's use of regexes with escaped characters to satisfy new
33diff --git a/finish-install.d/01oem-config-udeb b/finish-install.d/01oem-config-udeb
34index afb94f4..16940ff 100755
35--- a/finish-install.d/01oem-config-udeb
36+++ b/finish-install.d/01oem-config-udeb
37@@ -28,3 +28,6 @@ chroot /target debconf-set-selections <<EOF || true
38 oem-config debian-installer/locale select $LOCALE
39 oem-config debian-installer/framebuffer boolean $FRAMEBUFFER
40 EOF
41+# Disable ubiquity.service in the installed system as it conflicts with
42+# getty@tty1.service which we want to run.
43+chroot /target systemctl mask ubiquity.service

Subscribers

People subscribed via source and target branches