subiquity

failed creating LVM on top of md devices

Bug #1783413 reported by Joshua Powers
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
curtin
Fix Released
Medium
Unassigned
subiquity
Fix Released
Undecided
Unassigned

Bug Description

Summary:
Tried creating a LVM group on top of two software raid devices and the install failed

Expected Behavior:
Install works and reboots into a system with a /home mounted on LVM + RAID

Actual Behavior:

Running command ['vgcreate', '--force', '--zero=y', '--yes', 'vg0', '/dev/md0', '/dev/md1'] with allowed return codes [0] (capture=True)
        An error occured handling 'vg-0': ProcessExecutionError - Unexpected error while running command.
        Command: ['vgcreate', '--force', '--zero=y', '--yes', 'vg0', '/dev/md0', '/dev/md1']
        Exit code: 5
        Reason: -
        Stdout: ''
        Stderr: WARNING: Device for PV Ku4Qjy-hGry-zaUE-el9b-Vee1-c0eB-43PGwR not found or rejected by a filter.
                  WARNING: Device for PV Ku4Qjy-hGry-zaUE-el9b-Vee1-c0eB-43PGwR not found or rejected by a filter.
                  A volume group called vg0 already exists.

Steps to reproduce:
1. Get Bionic live-server ISO from July 24, 2018 (20180724)
2. Launch a VM with 1x QEMU disk (for root) and 5x libvirt disks for raid
3. Accept defaults till disk and then go manual
4. Setup qemu disk with ext4 mounted at /
5. Setup 2x md devices: 2 disks each, mirrored
6. Setup LVM using the 2x md devices
7. Create volume group on the LVM device with ext4 mounted at /home
8. Install fails

Logs:
curtin: http://paste.ubuntu.com/p/w7g3Whp9ZC/
subiquity-curtin-install.conf: http://paste.ubuntu.com/p/Bp7v8FVJp3/
subiquity-debug.log: http://paste.ubuntu.com/p/fRF9392Yc8/

Related branches

~chad.smith/curtin:ubuntu/devel
Server Team CI bot: Approve (continuous-integration)
curtin developers: Pending requested
Diff: 40 lines (+9/-3)
2 files modified
debian/changelog (+3/-2)
tests/unittests/test_block_zfs.py (+6/-1)
~chad.smith/curtin:ubuntu/devel
Scott Moser (community): Approve
Server Team CI bot: Approve (continuous-integration)
Diff: 1195 lines (+626/-86)
23 files modified
curtin/block/__init__.py (+14/-0)
curtin/block/clear_holders.py (+11/-9)
curtin/block/lvm.py (+23/-5)
curtin/block/mdadm.py (+2/-3)
curtin/block/zfs.py (+18/-7)
curtin/commands/block_meta.py (+5/-3)
curtin/commands/install.py (+2/-1)
curtin/log.py (+43/-0)
curtin/udev.py (+2/-0)
curtin/util.py (+33/-8)
debian/changelog (+11/-0)
examples/tests/dirty_disks_config.yaml (+30/-3)
examples/tests/lvmoverraid.yaml (+98/-0)
examples/tests/vmtest_defaults.yaml (+14/-0)
tests/unittests/test_block.py (+35/-0)
tests/unittests/test_block_lvm.py (+13/-13)
tests/unittests/test_block_mdadm.py (+4/-5)
tests/unittests/test_block_zfs.py (+80/-24)
tests/unittests/test_clear_holders.py (+60/-3)
tests/unittests/test_util.py (+62/-0)
tests/vmtests/__init__.py (+15/-1)
tests/vmtests/test_lvm_raid.py (+50/-0)
tests/vmtests/test_lvm_root.py (+1/-1)
~smoser/curtin:ubuntu/devel
Rejected for merging into curtin:ubuntu/devel
Chad Smith: Disapprove
Server Team CI bot: Approve (continuous-integration)
Diff: 772 lines (+412/-43)
19 files modified
curtin/block/clear_holders.py (+3/-0)
curtin/block/lvm.py (+23/-5)
curtin/block/mdadm.py (+2/-3)
curtin/commands/block_meta.py (+2/-1)
curtin/commands/install.py (+2/-1)
curtin/log.py (+43/-0)
curtin/udev.py (+2/-0)
curtin/util.py (+33/-8)
debian/changelog (+10/-0)
examples/tests/dirty_disks_config.yaml (+30/-3)
examples/tests/lvmoverraid.yaml (+98/-0)
examples/tests/vmtest_defaults.yaml (+14/-0)
tests/unittests/test_block_lvm.py (+13/-13)
tests/unittests/test_block_mdadm.py (+4/-5)
tests/unittests/test_clear_holders.py (+5/-2)
tests/unittests/test_util.py (+62/-0)
tests/vmtests/__init__.py (+15/-1)
tests/vmtests/test_lvm_raid.py (+50/-0)
tests/vmtests/test_lvm_root.py (+1/-1)
~raharper/curtin:fix/lvm-over-raid
Server Team CI bot: Approve (continuous-integration)
Scott Moser (community): Approve
Diff: 353 lines (+223/-24)
8 files modified
curtin/block/clear_holders.py (+3/-0)
curtin/block/lvm.py (+23/-5)
examples/tests/dirty_disks_config.yaml (+30/-3)
examples/tests/lvmoverraid.yaml (+98/-0)
tests/unittests/test_block_lvm.py (+13/-13)
tests/unittests/test_clear_holders.py (+5/-2)
tests/vmtests/test_lvm_raid.py (+50/-0)
tests/vmtests/test_lvm_root.py (+1/-1)
Revision history for this message
Ryan Harper (raharper) wrote :

A volume group called vg0 already exists.

Hrm, looking at the curtin log, it didn't detect a vg0 volume group.

Current device storage tree:
sda
|-- sda2
 `-- sda1
vdb
`-- md127
vda
`-- md127
vdc
`-- md127
vdd
`-- md127
Shutdown Plan:
{'level': 1, 'device': '/sys/class/block/sda/sda2', 'dev_type': 'partition'}
{'level': 1, 'device': '/sys/class/block/sda/sda1', 'dev_type': 'partition'}
{'level': 1, 'device': '/sys/class/block/md127', 'dev_type': 'raid'}
{'level': 0, 'device': '/sys/class/block/sda', 'dev_type': 'disk'}
{'level': 0, 'device': '/sys/class/block/vdb', 'dev_type': 'disk'}
{'level': 0, 'device': '/sys/class/block/vda', 'dev_type': 'disk'}
{'level': 0, 'device': '/sys/class/block/vdc', 'dev_type': 'disk'}
{'level': 0, 'device': '/sys/class/block/vdd', 'dev_type': 'disk'}

We wipe the contents of the assembled raid device, so if that previously held lvm info; that'll get wiped. We run a lvm scan to see if any devices are present but none showed.

If you still have access to system, can you run a few commands:

pvs -a, vgs -a, lvs -a
dmsetup ls
dmsetup status

Revision history for this message
Joshua Powers (powersj) wrote :

sudo pvs -a: http://paste.ubuntu.com/p/58hfG8cDs2/
sudo vgs -a: http://paste.ubuntu.com/p/9bbrJrM9Sf/
sudo lvs -a: empty
sudo dmsetup ls: No devices found
sudo dmsetup status: No devices found

Revision history for this message
Ryan Harper (raharper) wrote :

OK, I've taken this configuration and recreated the issue with our vmtest; we create the storage config, then tear down the lvm and raid (removing configurations from /etc/lvm and /etc/mdadm) then run the storage config a second time. We see the same storage tree (missing the lvm dm0 entries) and then trigger the vgcreate error where vg0 already exists).

The fix is for curtin to add an lvm scan of block devices after assembling raid arrays; This scan will enable any lvm vgs that can be assembled. Then once curtin can "see" the lvm devices, it will properly remove them.

Changed in curtin:
status: New → Confirmed
Ryan Harper (raharper)
Changed in curtin:
status: Confirmed → In Progress
Scott Moser (smoser)
Changed in curtin:
importance: Undecided → Medium
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

This bug is fixed with commit 6a776e15 to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=6a776e15

Changed in curtin:
status: In Progress → Fix Committed
Revision history for this message
Ryan Harper (raharper) wrote : Fixed in curtin version 18.2.

This bug is believed to be fixed in curtin in version 18.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in curtin:
status: Fix Committed → Fix Released
Michael Hudson-Doyle (mwhudson)
Changed in subiquity:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.