DataSourceSmartOS ignores sdc:hostname
Bug #1765085 reported by
Mike Gerdts
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| cloud-init |
Fix Released
|
Medium
|
Mike Gerdts | ||
| cloud-init (Ubuntu) |
Fix Released
|
Undecided
|
Chad Smith | ||
Bug Description
In SmartOS, vmadm(1M) documents the hostname property as the way to set the VM's hostname. This property is available in the guest via the sdc:hostname metadata property. DataSourceSmartOS does not use this value. It currently sets the hostname from the following properties, the first one wins.
1. hostname
2. sdc:uuid
The order should be:
1. hostname
2. sdc:hostname
3. sdc:uuid
This allows a value that is set with 'mdata-put hostname newname' to take precedence over the hostname defined at deployment time.
Related branches
~raharper/cloud-init:ubuntu/devel/newupstream-20180426
- Server Team CI bot: Approve (continuous-integration)
- cloud-init Commiters: Pending requested
-
Diff: 2991 lines (+1186/-256)75 files modified.pylintrc (+1/-1)
cloudinit/analyze/dump.py (+1/-1)
cloudinit/cmd/tests/test_main.py (+3/-3)
cloudinit/config/cc_apt_configure.py (+1/-1)
cloudinit/config/cc_bootcmd.py (+0/-1)
cloudinit/config/cc_disk_setup.py (+4/-8)
cloudinit/config/cc_emit_upstart.py (+1/-1)
cloudinit/config/cc_resizefs.py (+3/-5)
cloudinit/config/cc_rh_subscription.py (+8/-10)
cloudinit/config/cc_runcmd.py (+0/-1)
cloudinit/config/cc_set_passwords.py (+45/-60)
cloudinit/config/cc_snap.py (+2/-3)
cloudinit/config/cc_snappy.py (+2/-2)
cloudinit/config/cc_ubuntu_advantage.py (+2/-3)
cloudinit/config/schema.py (+2/-2)
cloudinit/config/tests/test_set_passwords.py (+71/-0)
cloudinit/config/tests/test_snap.py (+27/-2)
cloudinit/config/tests/test_ubuntu_advantage.py (+28/-2)
cloudinit/distros/freebsd.py (+1/-1)
cloudinit/distros/ubuntu.py (+1/-1)
cloudinit/net/__init__.py (+27/-1)
cloudinit/net/cmdline.py (+1/-1)
cloudinit/net/dhcp.py (+1/-1)
cloudinit/net/sysconfig.py (+1/-2)
cloudinit/net/tests/test_init.py (+1/-0)
cloudinit/reporting/events.py (+1/-1)
cloudinit/sources/DataSourceAliYun.py (+1/-1)
cloudinit/sources/DataSourceAltCloud.py (+1/-4)
cloudinit/sources/DataSourceAzure.py (+13/-20)
cloudinit/sources/DataSourceIBMCloud.py (+92/-14)
cloudinit/sources/DataSourceMAAS.py (+1/-1)
cloudinit/sources/DataSourceOVF.py (+1/-1)
cloudinit/sources/DataSourceOpenStack.py (+2/-2)
cloudinit/sources/DataSourceSmartOS.py (+13/-5)
cloudinit/sources/helpers/digitalocean.py (+3/-4)
cloudinit/sources/helpers/openstack.py (+1/-1)
cloudinit/sources/helpers/vmware/imc/config_nic.py (+1/-1)
cloudinit/sources/helpers/vmware/imc/config_passwd.py (+2/-2)
cloudinit/sources/helpers/vmware/imc/guestcust_util.py (+2/-2)
cloudinit/sources/tests/test_init.py (+1/-1)
cloudinit/ssh_util.py (+63/-7)
cloudinit/templater.py (+1/-1)
cloudinit/tests/helpers.py (+32/-2)
cloudinit/tests/test_util.py (+50/-1)
cloudinit/url_helper.py (+1/-1)
cloudinit/util.py (+16/-1)
debian/changelog (+25/-0)
doc/rtd/topics/datasources.rst (+1/-0)
doc/rtd/topics/datasources/aliyun.rst (+74/-0)
packages/debian/control.in (+1/-0)
tests/cloud_tests/bddeb.py (+1/-1)
tests/cloud_tests/collect.py (+2/-1)
tests/cloud_tests/platforms/instances.py (+1/-1)
tests/cloud_tests/platforms/lxd/instance.py (+4/-6)
tests/cloud_tests/setup_image.py (+5/-6)
tests/cloud_tests/testcases/base.py (+1/-1)
tests/cloud_tests/testcases/examples/including_user_groups.py (+1/-1)
tests/cloud_tests/testcases/modules/user_groups.py (+1/-1)
tests/cloud_tests/util.py (+1/-1)
tests/unittests/test__init__.py (+1/-1)
tests/unittests/test_datasource/test_azure.py (+2/-2)
tests/unittests/test_datasource/test_ibmcloud.py (+50/-0)
tests/unittests/test_datasource/test_maas.py (+2/-2)
tests/unittests/test_datasource/test_nocloud.py (+0/-3)
tests/unittests/test_datasource/test_smartos.py (+117/-4)
tests/unittests/test_ds_identify.py (+64/-8)
tests/unittests/test_handler/test_handler_apt_source_v3.py (+1/-1)
tests/unittests/test_handler/test_handler_bootcmd.py (+26/-8)
tests/unittests/test_handler/test_handler_ntp.py (+1/-1)
tests/unittests/test_handler/test_handler_runcmd.py (+26/-7)
tests/unittests/test_net.py (+127/-5)
tests/unittests/test_sshutil.py (+94/-3)
tests/unittests/test_templating.py (+2/-2)
tests/unittests/test_util.py (+3/-3)
tools/ds-identify (+20/-1)
~jocha/cloud-init:jocha-reboot-bugfix
- Douglas Jordan: Pending requested
- Chad Smith: Pending requested
-
Diff: 170 lines (+86/-8)2 files modifiedcloudinit/sources/DataSourceAzure.py (+14/-6)
tests/unittests/test_datasource/test_azure.py (+72/-2)
~mgerdts/cloud-init:lp1765085
- Scott Moser: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 68 lines (+36/-2)2 files modifiedcloudinit/sources/DataSourceSmartOS.py (+8/-2)
tests/unittests/test_datasource/test_smartos.py (+28/-0)
| Changed in cloud-init: | |
| assignee: | nobody → Mike Gerdts (mgerdts) |
| description: | updated |
| Changed in cloud-init: | |
| importance: | Undecided → Medium |
| Changed in cloud-init: | |
| status: | New → Confirmed |
Revision history for this message
| Scott Moser (smoser) wrote | #1 |
| Changed in cloud-init: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Chad Smith (chad.smith) wrote Fixed in cloud-init version 18.2-27-g6ef92c98-0ubuntu1~18.04.1. | #2 |
| Changed in cloud-init (Ubuntu): | |
| assignee: | nobody → Chad Smith (chad.smith) |
| Changed in cloud-init: | |
| status: | Fix Committed → Fix Released |
| Changed in cloud-init (Ubuntu): | |
| status: | New → Fix Released |
Revision history for this message
| Scott Moser (smoser) wrote Fixed in cloud-init version 18.3. | #3 |
| Changed in cloud-init: | |
| status: | Fix Released → Fix Committed |
| status: | Fix Committed → Fix Released |
Revision history for this message
| James Falcon (falcojr) wrote | #4 |
To post a comment you must log in.
An upstream commit landed for this bug.
To view that commit see the following URL:
https:/