[SRU] fcitx should check XShape before using it

Bug #1634004 reported by Wei Tsui
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
fcitx (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Medium
Unassigned

Bug Description

[Impact]

fcitx's classicui implementation should check for the availability of XShape before using it, which would be the case for some vncserver sessions.

[Test Case]

fcitx should not crash with classicui under vncserver session.

[Regression Potential]

This commit adds checks before using XShape, the chance of regression is minimal. In the other hand classic ui is not the default in Ubuntu, so the impact is low.

Revision history for this message
Wei Tsui (ghostplant) wrote :
Aron Xu (happyaron)
Changed in fcitx (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Aron Xu (happyaron)
Changed in fcitx (Ubuntu Xenial):
status: New → Triaged
Aron Xu (happyaron)
summary: - Fcitx conflicts with Ubuntu 16.04 Xlib (only happened on vncserver)
+ [SRU] fcitx should check XShape before using it
Aron Xu (happyaron)
description: updated
Changed in fcitx (Ubuntu Xenial):
status: Triaged → In Progress
Revision history for this message
Wei Tsui (ghostplant) wrote :

Hi, thanks for the help, and how's it going?

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Cui, or anyone else affected,

Accepted fcitx into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fcitx/4.2.9.1-4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in fcitx (Ubuntu):
status: Triaged → Fix Committed
Changed in fcitx (Ubuntu Yakkety):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Wei Tsui (ghostplant) wrote :

Hi, I care more about fcitx in xenial repository. Can you provide a xenial-proposed port for testing?

Revision history for this message
Wei Tsui (ghostplant) wrote :

Sorry, this fix doesn't work for me. The indicator was shown in vncserver but I still cannot switch out the frontend panel, even if I has selected pinyin input method.

Revision history for this message
Wei Tsui (ghostplant) wrote :

To be clear,

1) without this fix: nothing even fcitx indicator doesn't show inside vncserver;
2) with this fix: only fcitx indicator shows inside vncserver, but I still cannot switch out charactor input panel to input any chinese charactors;
3) ignore BadValue exception: this fix works well, everything (both indicator and panel) came back to normal.

Revision history for this message
Aron Xu (happyaron) wrote :

One more patch is needed to fix this issue, unfortunately.

Changed in fcitx (Ubuntu Xenial):
status: In Progress → Triaged
Changed in fcitx (Ubuntu Yakkety):
status: Fix Committed → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fcitx - 1:4.2.9.1-4

---------------
fcitx (1:4.2.9.1-4) unstable; urgency=medium

  * Cherry-pick from upstream:
    - Check XShape version before using it (LP: #1634004)

 -- Aron Xu <email address hidden> Mon, 17 Oct 2016 09:55:44 +0800

Changed in fcitx (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Wei Tsui (ghostplant) wrote :

Hi xenial repository is still not updated

Revision history for this message
Wei Tsui (ghostplant) wrote :

yakkety fcitx has another issue: when using fcitx is used as the input method to write some data in Gedit, when frequently copying and pasting multi-line text in Gedit, UI is seems to be very slow.
If fcitx is closed, same operation comes back to normal.

Aron Xu (happyaron)
Changed in fcitx (Ubuntu Yakkety):
status: Triaged → In Progress
Revision history for this message
Wei Tsui (ghostplant) wrote :

Hi Aron~
Why you are still not planing to fix fcitx in xenial source?

Revision history for this message
Aron Xu (happyaron) wrote :

Please be patient, the fix lands in zesty yesterday (synced from Debian), and yakkety is on the way.

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hello Cui, or anyone else affected,

Accepted fcitx into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fcitx/1:4.2.9.1-1ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in fcitx (Ubuntu Xenial):
status: Triaged → Fix Committed
Revision history for this message
Wei Tsui (ghostplant) wrote :

Verified on xenial, and all works successfully on vnc4server!

Aron Xu (happyaron)
tags: added: verification-done-xenial
removed: verification-needed xenial
Revision history for this message
Wei Tsui (ghostplant) wrote :

Sorry, who can help me delete my last comment here, it should be posted to metacity bug report.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fcitx - 1:4.2.9.1-1ubuntu1.16.04.1

---------------
fcitx (1:4.2.9.1-1ubuntu1.16.04.1) xenial; urgency=medium

  * 0007-handle-reset-ic.patch: handle XmbReetIC() (LP: #1608469)
  * Check XShape version before using it (LP: #1634004)

 -- Aron Xu <email address hidden> Fri, 14 Oct 2016 14:18:35 +0800

Changed in fcitx (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for fcitx has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Aron Xu (happyaron) wrote :

I confirm it works in yakkety as well, tagging verification-done-yakkety.

tags: added: verification-done-yakkety
Aron Xu (happyaron)
Changed in fcitx (Ubuntu Yakkety):
status: In Progress → Fix Committed
Aron Xu (happyaron)
Changed in fcitx (Ubuntu Yakkety):
status: Fix Committed → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote :

Publishing details

    Published 16 minutes ago
    Copied from debian sid in Primary Archive for Debian GNU/Linux by Brian Murray

Changelog

fcitx (1:4.2.9.1-4) unstable; urgency=medium

  * Cherry-pick from upstream:
    - Check XShape version before using it (LP: #1634004)

 -- Aron Xu <email address hidden> Mon, 17 Oct 2016 09:55:44 +0800

Changed in fcitx (Ubuntu Yakkety):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.