[SRU] fcitx does not handle XmbReetIC() properly

Bug #1608469 reported by bugproxy
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fcitx (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Aron Xu

Bug Description

[Impact]

fcitx XIM server cannot handle XmbResetIC() as expected.
By XmbResetIC(), fcitx should return preedit string or cancel preedit.
But even if XmbResetIC() was called, fcitx still had preedit string, preedit string was not flushed.

[Test Case]

Step to reproduce:
This testing requires Japanese environment on Ubuntu Desktop 16.04.
Also fcitx , fcitx-module-X11, fcitx-mozc, mozc-server should be configured
1. Login to Ubuntu Desktop
2. Open gnome-terminial
3. Set XMODIFIERS environment variable to @im=fcitx
  $ export XMODIFIERS=@im=fcitx
4. Compile and run test program
5. Turn on IME, by Ctrl+Space
6. Type "a", then preedit string which is on preedit window is displayed under XIM demo window
7. Move mouse cursor on XIM demo window, then press Right mouse button
8. Then XmbResetIC() is called, but preedit window is still there and preedit string is still there.
(Preedit string should be flushed by XmbResetIC())
9. Type "i", 2 characters are displayed into preedit string

When fixed, preedit string should be gone.

[Regression Potential]

This minimal patch is from upstream, which only touches the specific area, and it's in yakkety for a while without problem.

Revision history for this message
bugproxy (bugproxy) wrote : xim_root

Default Comment by Bridge

tags: added: architecture-x8664 bugnameltc-143756 severity-medium targetmilestone-inin---
Changed in ubuntu:
assignee: nobody → Taco Screen team (taco-screen-team)
affects: ubuntu → fcitx-configtool (Ubuntu)
Steve Langasek (vorlon)
Changed in fcitx-configtool (Ubuntu):
assignee: Taco Screen team (taco-screen-team) → nobody
Aron Xu (happyaron)
affects: fcitx-configtool (Ubuntu) → fcitx (Ubuntu)
Revision history for this message
vaishnavi (vaishnavi) wrote : Re: fcitx does not handle XmbReetIC() properly

Hi Canonical,

When can we expect this issue to be fixed ? I see this bug is in Unassigned state.

Thank you.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fcitx - 1:4.2.9.1-3

---------------
fcitx (1:4.2.9.1-3) unstable; urgency=medium

  * Cherry-pick from upstream commits:
    - Do not show autostart desktop file
    - Handle XmbResetIC() (LP: #1608469)
    - Better notificationitem handling for unity

 -- Aron Xu <email address hidden> Tue, 20 Sep 2016 04:07:02 +0800

Changed in fcitx (Ubuntu):
status: New → Fix Released
Jeremy Bícha (jbicha)
Changed in fcitx (Ubuntu Xenial):
status: New → Triaged
Aron Xu (happyaron)
summary: - fcitx does not handle XmbReetIC() properly
+ [SRU] fcitx does not handle XmbReetIC() properly
description: updated
Changed in fcitx (Ubuntu Xenial):
status: Triaged → In Progress
assignee: nobody → Aron Xu (happyaron)
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted fcitx into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fcitx/1:4.2.9.1-1ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in fcitx (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2016-11-15 03:08 EDT-------
Sorry I was late.
I could install update package properly and it worked fine as expected.

$ dpkg -s fcitx
Package: fcitx
Status: install ok installed
Priority: optional
Section: utils
Installed-Size: 36
Maintainer: Ubuntu Developers <email address hidden>
Architecture: all
Version: 1:4.2.9.1-1ubuntu1.16.04.1
Depends: fcitx-bin, fcitx-data, fcitx-modules
Recommends: fcitx-config-gtk | kde-config-fcitx, fcitx-frontend-all | fcitx-frontend-fbterm, fcitx-ui-classic | fcitx-ui-light, im-config (>= 0.5) | im-switch
Suggests: fcitx-m17n, fcitx-tools
Conffiles:
/etc/X11/xinit/xinput.d/fcitx 16f80add1cac78453353a128af575771
Description: Flexible Input Method Framework
Fcitx is a input method framework with extension support, which provides
an interface for entering characters of different scripts in applications
using a variety of mapping systems.
.
It offers a pleasant and modern experience, with intuitive graphical
configuration tools and customizable skins and mapping tables. It is
highly modularized and extensible, with GTK+ 2/3 and Qt4 IM Modules, support
for UIs based on Fbterm, pure Xlib, GTK+, or KDE, and a developer-friendly
API.
.
This metapackage pulls in a set of components recommended for most desktop
users.
Original-Maintainer: IME Packaging Team <email address hidden>
Homepage: https://github.com/fcitx/fcitx

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fcitx - 1:4.2.9.1-1ubuntu1.16.04.1

---------------
fcitx (1:4.2.9.1-1ubuntu1.16.04.1) xenial; urgency=medium

  * 0007-handle-reset-ic.patch: handle XmbReetIC() (LP: #1608469)
  * Check XShape version before using it (LP: #1634004)

 -- Aron Xu <email address hidden> Fri, 14 Oct 2016 14:18:35 +0800

Changed in fcitx (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for fcitx has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.