Libertine

Archive is still added when a container fails to start

Bug #1579807 reported by Christopher Townsend
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libertine
Status tracked in Devel
Devel
Fix Released
Medium
Larry Price
Libertine 1.1
Trunk
Fix Released
Medium
Larry Price
Libertine 1.1
libertine (Ubuntu)
Fix Released
Medium
Larry Price

Bug Description

When trying to add a new PPA and the container fails to start, the PPA is still entered into the ContainersConfig.json. It should not add it if the container fails to start for whatever reason.

Tags: cli

Related branches

lp:~larryprice/libertine/archive-add-fail
Libertine CI Bot: Approve (continuous-integration)
Christopher Townsend: Approve
Diff: 34 lines (+3/-4)
1 file modified
tools/libertine-container-manager (+3/-4)
lp:~townsend/libertine/release-1.0.4
Stephen M. Webb (community): Approve
Diff: 2083 lines (+601/-392)
31 files modified
debian/changelog (+29/-0)
libertine/ContainerConfigList.cpp (+0/-1)
libertine/ContainerManager.cpp (+85/-47)
libertine/ContainerManager.h (+4/-3)
libertine/PasswordHelper.cpp (+1/-1)
libertine/qml/ContainerInfoView.qml (+12/-7)
libertine/qml/ContainerOptionsDialog.qml (+3/-3)
libertine/qml/ContainerPasswordDialog.qml (+2/-2)
libertine/qml/ContainersView.qml (+35/-18)
libertine/qml/DebianPackagePicker.qml (+21/-6)
libertine/qml/ExtraArchivesView.qml (+38/-37)
libertine/qml/GenericErrorDialog.qml (+35/-0)
libertine/qml/HomeView.qml (+35/-20)
libertine/qml/ManageContainer.qml (+77/-63)
libertine/qml/PackageExistsDialog.qml (+2/-2)
libertine/qml/PackageInfoView.qml (+18/-4)
libertine/qml/PackageOperationFailureDialog.qml (+0/-36)
libertine/qml/SearchPackagesDialog.qml (+2/-2)
libertine/qml/SearchResults.qml (+22/-10)
libertine/qml/SearchResultsView.qml (+22/-18)
libertine/qml/WelcomeView.qml (+11/-3)
libertine/qml/libertine.qml (+12/-21)
liblibertine/libertine.cpp (+1/-2)
po/en_US.po (+52/-30)
po/libertine.pot (+46/-32)
python/libertine/ChrootContainer.py (+2/-2)
python/libertine/Libertine.py (+5/-5)
python/libertine/LxcContainer.py (+4/-2)
tools/libertine-container-manager (+7/-7)
tools/libertine-launch (+5/-0)
tools/update-puritine-containers (+13/-8)
Christopher Townsend (townsend)
tags: added: cli
Changed in libertine (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

Fix committed into lp:libertine at revision 224, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status: In Progress → Fix Committed
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Larry Price (larryprice)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libertine - 1.0.4+16.10.20160519-0ubuntu1

---------------
libertine (1.0.4+16.10.20160519-0ubuntu1) yakkety; urgency=medium

  [ Chris Townsend ]
  * Work around sudo issue where $PATH is not preserved even though the -E
    (preserve environment) option is used.
  * Fix the click hook script such that it checks if the json file exists first.
    Also had to change from using scandir() to listdir() since scandir() is not
    in the Vivid version of Python.

  [ Larry Price ]
  * Blacklist Mir-related environment variables that interfere with X apps.
    (LP: #1540091)
  * Prevent crash when listing apps from non-existent container.
  * Update from Ubuntu Components 1.2 to 1.3.
  * Fix add- and delete-archive error checking when container fails to start.
    (LP: #1579807)
  * Show a standard error dialog in more cases when libertine-container-manager
    has issues.
  * Default behavior on single tap for Containers, Apps, DEBs, and Search
    Results. (LP: #1579189)
  * Update should return its exit code for proper error display in GUI.
    (LP: #1562139)

  [ Stephen M. Webb ]
  * Blacklist Mir-related environment variables that interfere with X apps.
    (LP: #1540091)

  [ CI Train Bot ]
  * No-change rebuild.

 -- Christopher Townsend <email address hidden> Thu, 19 May 2016 17:53:58 +0000

Changed in libertine (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.