Ubuntu
thumbnailer package

Transparent PNG files have a black color background

Bug #1541836 reported by Arthur Mello
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Wishlist
Alejandro J. Cura
Canonical System Image 10 "OTA10"
thumbnailer (Ubuntu)
Fix Released
Wishlist
Michi Henning

Bug Description

When requesting a new thumbnail from a PNG file with transparent background, the result image has a solid black color background. The problem is worst when trying to display a black and transparent PNG file. Attached a simple QML app that shows the problem.

Related branches

lp:~michihenning/thumbnailer/transparency
James Henstridge: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 983 lines (+320/-113)
20 files modified
debian/control (+1/-0)
include/internal/image.h (+18/-3)
man/thumbnailer-admin.1 (+3/-3)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.cpp (+2/-0)
src/image.cpp (+48/-10)
src/imageextractor.cpp (+1/-1)
src/libthumbnailer-qt/libthumbnailer-qt.cpp (+1/-1)
src/thumbnailer-admin/CMakeLists.txt (+1/-1)
src/thumbnailer-admin/get_local_thumbnail.cpp (+1/-0)
src/thumbnailer-admin/get_remote_thumbnail.cpp (+1/-0)
src/thumbnailer-admin/util.cpp (+20/-4)
src/thumbnailer-admin/util.h (+5/-0)
src/thumbnailer.cpp (+7/-5)
src/vs-thumb/thumbnailextractor.cpp (+1/-1)
tests/image/image_test.cpp (+91/-47)
tests/libthumbnailer-qt/libthumbnailer-qt_test.cpp (+5/-5)
tests/media/transparent.svg (+40/-0)
tests/thumbnailer-admin/thumbnailer-admin_test.cpp (+64/-32)
tests/thumbnailer/thumbnailer_test.cpp (+5/-0)
tests/version/version_test.cpp (+5/-0)
Revision history for this message
Arthur Mello (artmello) wrote :
Revision history for this message
Arthur Mello (artmello) wrote :
Revision history for this message
Michi Henning (michihenning) wrote :

I guess the thumbnail would look extremely black :-(

We've had the same issue reported previously: https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1532719

Fixing it isn't rocket science, but will take a day or two of work, which I currently can't spare. How urgent is this?

Changed in thumbnailer (Ubuntu):
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Arthur Mello (artmello) wrote :

That is not too urgent but it is an issue for gallery-app. Downloading images with transparency is not a big use case for the app (and only the ones that are black and transparent would be really an issue), but since gallery is the "default" app for saving images we would need to fix that.

Michi Henning (michihenning)
Changed in thumbnailer (Ubuntu):
assignee: nobody → Michi Henning (michihenning)
status: Confirmed → In Progress
Michi Henning (michihenning)
Changed in thumbnailer (Ubuntu):
status: In Progress → Fix Committed
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → Wishlist
milestone: none → ww08-2016
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thumbnailer - 2.4+16.04.20160302.1-0ubuntu1

---------------
thumbnailer (2.4+16.04.20160302.1-0ubuntu1) xenial; urgency=medium

  [ Michi Henning ]
  * Thumbnails now preserve transparency of source image (LP: #1532719, LP: #1541836).
  * Fixed incorrect tests when checking full-size cache hits (LP: #1540753).
  * Minor improvements to man pages.

  [ CI Train Bot ]
  * No-change rebuild.

 -- Michi Henning <email address hidden> Wed, 02 Mar 2016 05:20:31 +0000

Changed in thumbnailer (Ubuntu):
status: Fix Committed → Fix Released
Alejandro J. Cura (alecu)
Changed in canonical-devices-system-image:
assignee: nobody → Alejandro J. Cura (alecu)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.