Video thumbnails don't go into full-size cache
Bug #1540753 reported by
Michi Henning
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Alejandro J. Cura | ||
| thumbnailer (Ubuntu) |
Fix Released
|
Medium
|
Michi Henning | ||
Bug Description
Video thumbnails from vs-thumb should go into the full-size cache, but they don't. The logic for read() is broken, we need to add the full-size image, possibly down-scaled, there.
Best way to deal with this is to factor out the logic for adding stuff to the full-size cache and then call that from both places?
Related branches
lp:~michihenning/thumbnailer/fullsize-test-fixes
- James Henstridge: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 211 lines (+44/-53)3 files modifiedsrc/thumbnailer.cpp (+1/-2)
tests/thumbnailer-admin/thumbnailer-admin_test.cpp (+8/-18)
tests/thumbnailer/thumbnailer_test.cpp (+35/-33)
| Changed in thumbnailer (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in thumbnailer (Ubuntu): | |
| assignee: | nobody → Michi Henning (michihenning) |
| Changed in thumbnailer (Ubuntu): | |
| status: | New → In Progress |
| Changed in thumbnailer (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
| milestone: | none → ww08-2016 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in thumbnailer (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package thumbnailer - 2.4+16.
---------------
thumbnailer (2.4+16.
[ Michi Henning ]
* Thumbnails now preserve transparency of source image (LP: #1532719, LP: #1541836).
* Fixed incorrect tests when checking full-size cache hits (LP: #1540753).
* Minor improvements to man pages.
[ CI Train Bot ]
* No-change rebuild.
-- Michi Henning <email address hidden> Wed, 02 Mar 2016 05:20:31 +0000