[SDK] Cannot set background colour for overflow of leading/trailing actions

Bug #1451225 reported by Andrew Hayzen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Committed
High
Jouni Helminen
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Zsombor Egri

Bug Description

[Update]

we are setting a better default value for the bgcolour for now (with 20% lighter background) which should work on the dark theme. As Zsombor also pointed out, you can customise the background with a custom theme:

"The solution is for you to provide your own theme, where you override the ListItemStyle and set the colour of the trailing panel accordingly."

-------------------------------------------

In music we use dark colours for the listitem background and therefore the background of the actions. With the 'new' listitems you can set the colour of the action by putting it inside a Rectangle. However I have been unable to set the colour if you 'pull' too far, it appears as white in this case.

I have created a mini app here [0], if you open the application and drag a listitem to the left you will notice that the action appears, with a background colour set, but then if the user pulls too far it turns to white. (I assume it is the same with the leading actions if you didn't want them to have a red background)

Is there anyway we can set this colour?

0 - http://pastebin.ubuntu.com/10979455/

Related branches

Revision history for this message
Zsombor Egri (zsombi) wrote :

The bug here is the colouring of the panel colors using Palette value rather than setting the bg colour of the panel. Unfortunately we did not receive any colouring guides from UX for dark themes, only for Ambiance.

Revision history for this message
Zsombor Egri (zsombi) wrote :

The solution is for you to provide your own theme, where you override the ListItemStyle and set the colour of the trailing panel accordingly.

Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Zsombor Egri (zsombi)
status: New → Confirmed
Revision history for this message
Zsombor Egri (zsombi) wrote :

Added Ubuntu UX to the bug as we don't have style for SuruDark theme. If added, we should have a default colour for the trailing panel.

I'll try 10% lighter background color to see if that suits. However, if added, you should not use delegate for showing the actions.

Revision history for this message
Zsombor Egri (zsombi) wrote :

A screenshot [1] with 20% lighter background (10% wasn't enough) and 40% lighter foreground colour, both from SuruDark normal palette.

The second one [2] is with 40% lighter background and foreground. That seems to be better a bit.

[1] https://www.dropbox.com/s/xhyt3wr6zwixca2/Screenshot%202015-07-14%2014.27.23.png?dl=0
[2] https://www.dropbox.com/s/89j3wipgkuj4f37/Screenshot%202015-07-14%2014.31.35.png?dl=0

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
importance: Medium → High
Revision history for this message
Zsombor Egri (zsombi) wrote :

[14:34:33] <jounih> 20% is good. The selected state for listitem (the white bg with orange text) looks way too bright on the surudark

so [1] from comment #4 is the chosen one.

summary: - Cannot set background colour for overflow of leading/trailing actions
+ [SDK] Cannot set background colour for overflow of leading/trailing
+ actions
Changed in ubuntu-ux:
importance: Undecided → High
assignee: nobody → Jouni Helminen (jounihelminen)
Changed in ubuntu-ux:
status: New → Triaged
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Changed in ubuntu-ux:
status: Triaged → Fix Committed
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1584+15.10.20150730-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1584+15.10.20150730-0ubuntu1) wily; urgency=medium

  [ Florian Boucault ]
  * New BottomEdgeHint component to represent extra features available from the
    bottom edge of an application.

  [ Loïc Molinari ]
  * [UbuntuShape] Added a big radius.
  * [UbuntuShape] Added relative radius support. Fixes LP: #1478124.
  * Ensured components, styles, examples and tests use the new UbuntuShape
    properties (not deprecated). Fixes LP: #1437412.

  [ Benjamin Zeller ]
  * Make use of the official qt build macros to blend into the Qt buildprocess.
  * Fix debug builds, optimization is always enabled by the system qt build.

  [ Richard Huddie ]
  * Fix for autopilot bug lp:1476715. Don't throw an exception if maliit-server
    is not found. Fixes LP: #1476715.

  [ Tim Peeters ]
  * Clean up the MainView docs.
  * Set theme version for Sections component.
  * Implement AdaptivePageLayout.

  [ Zsombor Egri ]
  * Fix width for trailing and leading actions of a ListItem. Fixes LP: #1465582.
  * Button and Haptics import wrong toolkit versions, thus they break style
    versioning. Moving Icon and ProgressBar to 1.0 and 1.1 version source folder.
  * SuruDark theme for ListItem style. Fixes LP: #1451225.
  * Swiping ListItem when no actions are defined for the gesture breaks
    selectMode. Fixes LP: #1468100.
  * Fixing selected connection with the ListItem's select mode checkbox state.
    Fixes LP: #1461501, LP: #1469471.

  [ Timo Jyrinki ]
  * Fix ucstylehints.cpp compilation with Qt 5.5. Fixes LP: #1473873.
  * Add PageHeadStyle 1.3 reference to fix install_plugins_qmltypes failure with
    Qt 5.5. Fixes LP: #1466484.

  [ Christian Dywan ]
  * Avoid hard-coded skipping of members by name "type" can be a property name
    regardless of also being a field in the JSON description of a property.
  * Add apicheck unit test for QML and Javascript.
  * Remove "do cleanup" comments. Fixes LP: #1369874.
  * Initialize defaultTypes later to avoid bogus types.
  * Implement Action.shortcut property. Fixes LP: #1202464.
  * Update text handler to 3gu assert.
  * Add a deprecated note to ListItems.ThinDivider. Fixes LP: #1470951.
  * Don't include overridden properties in API.
  * Clean-up API check wrapper scripts.
  * Track version members were introduced.
  * Implement ListItemPopover on right-click. Fixes LP: #1452676.
  * Move delegate's chevron into the row and size it explicitly.
    Fixes LP: #1474418.
  * Enable (Shift)Tab via activeFocusOnTab. Fixes LP: #1276797.
  * Only swipe with left button and block timer otherwise.
    Fixes LP: #1476300, LP: #1476310.
  * Include Javascript libraries in QML documentation. Fixes LP: #1466058.

  [ Albert Astals Cid ]
  * Fix warning if there's no __propagated
  * TypeError: Cannot call method 'hasOwnProperty' of null.

 -- CI Train Bot <email address hidden> Thu, 30 Jul 2015 13:04:18 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.