[sdk] TrailingAction widths needs to be clamped
Bug #1465582 reported by
Nekhelesh Ramananthan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
Medium
|
Jamie Young | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri |
Bug Description
[Updated description]
In Podbird we have listitems that are sometimes big (height wise) and it has been noticed that when the listitem is big, the trailing edge actions width are too big that it hides the entire listitem when swiping left. Attached are screenshots that illustrate the issue.
–––
Desired outcome:
The width of trailing actions should be clamped to the width of the slot. The height of slot can be vary dependent on the height of the listitem.
[Please note]
We're revising the listitems in the latest SDK work. You can see the latest document here: https:/
Related branches
lp:~zsombi/ubuntu-ui-toolkit/listitem_actionsize
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 215 lines (+49/-22)4 files modifiedsrc/Ubuntu/Components/Themes/Ambiance/1.2/ListItemStyle.qml (+12/-11)
src/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml (+12/-11)
tests/resources/listitems/ListItemTest.qml (+1/-0)
tests/unit_x11/tst_components/tst_listitem.qml (+24/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Triaged |
tags: | added: new-listitems |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Triaged → In Progress |
summary: |
- TrailingAction widths needs to be clamped + [sdk] TrailingAction widths needs to be clamped |
Changed in ubuntu-ux: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Jamie Young (jamiedawsonyoung) |
description: | updated |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
<nik90> zsombi: hey, are the trailingaction widths dependent on the listitem height somehow? I am hitting this bug https:/ /imgur. com/a/Tx3K5# 0 2001:67c: 1560:a003: b1da:8d9f: 1c5f:de2e) has joined #ubuntu-app-devel
<zsombi> nik90: yes it is...
<nik90> zsombi: hmm perhaps I should show the description in a dialog to avoid a big listitem in that case
<zsombi> nik90: but what's wrong there?
<nik90> zsombi: in the 3rd image, my entire list item is hidden by the trailing actions and also the 3rd trailing action "info" has no background
* patriciadavila (~patriciad@
<zsombi> nik90: hmm! that's bad, seems we have to adjust the width calculation
<nik90> zsombi: yeah ... perhaps add a Math.max() to ensure it doesnt exceed a design set max value
<zsombi> nik90: I think we have a clamp there...
<zsombi> nik90: yes, we have, but the minimum value is the height of the listitem, and that's not good
<nik90> zsombi: ah ok..