webbrowser-app

new tab view empty when restoring an empty tab

Bug #1444023 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webbrowser-app
Fix Released
High
Riccardo Padovani
webbrowser-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Steps to reproduce:

 1) Pull the bottom edge hint up to open the tabs view, then tap the "New Tab" button
 2) Verify that you get the new tab view that displays bookmarks and top sites
 3) Close the browser
 4) Open the browser again

Expected result: the new tab view is opened

Current result: a blank tab is restored, but the new tab view isn’t there

See original description
Tags: newtab

Related branches

lp:~rpadovani/webbrowser-app/newTabRefactoring
PS Jenkins bot: Needs Fixing (continuous-integration)
Olivier Tilloy: Approve
Diff: 773 lines (+351/-279)
6 files modified
src/app/webbrowser/Browser.qml (+59/-59)
src/app/webbrowser/NewTabView.qml (+200/-126)
src/app/webbrowser/UrlsList.qml (+72/-93)
src/app/webbrowser/bookmarks-model.cpp (+3/-1)
src/app/webbrowser/bookmarks-model.h (+2/-0)
tests/unittests/bookmarks-model/tst_BookmarksModelTests.cpp (+15/-0)
lp:ubuntu/wily/webbrowser-app
Revision history for this message
Olivier Tilloy (osomon) wrote :

Actually, this works on desktop, but not on a krillin with the latest vivid-proposed. Needs investigation.

Revision history for this message
Olivier Tilloy (osomon) wrote :

This turns out to be yet another shortcoming of the implementation of the new tab view.

The history model and bookmarks model are instantiated asynchronously, but the NewTabView component checks their values at instantiation to add sections to the list model, and it doesn’t react to their becoming non-null asynchronously later on.

summary: - [regression] new tab view not opened when restoring empty tab
+ new tab view not opened when restoring empty tab
summary: - new tab view not opened when restoring empty tab
+ new tab view empty when restoring an empty tab
Changed in webbrowser-app:
importance: Medium → High
description: updated
Revision history for this message
Olivier Tilloy (osomon) wrote :

Pointer to the faulty code: http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/NewTabView.qml#L42

tags: added: newtab
Olivier Tilloy (osomon)
Changed in webbrowser-app:
assignee: nobody → Riccardo Padovani (rpadovani)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+15.10.20150602-0ubuntu1

---------------
webbrowser-app (0.23+15.10.20150602-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Olivier Tilloy ]
  * Actually clear the network cache by deleting the correct set of
    files in the correct directory. (LP: #1459956)
  * Bump build dependency on liboxideqt-qmlplugin to 1.6 to fix unit
    tests.
  * Do not cache favicons on disk when browsing in private mode. (LP:
    #1458963)
  * Do not try to remove a file that doesn’t exist.
  * Pass plain strings to the worker script instead of RegExps. (LP:
    #1445673)
  * Remove the upstreamcomponents folder, and use components from the
    UITK instead. Add autopilot tests for the new tab view.
  * Update translation template.
  * Updated icon. (LP: #1457424)

  [ Riccardo Padovani ]
  * New tab view refactoring. (LP: #1371248, #1444023, #1351157,
    #1389605, #1442190)
  * New tab view refactoring. (LP: #1371248, #1444023, #1351157,
    #1389605, #1442190)

 -- CI Train Bot <email address hidden> Tue, 02 Jun 2015 14:26:50 +0000

Changed in webbrowser-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.