We should hide the player controls in the sound indicator until the music player is fixed to work with them
Bug #1381069 reported by
Rick Spencer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| indicator-sound (Ubuntu) |
Invalid
|
Critical
|
Lars Karlitski | ||
| media-hub (Ubuntu) |
Fix Released
|
Critical
|
Thomas Voß | ||
Bug Description
see these two bugs:
https:/
https:/
Essentially, the music player does not work with the sound menu, and the fix is involved. Until the default experience works, I suggest that we do not show these controls.
Related branches
lp:~larsu/indicator-sound/lp1381069
- Ted Gould (community): Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 83 lines (+30/-11)2 files modifiedsrc/service.vala (+18/-4)
src/sound-menu.vala (+12/-7)
lp:~thomas-voss/media-hub/do-not-export-to-mpris-by-default
- PS Jenkins bot: Approve (continuous-integration)
- Alberto Aguirre (community): Approve
-
Diff: 78 lines (+18/-1)4 files modifiedCMakeLists.txt (+2/-0)
src/core/media/CMakeLists.txt (+1/-0)
src/core/media/service_skeleton.cpp (+14/-1)
tests/unit-tests/CMakeLists.txt (+1/-0)
| Changed in indicator-sound (Ubuntu): | |
| assignee: | nobody → Thomas Strehl (strehl-t) |
| tags: | added: rtm14 |
Revision history for this message
| Joe Odukoya (jodukoya) wrote | #1 |
| Changed in indicator-sound (Ubuntu): | |
| status: | New → In Progress |
| assignee: | Thomas Strehl (strehl-t) → Lars Uebernickel (larsu) |
Revision history for this message
| Rick Spencer (rick-rickspencer3) wrote | #2 |
| Changed in indicator-sound (Ubuntu): | |
| importance: | Undecided → Critical |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in media-hub (Ubuntu): | |
| status: | New → Fix Released |
| Changed in media-hub (Ubuntu): | |
| assignee: | nobody → Thomas Voß (thomas-voss) |
| importance: | Undecided → Critical |
| Changed in indicator-sound (Ubuntu): | |
| status: | In Progress → Invalid |
To post a comment you must log in.
*If* this is achievable without risk can we add this to the 10/16 iteration.
There was a suggestion that we might be able to make the controls invisible until they actually work if so then that would be a good solution.