lp:~thomas-voss/media-hub/do-not-export-to-mpris-by-default

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:media-hub at revision 73

PS Jenkins bot: Approve (continuous-integration) on 2014-10-14

Alberto Aguirre (community): Approve on 2014-10-14

Diff: 78 lines (+18/-1)

4 files modified

CMakeLists.txt (+2/-0)
src/core/media/CMakeLists.txt (+1/-0)
src/core/media/service_skeleton.cpp (+14/-1)
tests/unit-tests/CMakeLists.txt (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1381069: We should hide the player controls in the sound indicator until the music player is fixed to work with them

Critical

Invalid

Link a bug report

Related blueprints

73. By Thomas Voß on 2014-10-14

Only expose the service as MPRIS instance if explicitly requested via env variable.

72. By PS Jenkins bot on 2014-10-10

Releasing 2.0.0+14.10.20141010-0ubuntu1

71. By Alberto Aguirre on 2014-10-10

Fix potential access to dead objects. Fixes: 1364483, 1376352
Approved by: Thomas Voß

70. By PS Jenkins bot on 2014-09-26

Releasing 2.0.0+14.10.20140926-0ubuntu1

69. By Alberto Aguirre on 2014-09-26

Fix self deadlock when clients disconnect from media::Player

When receiving a media::PlayerImplementation on_client_disconnected signal, avoid calling
remove_player_for_key within the same context as the player object may be deleted (which owns
the signal object whose destructor waits until all slots are dispatched). Fixes: 1371454
Approved by: Jim Hodapp, Thomas Voß

68. By Alberto Aguirre on 2014-09-26

Prevent dead object access by asynchronous calls to clear_wakelock in media::PlayerImplementation::Private

On an player engine state change - detached threads are launched to clear system/display wakelocks in the future.
Before those threads get a chance to execute, media::PlayerImplementation can be destroyed. By holding a weak_ptr to
 media::PlayerImplementation::Private in the launched threads, access to dead Private objects is prevented. Fixes: 1373722
Approved by: Jim Hodapp, PS Jenkins bot

67. By PS Jenkins bot on 2014-09-17

Releasing 2.0.0+14.10.20140917-0ubuntu1

66. By Alberto Aguirre on 2014-09-17

Fix wake lock state machine and subtle race conditions on wake lock refcounts. Fixes: 1368786
Approved by: Jim Hodapp, PS Jenkins bot

65. By PS Jenkins bot on 2014-09-10

Releasing 2.0.0+14.10.20140910.2-0ubuntu1

64. By PS Jenkins bot on 2014-09-10

Replaced 0replaceme with real versions.