[SIM PIN]+[krillin] cannot disable SIM locking via system-settings if SIM locked

The action in settings is really to disable locking. So the user must first unlock the sim from the menu, then can "dsisble locking" (not unlock) for that sim.

One solution would be for settings to do both actions which is what the user would expect since the PIN they enter is correct.
The current message that the PIN is invalid is certainly incorrect and leads the user to think they forgot their PIN.

Same error running krillin + rtm #72.

Tried to toggle the toggle the SIM PIN control for SIM 1 which was locked. Was prompted to enter my PIN and when I did, I saw the same error dialog ( see attached screenshot ) as Bill.

Note, I had a second unlocked SIM in slot #2.

So a bit of digging shows that this looks to be device-specific.

On krillin, I'm unable to unlock the SIM unless I've previously entered the SIM PIN ( ie. the SIM has already been entered once ).

On mako, the same operation succeeds without having previously entered the SIM PIN.

I've added an ofono task and assigned to Alfonso for a second opinion.

First, as Pat commented there has been some confusion in the bug between actions:

Enter PIN -> Enter PIN after modem reboot to be able to use the phone
Unlock PIN -> Deactivate PIN so no PIN needs to be entered after modem reboot

For both actions you need to use the current PIN. Maybe some rewording of these actions in the GUI can remove the confusion for the user (Enter PIN vs Activate/deactivate PIN?)

Second, Tony is right and the behaviour for the "Unlock PIN" action depends on the device if we still have not entered the PIN ("Enter PIN") after a reboot. Using ofono scripts:

/usr/share/ofono/scripts/unlock-pin /ril_0 pin XXXX

works for mako, but for krillin we have to do

/usr/share/ofono/scripts/enter-pin /ril_0 pin XXXX
/usr/share/ofono/scripts/unlock-pin /ril_0 pin XXXX

TBH krillin behaviour is what I would have expected to happen usually, and of course doing the two steps for mako works too (mako's modem FW is probably doing itself the two steps if needed). So I would assume krillin behaviour as the default.

From a user perspective, my opinion is that displaying an error when the user tries to unlock the PIN saying "you need to enter the PIN first" helps the user understand the difference between entering PIN and PIN activation. Note also that this problem does not happen for non-Ubuntu phones, as afaik in all of them you have to enter the PIN on start to use the phone if it is activated.

@Alfonso

Thanks for the detailed response.

With respect to other phones, the only other phone OS where I've used a locked SIM is Android. I'm pretty sure you it was possible in the past to skip the Unlock SIM screen and continue, but that doesn't appear to be the case with 4.4.4 on a Nexus 5.

AFAIK, the original Greeter design also behaved the same way, however I'm not aware of plans to change this before RTM, which means the user could end up in a state where they have a locked SIM in the device, and yet are still using it.

That said, I disagree with the comment about displaying an error that says "you need to enter a PIN first". "Enter PIN" and "Unlock PIN" both require the same PIN, so asking the user to enter the same string of digits twice doesn't make any sense.

As mako runs vanilla Android, I would also take it as the reference and claim that this should be quirked in the mtkmodem driver, or we modify the settings code to always perform both operations when unlocking the SIM.

I will invite Ken to our weekly network/telephony hangout and add this bug to the agenda.

Our implementation will again prompt the user for the SIM Pin on a boot, but it will be possible to continue without entering it.
There is also a discussion ongoing to make it more obvious to the user that the SIM is locked (i.e. fix the indicator)
I would prefer a fix at the lower level rather than in the app.

@Pat

I agree that this should be quirked in the ofono mtkmodem implementation. Let's give Alfonso a chance to revisit and we should have an answer tomorrow on which approach we take.

Looks like ofono core allowed to do the unlock even if the PIN has not been entered, so probably implementing the quirk in ofono is fine.

This branch homogenizes the behaviour for krillin/mako:

https://github.com/rilmodem/ofono/pull/127

This bug was fixed in the package ofono - 1.12.bzr6880+14.10.20141010-0ubuntu1

---------------
ofono (1.12.bzr6880+14.10.20141010-0ubuntu1) utopic; urgency=medium

  [ Alfonso Sanchez-Beato ]
  * drivers/rilmodem/sim.c: enter PIN before unlocking (LP: #1375945)
    Some modems require the PIN to be unlocked with a separate
    command before the PIN lock can be disabled.

  * src/sim.c: fix sim atom teardown crash (LP: #1374418)
 -- Ubuntu daily release <email address hidden> Fri, 10 Oct 2014 08:53:32 +0000

Since this is Fixed in one place and Invalid in the other, this doesn't seem to have required any design in the first place. Please reopen with more details if I'm mistaken.