Ubuntu
network-manager-applet package

drop libgnome dependency

Bug #136945 reported by Jani Monoses
4
Affects Status Importance Assigned to Milestone
NetworkManager
Fix Released
Medium
network-manager-applet (Ubuntu)
Fix Released
Low
Alexander Sack

Bug Description

Here's a debdiff that gets rid of libgome dependency. The diff itself is small, but since configure.ac is touched an autoreconf patch is needed which spoils its beauty :)
The changes are a subset of recent patches that were sent to upstream in 0.7 trunk.
With these, Xubuntu could include n-m by default and it will also slightly benefit Ubuntu startup time and memory usage as well.
Debdiff is against the one in bug 95064

Revision history for this message
Jani Monoses (jani) wrote :

For easing review here's the cdbs patch that modifies the source.

Pedro Villavicencio (pedro)
Changed in network-manager-applet:
status: New → Triaged
Revision history for this message
Jani Monoses (jani) wrote :

This is the builk of it that was commited upstream
http://bugzilla.gnome.org/show_bug.cgi?id=460671

Revision history for this message
Jani Monoses (jani) wrote :

This is the builk of it that was comitted upstream
http://bugzilla.gnome.org/show_bug.cgi?id=460671

Bug Watch Updater (bug-watch-updater)
Changed in network-manager:
status: Unknown → New
Pedro Villavicencio (pedro)
Changed in network-manager-applet:
importance: Undecided → Low
Revision history for this message
Jani Monoses (jani) wrote :

Here's the upstream patch that was comitted and which contains another chunk of the diff (the GnomeClient api removal), at the end of the report
http://bugzilla.gnome.org/show_bug.cgi?id=436832

Revision history for this message
Alexander Sack (asac) wrote :

Hi, thanks for the patch(es) ... which patch to use now?

Changed in network-manager-applet:
assignee: nobody → asac
Revision history for this message
Jani Monoses (jani) wrote :

Hi,

the patch in the first comment, please. The ones in b.g.o I linked to are only to show that it's taken upstream.

After this patch is applied an autoreconf step is needed to propagate the change to ./configure and the generated Makefiles
$cdbs-edit-patch 99_autoreconf
then in the new shell
$autoreconf
$ rm -Rf ./autom4te.cache
to generate the build scripts and remove the large cache
the resulting 99_autoreconf patch, just as in the other Ubuntu desktop packages which touch configure.{ac,in} is a few hundred K :(
Sorry if this is all familiar. But it's easier to reproduce I guess than posting a large uncomprehensible diff with changes to ./configure

I can make a debdiff with all this though if you wish.

thanks

Revision history for this message
Jani Monoses (jani) wrote :

this is the debdiff I forgot to attach when filing the bug originally

Bug Watch Updater (bug-watch-updater)
Changed in network-manager:
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager-applet - 0.6.5-0ubuntu11

---------------
network-manager-applet (0.6.5-0ubuntu11) hardy; urgency=low

  * apply patch to drop gnome-runtime dependencies (LP: #136945) - patch by Jani
    Monoses
    - add debian/patches/06_drop_libgnome.patch
    - add debian/patches/99_autoconf_update.patch
  * don't use gksu in hardy anymore - policy kit hooray! (LP: #176222)
    - update debian/patches/01_static_network-admin.patch
    - update debian/patches/13_custom-network-admin.diff

  [ TJ ]
  * debian/patches/15_lp124336_missing_prototype_causes_connect_to_other_networks_sigsegv.patch:
    Fix SIGSEGV caused by pointer>int>pointer conversion on x86_64. (LP: #124336)

 -- Alexander Sack <email address hidden> Wed, 09 Jan 2008 13:15:10 +0100

Changed in network-manager-applet:
status: Triaged → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in network-manager:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.