Use click-review from click-reviewers-tools
Bug #1363857 reported by
Daniel Holbach
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Medium
|
Daniel Holbach | ||
| qtcreator-plugin-ubuntu |
Fix Released
|
Medium
|
Benjamin Zeller | ||
| qtcreator-plugin-ubuntu (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
At some stage it's going to make sense to move over to click-review instead of click-run-checks. It's been part of click-reviewers
Example usage: http://
It can very easily be extended, so let us know, if you need anything else.
Related branches
lp:~dholbach/click-reviewers-tools/1363857
- Benjamin Zeller (community): Approve
- Martin Albisetti (community): Approve
-
Diff: 103 lines (+36/-11)2 files modifiedbin/click-review (+35/-11)
debian/changelog (+1/-0)
lp:~zeller-benjamin/qtcreator-plugin-ubuntu/reviewtasks
- Zoltan Balogh: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1016 lines (+469/-384)14 files modifiedshare/qtcreator/templates/wizards/ubuntu/scope/CMakeLists.txt (+11/-2)
share/qtcreator/templates/wizards/ubuntu/scope/manifest.json.in (+1/-0)
share/qtcreator/templates/wizards/ubuntu/scope/wizard.xml (+1/-1)
share/qtcreator/ubuntu/devicespage/DeviceAdvancedTab.qml (+0/-92)
share/qtcreator/ubuntu/devicespage/DeviceBuilderTab.qml (+0/-42)
share/qtcreator/ubuntu/devicespage/DeviceEmulatorTab.qml (+0/-71)
share/qtcreator/ubuntu/devicespage/DeviceKitManager.qml (+0/-62)
share/qtcreator/ubuntu/devicespage/DeviceLogTab.qml (+0/-12)
share/qtcreator/ubuntu/devicespage/DevicePage.qml (+314/-92)
share/qtcreator/ubuntu/devicespage/ScrollableView.qml (+55/-0)
share/qtcreator/ubuntu/devicespage/SectionItem.qml (+58/-0)
share/qtcreator/ubuntu/scripts/qtc_device_applaunch.py (+4/-1)
src/ubuntu/ubuntu.pro (+3/-6)
src/ubuntu/ubuntupackageoutputparser.cpp (+22/-3)
lp:~zeller-benjamin/qtcreator-plugin-ubuntu/i18n_and_reviewtools
- PS Jenkins bot: Approve (continuous-integration)
- David Planella (community): Needs Fixing
- Zoltan Balogh: Pending requested
-
Diff: 1261 lines (+741/-112)36 files modifieddebian/qtcreator-plugin-ubuntu-common.install (+1/-0)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/CMakeLists.txt (+9/-7)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/app/CMakeLists.txt (+4/-5)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/app/components/CMakeLists.txt (+1/-1)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/app/displayName.desktop.in (+1/-1)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/app/ui/CMakeLists.txt (+1/-1)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/po/CMakeLists.txt (+58/-0)
share/qtcreator/templates/wizards/ubuntu/backendplustabs/wizard.xml (+3/-2)
share/qtcreator/templates/wizards/ubuntu/simplei18n/CMakeLists.txt (+75/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/CMakeLists.txt (+20/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/components/CMakeLists.txt (+6/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/components/HelloComponent.qml (+14/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/displayName.desktop.in (+10/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/displayName.qml (+41/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/tests/autopilot/displayName/__init__.py (+132/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/tests/autopilot/displayName/main/__init__.py (+1/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/tests/autopilot/displayName/main/test_main.py (+23/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/tests/autopilot/run (+11/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/tests/unit/tst_hellocomponent.qml (+49/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/ui/CMakeLists.txt (+6/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/ui/HelloTab.qml (+30/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/app/ui/WorldTab.qml (+29/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/manifest.json.in (+15/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/po/CMakeLists.txt (+58/-0)
share/qtcreator/templates/wizards/ubuntu/simplei18n/wizard.xml (+57/-0)
share/qtcreator/ubuntu/devicespage/DevicePage.qml (+7/-1)
share/qtcreator/ubuntu/devicespage/EmulatorNotInstalled.qml (+46/-0)
share/qtcreator/ubuntu/scripts/functions.inc (+3/-1)
src/ubuntu/ubuntu.pro (+2/-1)
src/ubuntu/ubuntuconstants.h (+3/-3)
src/ubuntu/ubuntupackagingwidget.cpp (+9/-2)
src/ubuntu/ubuntupackagingwidget.h (+1/-0)
src/ubuntu/ubuntuvalidationresultmodel.cpp (+3/-0)
tests/validation/fulloutput.json (+4/-72)
tests/validation/simplesection.json (+1/-1)
tests/validation/tst_validation.cpp (+7/-14)
Revision history for this message
| Daniel Holbach (dholbach) wrote | #1 |
| Changed in click-reviewers-tools: | |
| status: | New → In Progress |
| assignee: | nobody → Daniel Holbach (dholbach) |
| importance: | Undecided → Medium |
| Changed in click-reviewers-tools: | |
| status: | In Progress → Fix Committed |
| Changed in click-reviewers-tools: | |
| status: | Fix Committed → Fix Released |
| Changed in qtcreator-plugin-ubuntu: | |
| assignee: | nobody → zbenjamin (zeller-benjamin) |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in qtcreator-plugin-ubuntu (Ubuntu): | |
| status: | New → Fix Released |
| Changed in qtcreator-plugin-ubuntu: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
<zbenjamin> dholbach: sdk switch also sounds good to me, we just need some seperator between the top level objects