don't display notification when in the message thread
Bug #1347906 reported by
Bill Filler
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
| messaging-app (Ubuntu) |
Fix Released
|
High
|
Tiago Salem Herrmann | ||
| telephony-service (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
if the messaging app is open and you are in the message thread view and receive a message from that same person, we should not display the notify-osd. We should still vibrate and/or ring but skip the notification as it's not necessary and distracting.
Related branches
lp:~tiagosh/telephony-service/skip_notifications
- Bill Filler (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 57 lines (+21/-2)2 files modifiedindicator/textchannelobserver.cpp (+20/-2)
indicator/textchannelobserver.h (+1/-0)
lp:~tiagosh/telephony-service/fix-1482401
- Gustavo Pichorim Boiko (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 265 lines (+91/-37)3 files modifiedhandler/texthandler.cpp (+54/-36)
handler/texthandler.h (+1/-1)
tests/handler/HandlerTest.cpp (+36/-0)
| Changed in messaging-app: | |
| assignee: | nobody → Tiago Salem Herrmann (tiagosh) |
| milestone: | none → rtm-freeze |
| importance: | Undecided → Medium |
| tags: | added: rtm14 |
| Changed in messaging-app: | |
| status: | New → Confirmed |
| importance: | Medium → High |
| Changed in messaging-app (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Tiago Salem Herrmann (tiagosh) |
| tags: | added: touch-2014-09-11 |
| tags: |
added: touch-2014-09-25 removed: touch-2014-09-11 |
| tags: |
added: ota-1 removed: touch-2014-09-25 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in telephony-service (Ubuntu): | |
| status: | New → Fix Released |
| Changed in messaging-app (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in messaging-app: | |
| status: | Confirmed → Fix Released |
Revision history for this message
| Bill Filler (bfiller) wrote | #2 |
| Changed in telephony-service (Ubuntu): | |
| status: | Fix Released → Confirmed |
| Changed in messaging-app (Ubuntu): | |
| status: | Fix Released → Confirmed |
| no longer affects: | messaging-app |
| Changed in canonical-devices-system-image: | |
| milestone: | none → ww34-2015 |
| assignee: | nobody → Bill Filler (bfiller) |
| importance: | Undecided → High |
| status: | New → Confirmed |
Revision history for this message
| Bill Filler (bfiller) wrote | #3 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in telephony-service (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Committed |
| Changed in messaging-app (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package telephony-service - 0.1+14.
---------------
telephony-service (0.1+14.
[ CI bot ]
* Resync trunk
[ Tiago Salem Herrmann ]
* Avoid displaying on screen notifications for messages if the message
thread is open. (LP: #1347906)
* Fix messaging-menu for handling voicemail correctly on dual sim
phones.
[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Thu, 18 Sep 2014 13:21:37 +0000