Merge lp:~tiagosh/telephony-service/skip_notifications into lp:telephony-service
Status: | Merged |
---|---|
Approved by: | Bill Filler |
Approved revision: | 938 |
Merged at revision: | 938 |
Proposed branch: | lp:~tiagosh/telephony-service/skip_notifications |
Merge into: | lp:telephony-service |
Diff against target: |
57 lines (+21/-2) 2 files modified
indicator/textchannelobserver.cpp (+20/-2) indicator/textchannelobserver.h (+1/-0) |
To merge this branch: | bzr merge lp:~tiagosh/telephony-service/skip_notifications |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bill Filler (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email:
|
Commit message
Avoid displaying on screen notifications for messages if the message thread is open.
Description of the change
Avoid displaying on screen notifications for messages if the message thread is open.
--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed UI labels, did you update the pot file?
N/A
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
PASSED: Continuous integration, rev:938 jenkins. qa.ubuntu. com/job/ telephony- service- ci/308/ jenkins. qa.ubuntu. com/job/ telephony- service- utopic- amd64-ci/ 124 jenkins. qa.ubuntu. com/job/ telephony- service- utopic- armhf-ci/ 124 jenkins. qa.ubuntu. com/job/ telephony- service- utopic- armhf-ci/ 124/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ telephony- service- utopic- i386-ci/ 125
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/telephony- service- ci/308/ rebuild
http://