Add support for context menus
Bug #1326070 reported by
Chris Coulson
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
High
|
Olivier Tilloy | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
There is currently a user-script based hack in the browser to add context menus - we should really add this support natively to Oxide. I believe that the Flash PPAPI plugin requires it anyway
Related branches
lp:~osomon/oxide/context-menu
- Chris Coulson: Pending requested
-
Diff: 176 lines (+105/-19)3 files modifiedqt/tests/qmltests/api/tst_WebView_contextMenu.qml (+16/-19)
qt/tests/qmltests/api/tst_WebView_executeEditingCommand.html (+5/-0)
qt/tests/qmltests/api/tst_WebView_executeEditingCommand.qml (+84/-0)
lp:~osomon/webbrowser-app/oxide-context-menu
- Ken VanDine: Approve
- Ugo Riboni (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 2579 lines (+1390/-690)34 files modifieddebian/control (+2/-12)
debian/qtdeclarative5-ubuntu-web-plugin-assets.install (+0/-1)
debian/rules (+0/-4)
doc/WebView.qdoc (+44/-5)
src/Ubuntu/Web/CMakeLists.txt (+0/-3)
src/Ubuntu/Web/Selection.qml (+0/-161)
src/Ubuntu/Web/SelectionHandle.qml (+0/-47)
src/Ubuntu/Web/UbuntuWebView02.qml (+60/-156)
src/Ubuntu/Web/selection02.js (+2/-131)
src/app/CMakeLists.txt (+1/-0)
src/app/FileExtensionMapper.js (+11/-7)
src/app/FilePickerDialog.qml (+2/-2)
src/app/WebViewImpl.qml (+20/-9)
src/app/actions/Cut.qml (+23/-0)
src/app/actions/Erase.qml (+23/-0)
src/app/actions/Paste.qml (+23/-0)
src/app/actions/Redo.qml (+23/-0)
src/app/actions/SaveLink.qml (+23/-0)
src/app/actions/SelectAll.qml (+23/-0)
src/app/actions/Undo.qml (+23/-0)
src/app/browserapplication.cpp (+9/-0)
src/app/mime-database.cpp (+33/-0)
src/app/mime-database.h (+39/-0)
src/app/webbrowser/Browser.qml (+103/-26)
src/app/webbrowser/ContextMenuMobile.qml (+168/-0)
src/app/webbrowser/ContextMenuWide.qml (+158/-0)
src/app/webbrowser/assets/stock_link.svg (+164/-0)
src/app/webcontainer/WebViewImplOxide.qml (+42/-5)
tests/autopilot/webbrowser_app/emulators/browser.py (+33/-16)
tests/autopilot/webbrowser_app/tests/http_server.py (+28/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+177/-0)
tests/autopilot/webbrowser_app/tests/test_selection.py (+0/-92)
tests/unittests/qml/tst_FileExtensionMapper.qml (+39/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+94/-13)
| Changed in oxide: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in oxide: | |
| milestone: | none → branch-1.2 |
| assignee: | nobody → Chris Coulson (chrisccoulson) |
| Changed in oxide: | |
| status: | Triaged → In Progress |
| Changed in oxide: | |
| milestone: | branch-1.2 → branch-1.3 |
| Changed in oxide: | |
| milestone: | branch-1.3 → branch-1.4 |
| Changed in oxide: | |
| milestone: | branch-1.4 → branch-1.5 |
| Changed in oxide: | |
| milestone: | branch-1.5 → branch-1.6 |
| status: | In Progress → Triaged |
| Changed in oxide: | |
| milestone: | branch-1.6 → branch-1.7 |
| Changed in oxide: | |
| assignee: | Chris Coulson (chrisccoulson) → Olivier Tilloy (osomon) |
| tags: | added: contextmenu |
| Changed in webbrowser-app: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Olivier Tilloy (osomon) |
| Changed in oxide: | |
| status: | Triaged → In Progress |
| Changed in oxide: | |
| milestone: | branch-1.7 → branch-1.8 |
| Changed in oxide: | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Olivier Tilloy (osomon) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| no longer affects: | webbrowser-app |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+15.
---------------
webbrowser-app (0.23+15.
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Olivier Tilloy ]
* Use the contextMenu API new in oxide 1.8. Update the visuals for the
context menu in narrow and wide form factors. Add text editing
commands to the context menu. Add unit and autopilot tests for the
context menu features. This bumps the runtime dependency of webapp-
container and qtdeclarative5-
qmlplugin to 1.8. This also removes the qtdeclarative5-
plugin-assets binary package, which contained only one PNG asset
which is not used anywhere any longer. (LP: #1477310, #1477315,
#1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
#1438046)
-- CI Train Bot <email address hidden> Thu, 27 Aug 2015 14:02:08 +0000