lp:~osomon/webbrowser-app/oxide-context-menu

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:webbrowser-app at revision 1152

Ken VanDine: Approve on 2015-08-27

Ugo Riboni (community): Approve on 2015-08-27

PS Jenkins bot: Approve (continuous-integration) on 2015-08-26

Diff: 2579 lines (+1390/-690)

34 files modified

debian/control (+2/-12)
debian/qtdeclarative5-ubuntu-web-plugin-assets.install (+0/-1)
debian/rules (+0/-4)
doc/WebView.qdoc (+44/-5)
src/Ubuntu/Web/CMakeLists.txt (+0/-3)
src/Ubuntu/Web/Selection.qml (+0/-161)
src/Ubuntu/Web/SelectionHandle.qml (+0/-47)
src/Ubuntu/Web/UbuntuWebView02.qml (+60/-156)
src/Ubuntu/Web/selection02.js (+2/-131)
src/app/CMakeLists.txt (+1/-0)
src/app/FileExtensionMapper.js (+11/-7)
src/app/FilePickerDialog.qml (+2/-2)
src/app/WebViewImpl.qml (+20/-9)
src/app/actions/Cut.qml (+23/-0)
src/app/actions/Erase.qml (+23/-0)
src/app/actions/Paste.qml (+23/-0)
src/app/actions/Redo.qml (+23/-0)
src/app/actions/SaveLink.qml (+23/-0)
src/app/actions/SelectAll.qml (+23/-0)
src/app/actions/Undo.qml (+23/-0)
src/app/browserapplication.cpp (+9/-0)
src/app/mime-database.cpp (+33/-0)
src/app/mime-database.h (+39/-0)
src/app/webbrowser/Browser.qml (+103/-26)
src/app/webbrowser/ContextMenuMobile.qml (+168/-0)
src/app/webbrowser/ContextMenuWide.qml (+158/-0)
src/app/webbrowser/assets/stock_link.svg (+164/-0)
src/app/webcontainer/WebViewImplOxide.qml (+42/-5)
tests/autopilot/webbrowser_app/emulators/browser.py (+33/-16)
tests/autopilot/webbrowser_app/tests/http_server.py (+28/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+177/-0)
tests/autopilot/webbrowser_app/tests/test_selection.py (+0/-92)
tests/unittests/qml/tst_FileExtensionMapper.qml (+39/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+94/-13)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1264493: No Paste option in web page entries	High	Fix Released
Bug #1326070: Add support for context menus	High	Fix Released
Bug #1438046: Can't download protected images	Medium	Fix Released
Bug #1450430: Text selection box drawn in wrong place	High	Fix Released
Bug #1471181: Test that WebContextMenu position property is in the correct coordinate space	Medium	Fix Released
Bug #1477309: right click menu looks disabled, change the styling	Medium	Fix Released
Bug #1477310: [convergence] Save image option not appearing when right clicking on image	Medium	Fix Released
Bug #1477315: [convergence] Context menu displayed in wrong spot on desktop when invoked over links (not close to the link)	High	Fix Released
Bug #1485984: webbrowser_app.tests.test_selection.TestSelection.* flaky since oxide 1.8	High	Fix Released
Bug #1487090: Download initiated from context menu’s saveLink/saveMedia doesn’t expose a mime type	Undecided	Fix Released

Link a bug report

Related blueprints

1142. By Olivier Tilloy on 2015-08-27

Trim query parameters from the filename.

1141. By Olivier Tilloy on 2015-08-27

Increase some delays in the hope that it will make the tests more reliable (they failed twice in a row when building packages on wily).

1140. By Olivier Tilloy on 2015-08-27

Fix the computation of the device pixel ratio by ensuring we’re not using an oxide 1.9 API.

1139. By Olivier Tilloy on 2015-08-26

Use QMimeDatabase instead of a hardcoded dictionary mapping extensions to mime types.

1138. By Olivier Tilloy on 2015-08-26

Remove unused function.

1137. By Olivier Tilloy on 2015-08-26

Additional check in the unit tests.

1136. By Olivier Tilloy on 2015-08-26

Make the code more readable.

1135. By Olivier Tilloy on 2015-08-25

Add some unit tests for filenameToMimeType().

1134. By Olivier Tilloy on 2015-08-25

Mark the contextualData property deprecated, and document the contextModel property.

1133. By Olivier Tilloy on 2015-08-25

Remove the selection mechanism entirely (it was broken beyond repair anyway).
It will soon be replaced by a proper text selection mechanism in oxide (see bug #1376268).

The 'selectionActions' API is marked deprecated. It currently affects 9 applications in the store (out of a total of 1800+ apps), and those don’t do anything fancy with the API anyway (they just define the default 'Copy' action). Those apps are:

com.nokia.heremaps 1.0.7
com.ubuntu.developer.webapps.googleplus 0.6
googleapps.mattirn 0.2
mynewsapps.mattirn 0.10
mywebsites.mattirn 0.12
physorg.mattirn 0.4
stackexchange.mattirn 0.2
wikifoundation.mattirn 0.5
wikipedia.mattirn 0.3