oops using openvswitch gre tunnels with upstream commit 703133de in kernel

If I revert 77dc64ef531cfadd7d1d148f9a754e7a7c87c1f2 (703133de331a7a7df47f31fb9de51dc6f68a9de8 upstream) from the 3.5 series Ubuntu kernel the problem disappears. Will need to investigate further if this is something that should be solved in the ovs module or kernel side.

I need to find if the problem is with linux or openvswitch.

Ok so the problem is that Linux changed the prototype of ip_select_indent. We can fix this on the ovs side using the following:

diff --git a/datapath/tunnel.c b/datapath/tunnel.c
index 1ebbc77..d62e1ea 100644
--- a/datapath/tunnel.c
+++ b/datapath/tunnel.c
@@ -1294,8 +1294,14 @@ int ovs_tnl_send(struct vport *vport, struct sk_buff *skb)
                iph->tos = tos;
                iph->ttl = ttl;
                iph->frag_off = frag_off;
- ip_select_ident(iph, &rt_dst(rt), NULL);

+ /* linux commit 703133de changes the interface of
+ ip_select_ident from iph to skb */
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,2,0)
+ ip_select_ident(skb, &rt_dst(rt), NULL);
+#else
+ ip_select_ident(iph, &rt_dst(rt), NULL);
+#endif
                skb = tnl_vport->tnl_ops->update_header(vport, mutable,
                                                        &rt_dst(rt), skb);
                if (unlikely(!skb))

So we just need to check if the kernel version has this header and switch accordingly. The version I have above isn't exactly correct since there are differences between linux upstream and stable.

This commit is present in the latest 3.2/3.5 kernels for Ubuntu, therefore I'll ifdef it for 3,2,0.

Fixes pushed for P/Q.

Hello Chris, or anyone else affected,

Accepted openvswitch into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/openvswitch/1.4.6-0ubuntu1.12.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Chris, or anyone else affected,

Accepted openvswitch into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/openvswitch/1.4.6-0ubuntu1.12.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I can confirm proposed solution fixes the problem.

Patch works for me too. Thanks for it.

This bug was fixed in the package openvswitch - 1.4.6-0ubuntu1.12.04.2

---------------
openvswitch (1.4.6-0ubuntu1.12.04.2) precise; urgency=low

  * d/p/0010-datapath_ip_select_ident_fix.patch: linux commit 703133de changes
    the first parameter of ip_select_ident from iph to skb (LP: #1262692)
 -- Chris J Arges <email address hidden> Wed, 08 Jan 2014 13:36:14 -0600

The verification of the Stable Release Update for openvswitch has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package openvswitch - 1.4.6-0ubuntu1.12.10.2

---------------
openvswitch (1.4.6-0ubuntu1.12.10.2) quantal; urgency=low

  * d/p/0010-datapath_ip_select_ident_fix.patch: linux commit 703133de changes
    the first parameter of ip_select_ident from iph to skb (LP: #1262692)
 -- Chris J Arges <email address hidden> Wed, 08 Jan 2014 13:54:40 -0600

chris, can this patch work on Linux ubuntu1204 3.2.0-23-generic now ? this is a similar issue https://bugs.launchpad.net/ubuntu-advantage/+bug/1341626