Toolbar hide timer needs to be disabled when interacting with the toolbar contents

Bug #1249031 reported by Tim Peeters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Medium
Tim Peeters
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The toolbar always closes after 5s of inactivity or when the user interacts with the app. This 5s timer is not paused when the user is interacting with contents of the toolbar, and it should be.

Currently we only have buttons in toolbars which take virtually no time to click, but when we have for example sliders or textfields, the user may spend time on them while the timer keeps running.

I propose to pause the timer when the user presses the toolbar, and to reset the timer on release after a press on the toolbar. For this, Panel needs to add signals for that which can be used in Toolbar to manipulate the timer.

Related branches

Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
importance: Undecided → Medium
assignee: nobody → Tim Peeters (tpeeters)
Olivier Tilloy (osomon)
Changed in ubuntu-ui-toolkit:
status: New → Confirmed
Revision history for this message
Tim Peeters (tpeeters) wrote :

hide timer must also be reset after app is resumed, for this bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1246790

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+14.04.20131216-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+14.04.20131216-0ubuntu1) trusty; urgency=low

  [ Zsombor Egri ]
  * Layouting fails with Qt5.2 if the tests and components are not
    rendered upon testing. Layout unit tests have been transferred to
    X11 unit tests and tests on layout changes all wait till the layout
    change completes. Tested with Qt 5.0.2 and Qt 5.2 RC1. (LP:
    #1256235)
  * Picker visuals facelift, prepared for Date- and TimePicker
    components.
  * Picker selectedIndex miss-behavior fix when model is
    cleared/cropped/reset.

  [ Florian Boucault ]
  * List item progression: use appropriate icon (same as Tabs' arrow)
    and fixes the issue of it being the wrong color in Dark and Gradient
    themes. (LP: #1236777)

  [ Albert Astals ]
  * tst_arguments: Do not use QTEST_MAIN QTEST_MAIN is 99.99% of the
    times what you want when running a Qt testcase but it creates a
    Q*Application and in this case that is not wanted since we are
    creating and destroying them as part of the test and Qt doesn't like
    when there's more than one Q*Application at the same time, so do
    without creating a Q*Application in main. This can of course have
    some implications but it seems that for this testcase all is fine.
    (LP: #1254747)
  * Make the model a var and not a ListModel ListModel is bound
    specifically to QQuickListModel By using a var we can use other
    QAbstractItemModel subclasses in the model.

  [ Nic ]
  * Removed stop animation on text every time an expansion/collapse is
    made. Fixes bug #1231939. (LP: #1231939)
  * Fixed scrolling in selector when parent widget's height is less than
    the selector's ListView height. Fixes bug #1256356. (LP: #1256356)

  [ Timo Jyrinki ]
  * Require either Qt 5.2 or libqt5v8-5-private-dev.

  [ tpeeters ]
  * Reset hide timer when user interacts with toolbar or toolbar
    buttons. (LP: #1249031)
  * Improve detection of tab bar interaction. Now using the new
    TabBar.pressed property instead of TabBar.selectionMode property,
    because selectionMode may be changed without user interaction (for
    example, when resuming an app in a following MR), and then the
    toolbar should not automatically hide.
  * Open the toolbar and tabbar (without animating) when the app is
    resumed. (LP: #1246790)

  [ Christian Dywan ]
  * Accept qmldir files in qmlapicheck and skip internal components.
    (LP: #1256045)
  * Suppress qdoc warnings coming from upstream API.
  * Conditionally define doc folder containing resources. (LP: #1256779)
  * Move doc commands to shellscript and add success output lines.
  * Use Eventually when checking that the textfield is empty There's
    always a delay so we can't just compare it. (LP: #1259476)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 892
 -- Ubuntu daily release <email address hidden> Mon, 16 Dec 2013 08:17:31 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.