Replaying video crashes app (mediaplayer and browser)

Happens with mediaplayer-app and browser.

From mako's logcat:
V/MediaCodecLayer( 3434): void* media_codec_create_by_codec_name(const char*)
D/MediaCodecLayer( 3434): Creating codec 'OMX.qcom.video.decoder.avc'
V/MediaCodecLayer( 3434): _MediaCodecDelegate::_MediaCodecDelegate(void*)
I/OMXClient( 3434): Using client-side OMX mux.
I/OMXClient( 3434): Allocating remote Node (false remote).
E/OMXMaster( 3434): A component of name 'OMX.qcom.audio.decoder.aac' already exists, ignoring this one.
E/OMX-VDEC-1080P( 3434): In OMX vdec Constructor
E/OMX-VDEC-1080P( 3434): vidc.dec.debug.ts value is 0
E/OMX-VDEC-1080P( 3434): vidc.dec.debug.concealedmb value is 0
E/OMX-VDEC-1080P( 3434): vidc.dec.debug.extradata value is 0
E/OMX-VDEC-1080P( 3434):
E/OMX-VDEC-1080P( 3434): omx_vdec::component_init(): Start of New Playback : role = OMX.qcom.video.decoder.avc : DEVICE = /dev/msm_vidc_dec
E/OMX-VDEC-1080P( 3434):
E/OMX-VDEC-1080P( 3434): omx_vdec::component_init(): Open returned fd 43, errno 13
E/OMX-VDEC-1080P( 3434):
E/OMX-VDEC-1080P( 3434): omx_vdec::component_init() success
E/OMX-VDEC-1080P( 3434): omx_vdec: Async thread start
E/OMX-VDEC-1080P( 3434): omx_vdec: message thread start
V/MediaCodecLayer( 3434): virtual _MediaCodecDelegate::~_MediaCodecDelegate()
F/MediaCodec( 3434): frameworks/av/media/libstagefright/MediaCodec.cpp:74 CHECK_EQ( mState,UNINITIALIZED) failed: 2 vs. 0

Seems the internal media_codec state is not correct after fully finishing the first video playback.

Submitting MRs for a fix to this bug.

hybris media branch: https://github.com/jhodapp/libhybris/commit/4cf86ee301906b8b40805063c22326acafd985a3
qtmultimedia branch: https://github.com/jhodapp/qtmultimedia/commit/8230c02f0dc5b9e9c505b0c88c37dba0cd5be0aa

Le 05/12/2013 17:26, Jim Hodapp a écrit :
> Submitting MRs for a fix to this bug.
>
If you have test packages, I can do some testing before proposing for
image inclusion. Let me know.

... but otherwise, really cool to see a fix coming up for this! :)

No packages yet, rsalveti is going to do the MR reviews and we should be able to get packages after he approves and merges some things upstream. Thanks for the offer to test things out - I'll probably take you up on the offer given that this is a pretty large change set.

This bug was fixed in the package gst-plugins-bad1.0 - 1.2.1-1ubuntu2

---------------
gst-plugins-bad1.0 (1.2.1-1ubuntu2) trusty; urgency=medium

  * Refreshing adding-mirsink-and-android-media-over-hybris-support.patch:
    - Improved the CAPS for mirsink to use a cleaner method of constructing
      the caps, plus increased the formats it supports.
    - Adding a small delay to make sure we have the window id when doing
      hardware rendering
    - Fixing crash on EOS (LP: #1234506, LP: #1236599)
  * debian/build-deps.*:
    - Bumping dep version requirement for libmedia
 -- Ricardo Salveti de Araujo <email address hidden> Mon, 23 Dec 2013 16:06:21 -0200

Le 05/12/2013 21:25, Jim Hodapp a écrit :
> No packages yet, rsalveti is going to do the MR reviews and we should be
> able to get packages after he approves and merges some things upstream.
> Thanks for the offer to test things out - I'll probably take you up on
> the offer given that this is a pretty large change set.
>
Just to confirm that today's trusty-proposed version does not crash
anymore when playing, and rplaying the same HTML5 sample video on Youtube.

David

Thanks for the confirmation dbarth. What device did you verify this on?

Le 06/01/2014 17:13, Jim Hodapp a écrit :
> Thanks for the confirmation dbarth. What device did you verify this on?
Nexus 4 (mako) I tested with this link:
http://www.youtube.com/watch?v=JYc2jP4LLGo

David