ubuntu-download-manager

group download progress signals have incorrect byte counts

Bug #1226243 reported by Barry Warsaw on 2013-09-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	ubuntu-download-manager	Fix Released	Undecided	Unassigned
	ubuntu-download-manager (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

With the attached example file, I get this output:

SIGNAL: ('started', dbus.ObjectPath('/com/canonical/applications/download/a215ddbacb634e038d7d0d971392a92a'), dbus.Boolean(True)) {}
PROGRESS: 0 of 0
PROGRESS: 0 of 0
PROGRESS: 4085 of 4085
PROGRESS: 4085 of 4085
PROGRESS: 48679 of 48679
FINISHED

The documentation says that the progress for a group download includes the totals for the entire group, but it appears as if:

1) I'm not getting any progress for the first file.
2) Each subsequent progress signal doesn't include the running total

Here's the results after running the script:

-rw-r--r-- 1 barry barry 836 Sep 16 16:19 /tmp/archive-master.tar.xz.asc
-rw-r--r-- 1 barry barry 4085 Sep 16 16:19 /tmp/channels.json
-rw-r--r-- 1 barry barry 44594 Sep 16 16:19 /tmp/index.json

Related branches

lp:~barry/ubuntu-download-manager/lp1226243

Merged into lp:ubuntu-download-manager at revision 123

PS Jenkins bot: Approve (continuous-integration) on 2013-09-18

Mike McCracken (community): Approve on 2013-09-18

Manuel de la Peña (community): Approve on 2013-09-17

lp:ubuntu/saucy-proposed/ubuntu-download-manager

Revision history for this message

Barry Warsaw (barry) wrote on 2013-09-16:

example.py Edit (4.5 KiB, text/x-python)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-18:

Fix committed into lp:ubuntu-download-manager at revision 123, scheduled for release in ubuntu-download-manager, milestone 0.3

Changed in ubuntu-download-manager:
status:	New → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-09-20:

This bug was fixed in the package ubuntu-download-manager - 0.2+13.10.20130920.1-0ubuntu1

---------------
ubuntu-download-manager (0.2+13.10.20130920.1-0ubuntu1) saucy; urgency=low

  [ Barry Warsaw ]
  * When extracting the QPair from _downloadProgress, use a reference
    local variable so that a new QPair isn't created, thus throwing away
    the update. (LP: #1226243)

  [ Manuel de la Pena ]
  * Fixes the irl example in the test folder. (LP: #1221598)
  * Added a class that provides a way to generate secure paths to
    appamor confined applications.
  * Make use of the apparmor class to build secure dbus paths. (LP:
    #1222901)
  * Increases the test coverage of the download factory class.
  * Added the new metadata key 'objectpath' where the client can propose
    a uuid for the download that will be used to create the path. (LP:
    #1215904)
  * Change the interface name so that is less confusing. (LP: #1224538)
  * Fixed the location where the file is stored. If the local-file
    metadata is provided and the app is not cofined that would be the
    used file else the XDG/APP_ID one will be used. (LP: #1224641,
    #1222914)
  * Provide two command line args to be used in tests. (LP: #1202809)
  * Set the accept-encoding header to 'identity' so that we do not
    expand any download. (LP: #1224678)