Ubuntu
click package

The daemon crashes mid-transaction if filename does not end with .click

Bug #1205346 reported by Alejandro J. Cura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
click (Ubuntu)
Fix Released
High
Unassigned
packagekit (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

phablet@ubuntu-phablet:~$ pkcon -p install-local /home/phablet/.local/share/download_manager/{182577ab-0e3f-491f-b731-555cfb33b851}/com.ubuntu.ubuntu-clock-0.5
Transaction: Simulating install
Status: Waiting in queue
Status: Starting
Status: Loading cache
Percentage: 0
Percentage: 100
Percentage: 0
Percentage: 50
Percentage: 100
Status: Querying
The daemon crashed mid-transaction!
phablet@ubuntu-phablet:~$

Related branches

lp:click
Colin Watson: Approve
Ubuntu CI managed package branches: Pending requested
Diff: 485 lines (+269/-70)
11 files modified
README (+1/-0)
click/build.py (+10/-22)
click/framework.py (+138/-0)
click/install.py (+8/-28)
click/paths.py.in (+1/-0)
click/tests/helpers.py (+29/-0)
click/tests/test_build.py (+39/-5)
click/tests/test_install.py (+2/-4)
debian/changelog (+8/-0)
doc/file-format.rst (+1/-2)
doc/index.rst (+32/-9)
lp:ubuntu/saucy-proposed/click
lp:~ubuntu-managed-branches/click/click (Merged)
Revision history for this message
Colin Watson (cjwatson) wrote :

Probably because the MIME type doesn't match, but it should still at least fail properly rather than crashing.

Changed in click:
status: New → Triaged
importance: Undecided → High
Colin Watson (cjwatson)
affects: click → click (Ubuntu)
Revision history for this message
Colin Watson (cjwatson) wrote :

The crash is in packagekit's aptcc backend, and this patch will fix it:

  http://lists.freedesktop.org/archives/packagekit/2013-August/026149.html

I don't think there's a rush to backport that; I've added more reliable MIME type detection for click 0.3.0, which should mean that in practice this doesn't happen.

Changed in packagekit (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Changed in click (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click - 0.3.0

---------------
click (0.3.0) saucy; urgency=low

  * Insert a new "_click-binary" ar member immediately after
    "debian-binary"; this allows detecting the MIME type of a Click package
    even when it doesn't have the extension ".click" (LP: #1205346).
  * Declare the application/x-click MIME type, since the shared-mime-info
    upstream would rather not take the patch there at this point
    (https://bugs.freedesktop.org/show_bug.cgi?id=66689).
  * Make removal of old links for single-version hooks work even when the
    application ID is not a prefix of the pattern's basename.
  * Add an optional Hook-Name field to hook files, thereby allowing multiple
    hooks to attach to the same virtual name.
  * Rename click's own "desktop" hook to "click-desktop", making use of the
    new Hook-Name facility.
 -- Colin Watson <email address hidden> Tue, 06 Aug 2013 11:08:46 +0100

Changed in click (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.